You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "baiyangzhuhong (via GitHub)" <gi...@apache.org> on 2024/12/08 02:07:10 UTC
[PR] feature: https://github.com/apache/shardingsphere-elasticjob/issues/2461 [shardingsphere-elasticjob]
baiyangzhuhong opened a new pull request, #2462:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/2462
Fixes #2461.
Changes proposed in this pull request:
## Intent
As #2461 figured out, this post is to enhancement job strategy balance in the case of single sharding.
We want to let the job run on every job instance balanced like 'Round Robin' behavior, but not stick with only one certain instance.
## Solution
Basically, the design is add new single sharding handling logic which can decouple with exists logic, and can be good benefits on expanding in the future.
So there is new `SingleShardingBalanceJobShardingStrategy` and added in the SPI `/META-INF/services/org.apache.shardingsphere.elasticjob.kernel.internal.sharding.strategy.JobShardingStrategy` list. On the other side, I do codes refactor on the job facade for the entrance of job sharding strategy action. So the `JobFacade` class is modified to an interface, and we have a new `AbstractJobFacade` abstract class, then decouple the default sharding facade with single sharding facade. I do believe making `JobFacade` as an interface is better, this is also a good design following 'Open-close' principle.
```text
JobFacade
|
\|/
AbstractJobFacade
|
/ \
/ \
/ \
ShardingJobFacade SingleShardingJobFacade
```
### SingleShardingBalanceJobShardingStrategy
Obviously, if we want to do job running balanced in distribution multiple job instance environment, we need a center controlling on the balancement status, but I don't want this behavior to be heavy. So I use ephemeral node handling in zookeeper, this can be promised that one job running on every job instance balanced is guarded in normal running. And for the other scenarios, you know, some unexpected cases, is totally fallback to the default logic. It is very lightly and effiecent.
I also add unit tests on the new classes, and modified the exists tests code.
Please do check.
Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feature: https://github.com/apache/shardingsphere-elasticjob/issues/2461 [shardingsphere-elasticjob]
Posted by "baiyangzhuhong (via GitHub)" <gi...@apache.org>.
baiyangzhuhong commented on PR #2462:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/2462#issuecomment-2530462848
> Any updates?
Thanks for your advice. I follow the points what you suggested, now all code formatting validation are passed as running:
```shell
./mvnw spotless:apply -Pcheck -T1C
./mvnw checkstyle:check -Pcheck -T1C
```
The new codes are pushed, please review.
But I a little confused about that the checkstyle which caused the fields of `AbstractJobFacade` are all changed to 'private' access ability, otherwise it would fail on checkstyle testing. This is betrayed of the original intent of `AbstractJobFacade` which is a parent abstract class. Seems like it doesn't make sense and a little weired.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feature: https://github.com/apache/shardingsphere-elasticjob/issues/2461 [shardingsphere-elasticjob]
Posted by "baiyangzhuhong (via GitHub)" <gi...@apache.org>.
baiyangzhuhong commented on code in PR #2462:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/2462#discussion_r1879320336
##########
kernel/src/main/java/org/apache/shardingsphere/elasticjob/kernel/internal/schedule/JobScheduler.java:
##########
@@ -94,7 +104,15 @@ public JobScheduler(final CoordinatorRegistryCenter regCenter, final String elas
Collection<ElasticJobListener> jobListeners = getElasticJobListeners(this.jobConfig);
setUpFacade = new SetUpFacade(regCenter, this.jobConfig.getJobName(), jobListeners);
schedulerFacade = new SchedulerFacade(regCenter, this.jobConfig.getJobName());
- jobFacade = new JobFacade(regCenter, this.jobConfig.getJobName(), jobListeners, findTracingConfiguration().orElse(null));
+
+ // the single sharding scenario and specified SINGLE_SHARDING_BALANCE strategy
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feature: https://github.com/apache/shardingsphere-elasticjob/issues/2461 [shardingsphere-elasticjob]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #2462:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/2462#issuecomment-2530453265
## [Codecov](https://app.codecov.io/gh/apache/shardingsphere-elasticjob/pull/2462?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
Attention: Patch coverage is `80.43478%` with `27 lines` in your changes missing coverage. Please review.
> Project coverage is 79.47%. Comparing base [(`a8ba448`)](https://app.codecov.io/gh/apache/shardingsphere-elasticjob/commit/a8ba448927d7e237ecece9516634a44d822a1b11?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`012d7de`)](https://app.codecov.io/gh/apache/shardingsphere-elasticjob/commit/012d7de980ada79949b0f2016a6c49b5099933b5?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
> Report is 56 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/shardingsphere-elasticjob/pull/2462?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...cjob/kernel/executor/facade/AbstractJobFacade.java](https://app.codecov.io/gh/apache/shardingsphere-elasticjob/pull/2462?src=pr&el=tree&filepath=kernel%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Felasticjob%2Fkernel%2Fexecutor%2Ffacade%2FAbstractJobFacade.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-a2VybmVsL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9lbGFzdGljam9iL2tlcm5lbC9leGVjdXRvci9mYWNhZGUvQWJzdHJhY3RKb2JGYWNhZGUuamF2YQ==) | 79.54% | [8 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/shardingsphere-elasticjob/pull/2462?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ernel/executor/facade/SingleShardingJobFacade.java](https://app.codecov.io/gh/apache/shardingsphere-elasticjob/pull/2462?src=pr&el=tree&filepath=kernel%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Felasticjob%2Fkernel%2Fexecutor%2Ffacade%2FSingleShardingJobFacade.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-a2VybmVsL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9lbGFzdGljam9iL2tlcm5lbC9leGVjdXRvci9mYWNhZGUvU2luZ2xlU2hhcmRpbmdKb2JGYWNhZGUuamF2YQ==) | 85.45% | [2 Missing and 6 partials :warning: ](https://app.codecov.io/gh/apache/shardingsphere-elasticjob/pull/2462?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...sticjob/kernel/internal/schedule/JobScheduler.java](https://app.codecov.io/gh/apache/shardingsphere-elasticjob/pull/2462?src=pr&el=tree&filepath=kernel%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Felasticjob%2Fkernel%2Finternal%2Fschedule%2FJobScheduler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-a2VybmVsL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9lbGFzdGljam9iL2tlcm5lbC9pbnRlcm5hbC9zY2hlZHVsZS9Kb2JTY2hlZHVsZXIuamF2YQ==) | 0.00% | [8 Missing :warning: ](https://app.codecov.io/gh/apache/shardingsphere-elasticjob/pull/2462?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...cjob/kernel/executor/facade/ShardingJobFacade.java](https://app.codecov.io/gh/apache/shardingsphere-elasticjob/pull/2462?src=pr&el=tree&filepath=kernel%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Felasticjob%2Fkernel%2Fexecutor%2Ffacade%2FShardingJobFacade.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-a2VybmVsL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9lbGFzdGljam9iL2tlcm5lbC9leGVjdXRvci9mYWNhZGUvU2hhcmRpbmdKb2JGYWNhZGUuamF2YQ==) | 95.23% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/shardingsphere-elasticjob/pull/2462?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...type/SingleShardingBalanceJobShardingStrategy.java](https://app.codecov.io/gh/apache/shardingsphere-elasticjob/pull/2462?src=pr&el=tree&filepath=kernel%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Felasticjob%2Fkernel%2Finternal%2Fsharding%2Fstrategy%2Ftype%2FSingleShardingBalanceJobShardingStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-a2VybmVsL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9lbGFzdGljam9iL2tlcm5lbC9pbnRlcm5hbC9zaGFyZGluZy9zdHJhdGVneS90eXBlL1NpbmdsZVNoYXJkaW5nQmFsYW5jZUpvYlNoYXJkaW5nU3RyYXRlZ3kuamF2YQ==) | 90.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/shardingsphere-elasticjob/pull/2462?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #2462 +/- ##
============================================
- Coverage 80.10% 79.47% -0.64%
- Complexity 1113 1123 +10
============================================
Files 204 207 +3
Lines 3821 3897 +76
Branches 445 465 +20
============================================
+ Hits 3061 3097 +36
- Misses 570 601 +31
- Partials 190 199 +9
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/shardingsphere-elasticjob/pull/2462?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feature: https://github.com/apache/shardingsphere-elasticjob/issues/2461 [shardingsphere-elasticjob]
Posted by "baiyangzhuhong (via GitHub)" <gi...@apache.org>.
baiyangzhuhong commented on PR #2462:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/2462#issuecomment-2531225516
> How do I get the error in your picture? I didn't see any relevant error log in checkstyle CI.
Never mind. The error in the picture is gone cause I had changed the codes.
Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feature: https://github.com/apache/shardingsphere-elasticjob/issues/2461 [shardingsphere-elasticjob]
Posted by "baiyangzhuhong (via GitHub)" <gi...@apache.org>.
baiyangzhuhong commented on PR #2462:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/2462#issuecomment-2531222212
> > But I a little confused about that the checkstyle which caused the fields of AbstractJobFacade are all changed to 'private' access ability, otherwise it would fail on checkstyle testing. This is betrayed of the original intent of AbstractJobFacade which is a parent abstract class. Seems like it doesn't make sense and a little weired.
>
> * Do you mean you want to use private properties in the interface class? Can you explain why you want to do that? Interfaces should really only have public properties.
No. I am not meaning use private properties in the Interface.
What I am saying is there was checkstyle problems in the `AbstractJobFacade` class using 'protected' properties in my first commit codes, you know, this class is abstract class. I want the child class of `AbstractJobFacade` to extend the 'protected' properties. However, I have changed the codes to fix the checkstyle problems.
Never mind about that now, the current codes are still works fine.
> * CI is a bit shaky and I'm helping with retries.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feature: https://github.com/apache/shardingsphere-elasticjob/issues/2461 [shardingsphere-elasticjob]
Posted by "baiyangzhuhong (via GitHub)" <gi...@apache.org>.
baiyangzhuhong commented on PR #2462:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/2462#issuecomment-2531285878
> > > But I a little confused about that the checkstyle which caused the fields of AbstractJobFacade are all changed to 'private' access ability, otherwise it would fail on checkstyle testing. This is betrayed of the original intent of AbstractJobFacade which is a parent abstract class. Seems like it doesn't make sense and a little weired.
> >
> >
> >
> > * Do you mean you want to use private properties in the interface class? Can you explain why you want to do that? Interfaces should really only have public properties.
>
> No. I am not meaning use private properties in the Interface. What I am saying is there was checkstyle problems in the `AbstractJobFacade` class using 'protected' properties in my first commit codes, you know, this class is abstract class. I want the child class of `AbstractJobFacade` to extend the 'protected' properties. However, I have changed the codes to fix the checkstyle problems.
>
> Never mind about that now, the current codes are still works fine.
>
> > * CI is a bit shaky and I'm helping with retries.
Just for clarification,
I looked back of the checkstyle problems for first commit in the github thread, here is the original information,

you can reference the detail information from this address: https://github.com/apache/shardingsphere-elasticjob/pull/2462/checks?check_run_id=34090530003
thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feature: https://github.com/apache/shardingsphere-elasticjob/issues/2461 [shardingsphere-elasticjob]
Posted by "linghengqian (via GitHub)" <gi...@apache.org>.
linghengqian commented on code in PR #2462:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/2462#discussion_r1877940952
##########
kernel/src/main/java/org/apache/shardingsphere/elasticjob/kernel/internal/schedule/JobScheduler.java:
##########
@@ -94,7 +104,15 @@ public JobScheduler(final CoordinatorRegistryCenter regCenter, final String elas
Collection<ElasticJobListener> jobListeners = getElasticJobListeners(this.jobConfig);
setUpFacade = new SetUpFacade(regCenter, this.jobConfig.getJobName(), jobListeners);
schedulerFacade = new SchedulerFacade(regCenter, this.jobConfig.getJobName());
- jobFacade = new JobFacade(regCenter, this.jobConfig.getJobName(), jobListeners, findTracingConfiguration().orElse(null));
+
+ // the single sharding scenario and specified SINGLE_SHARDING_BALANCE strategy
Review Comment:
Please move the comment to the method signature, or remove the comment. If you put the comment inside the method body, the compiled JavaDoc may not see it.
##########
kernel/src/main/java/org/apache/shardingsphere/elasticjob/kernel/internal/schedule/JobScheduler.java:
##########
@@ -80,7 +82,15 @@ public JobScheduler(final CoordinatorRegistryCenter regCenter, final ElasticJob
Collection<ElasticJobListener> jobListeners = getElasticJobListeners(this.jobConfig);
setUpFacade = new SetUpFacade(regCenter, this.jobConfig.getJobName(), jobListeners);
schedulerFacade = new SchedulerFacade(regCenter, this.jobConfig.getJobName());
- jobFacade = new JobFacade(regCenter, this.jobConfig.getJobName(), jobListeners, findTracingConfiguration().orElse(null));
+
+ // the single sharding scenario and specified SINGLE_SHARDING_BALANCE strategy
Review Comment:
Please move the comment to the method signature, or remove the comment. If you put the comment inside the method body, the compiled JavaDoc may not see it.
##########
kernel/src/main/java/org/apache/shardingsphere/elasticjob/kernel/internal/sharding/strategy/type/SingleShardingBalanceJobShardingStrategy.java:
##########
@@ -0,0 +1,64 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.shardingsphere.elasticjob.kernel.internal.sharding.strategy.type;
+
+import java.util.ArrayList;
+import java.util.List;
+import java.util.Map;
+
+import org.apache.shardingsphere.elasticjob.kernel.internal.sharding.JobInstance;
+import org.apache.shardingsphere.elasticjob.kernel.internal.sharding.strategy.JobShardingStrategy;
+
+/**
+ * Single sharding Balance strategy, referenced of ROUND_ROBIN strategy.
+ * <pre>
+ * it resolves the problem which ROUND_ROBIN is stick with the certain one job instance
+ * for the hashcode of job name is a constant value. while with SINGLE_SHARDING_BALANCE, it allows
+ * the job running on all the job instances each one by one, just like loop the job instances.
+ *
+ * this is the real round robin balance job running in the job instance dimension.
+ * </pre>
+ *
+ * @author hongzhu
+ * @version V1.0
+ * @since 2024-12-03 19:19
Review Comment:
Please remove this personal information unless you are referencing third-party code that you do not own. If you are referencing third-party code, please make sure that the third-party has consented to your contribution of that code to the ASF.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feature: https://github.com/apache/shardingsphere-elasticjob/issues/2461 [shardingsphere-elasticjob]
Posted by "linghengqian (via GitHub)" <gi...@apache.org>.
linghengqian merged PR #2462:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/2462
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feature: https://github.com/apache/shardingsphere-elasticjob/issues/2461 [shardingsphere-elasticjob]
Posted by "baiyangzhuhong (via GitHub)" <gi...@apache.org>.
baiyangzhuhong commented on code in PR #2462:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/2462#discussion_r1879320134
##########
kernel/src/main/java/org/apache/shardingsphere/elasticjob/kernel/internal/sharding/strategy/type/SingleShardingBalanceJobShardingStrategy.java:
##########
@@ -0,0 +1,64 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.shardingsphere.elasticjob.kernel.internal.sharding.strategy.type;
+
+import java.util.ArrayList;
+import java.util.List;
+import java.util.Map;
+
+import org.apache.shardingsphere.elasticjob.kernel.internal.sharding.JobInstance;
+import org.apache.shardingsphere.elasticjob.kernel.internal.sharding.strategy.JobShardingStrategy;
+
+/**
+ * Single sharding Balance strategy, referenced of ROUND_ROBIN strategy.
+ * <pre>
+ * it resolves the problem which ROUND_ROBIN is stick with the certain one job instance
+ * for the hashcode of job name is a constant value. while with SINGLE_SHARDING_BALANCE, it allows
+ * the job running on all the job instances each one by one, just like loop the job instances.
+ *
+ * this is the real round robin balance job running in the job instance dimension.
+ * </pre>
+ *
+ * @author hongzhu
+ * @version V1.0
+ * @since 2024-12-03 19:19
Review Comment:
That's ok.
All are done, new codes are pushed.
The comments are not necessary, been removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feature: https://github.com/apache/shardingsphere-elasticjob/issues/2461 [shardingsphere-elasticjob]
Posted by "baiyangzhuhong (via GitHub)" <gi...@apache.org>.
baiyangzhuhong commented on code in PR #2462:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/2462#discussion_r1879320445
##########
kernel/src/main/java/org/apache/shardingsphere/elasticjob/kernel/internal/schedule/JobScheduler.java:
##########
@@ -80,7 +82,15 @@ public JobScheduler(final CoordinatorRegistryCenter regCenter, final ElasticJob
Collection<ElasticJobListener> jobListeners = getElasticJobListeners(this.jobConfig);
setUpFacade = new SetUpFacade(regCenter, this.jobConfig.getJobName(), jobListeners);
schedulerFacade = new SchedulerFacade(regCenter, this.jobConfig.getJobName());
- jobFacade = new JobFacade(regCenter, this.jobConfig.getJobName(), jobListeners, findTracingConfiguration().orElse(null));
+
+ // the single sharding scenario and specified SINGLE_SHARDING_BALANCE strategy
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org