You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/02/16 14:36:22 UTC

[GitHub] [airflow] eladkal commented on a change in pull request #13012: Don't suggest change to users that will break dags on 1.10.x

eladkal commented on a change in pull request #13012:
URL: https://github.com/apache/airflow/pull/13012#discussion_r576869862



##########
File path: airflow/upgrade/rules/import_changes.py
##########
@@ -80,10 +82,30 @@ class ImportChangesRule(BaseRule):
         "https://github.com/apache/airflow#backport-packages"
     )
 
+    current_airflow_version = Version(__import__("airflow").__version__)
+
+    if current_airflow_version < Version("2.0.0"):
+
+        def _filter_incompatible_renames(arg):
+            new_path = arg[1]

Review comment:
       Shouldn't this be `new_path = arg[0]` ?
   `arg[0]` is the new path while `arg[1]` is the old path.
   We want to filter out new paths that lands in ariflow.operator/sensor/hooks
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org