[GitHub] [maven-compiler-plugin] sormuras commented on issue #28: MCOMPILER-359 - Fix for NPE

[GitBox <gi...@apache.org>]

sormuras commented on issue #28: MCOMPILER-359 - Fix for NPE
URL: https://github.com/apache/maven-compiler-plugin/pull/28#issuecomment-566862745
 
 
   This is line that yields the NPE:
   https://github.com/apache/maven-compiler-plugin/blob/maven-compiler-plugin-3.8.1/src/main/java/org/apache/maven/plugin/compiler/TestCompilerMojo.java#L254
   
   The initial value assigned "cause" is tested for being "null":
   
   253:                    Throwable cause =
   pathException.getValue().getCause();
   254:                    while ( cause.getCause() != null )
   255:                    {
   256:                        cause = cause.getCause();
   257:                    }
   
   Current master branch doesn't differ, i.e. it also will throw a NPE.
   
   Robert: Should the initial cause of a "path exception value" always be
   assigned?
   If not, just report the path exception without the message pointing to the
   cause?
   
   
   On Tue, Dec 17, 2019 at 11:45 PM Jörg Hohwiller <no...@github.com>
   wrote:
   
   > good to know that CI is present. Thanks for the link. You can even
   > integrate Jenkins with github, though...
   >
   > Can you expand the integrationtest of src/it/MCOMPILER-360 ?
   >
   > To be honest. I do not know how. My problem is that I would like to figure
   > out the actual exception that was caused. Due to this NPE that is triggered
   > instead, I am unable to see what is going wrong as the important stacktrace
   > is finally lost. As I can only reproduce the error in travis-ci and not
   > locally, I am completely lost. Here is my travis log:
   > https://api.travis-ci.org/v3/job/626312654/log.txt
   >
   > I would be awesome to figure out what is really going wrong. However, I
   > fear that it will take ages till a new version of maven-compiler-plugin is
   > released where the NPE is fixed (no offence, we are all very busy coders -
   > I myself also would urgendly need to implement various fixes for
   > flatten-maven-plugin but can not find the time) and I have upgraded to that
   > version so I can see what the actual error is. Any idea how to speed up
   > this analysis?
   >
   > —
   > You are receiving this because you are subscribed to this thread.
   > Reply to this email directly, view it on GitHub
   > <https://github.com/apache/maven-compiler-plugin/pull/28?email_source=notifications&email_token=AARWLXTU3BQXZJTTASLL6X3QZFI7XA5CNFSM4J37OLY2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHEGZRI#issuecomment-566783173>,
   > or unsubscribe
   > <https://github.com/notifications/unsubscribe-auth/AARWLXSI23FSQICC4LQWWNLQZFI7XANCNFSM4J37OLYQ>
   > .
   >
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services