You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by "Fero Szabo (JIRA)" <ji...@apache.org> on 2018/11/21 12:23:00 UTC
[jira] [Comment Edited] (SQOOP-3407) Introduce methods instead of
TEMP_BASE_DIR and LOCAL_WAREHOUSE_DIR static fields
[ https://issues.apache.org/jira/browse/SQOOP-3407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16694648#comment-16694648 ]
Fero Szabo edited comment on SQOOP-3407 at 11/21/18 12:22 PM:
--------------------------------------------------------------
Hi [~vasas],
I've committed your patch, thank you for your contribution!
You can close the related review request.
was (Author: fero):
Hi [~vasas],
Thank you for your contribution!
You can close the related review request.
> Introduce methods instead of TEMP_BASE_DIR and LOCAL_WAREHOUSE_DIR static fields
> --------------------------------------------------------------------------------
>
> Key: SQOOP-3407
> URL: https://issues.apache.org/jira/browse/SQOOP-3407
> Project: Sqoop
> Issue Type: Test
> Reporter: Szabolcs Vasas
> Assignee: Szabolcs Vasas
> Priority: Major
> Attachments: SQOOP-3407.patch
>
>
> BaseSqoopTestCase.TEMP_BASE_DIR and BaseSqoopTestCase.LOCAL_WAREHOUSE_DIR are public static fields which get initialized once at the JVM startup and store the paths for the test temp and warehouse directories.
> The problem is that HBase test cases change the value of the test.build.data system property which can cause tests using these static fields to fail.
> Since we do not own the code in HBase which changes the system property we need to turn these static fields into methods which evaluate the test.build.data system property every time they invoked which will make sure that the invoking tests will be successful.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)