You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "potiuk (via GitHub)" <gi...@apache.org> on 2023/03/09 19:10:51 UTC
[GitHub] [airflow] potiuk opened a new pull request, #30002: Add capability of iterating locally on constraint files for CI image
potiuk opened a new pull request, #30002:
URL: https://github.com/apache/airflow/pull/30002
Whenever you want to upgrade a set of dependencies (for example all google packages) you might deal with a set of dependencies that are conflicting or difficult to upgrade all-at-once. And there might be multiple people working on it in parallel. This brings in the necessity of building the CI image of breeze with a different set of constraints than the ones in "main" branch of Airflow and share it with others working with you.
This PR adds the capability of storing a temporary set of constraints in the repository (during PR iteration) and use this constraint file to build the CI image, rather than constraints from the repository. It also provides appropriate README.md file explaining how to iterate and regenerate such constraint files - even multiple times when iterating.
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #30002: Add capability of iterating locally on constraint files for CI image
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #30002:
URL: https://github.com/apache/airflow/pull/30002#issuecomment-1462641056
cc: @lwyszomi
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] lwyszomi commented on pull request #30002: Add capability of iterating locally on constraint files for CI image
Posted by "lwyszomi (via GitHub)" <gi...@apache.org>.
lwyszomi commented on PR #30002:
URL: https://github.com/apache/airflow/pull/30002#issuecomment-1463691752
I didn't have time to test this yet but look ok. 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #30002: Add capability of iterating locally on constraint files for CI image
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk merged PR #30002:
URL: https://github.com/apache/airflow/pull/30002
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #30002: Add capability of iterating locally on constraint files for CI image
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #30002:
URL: https://github.com/apache/airflow/pull/30002#issuecomment-1463690167
Would be nice to merge that one - that would help to get the google provider package dependencies conundrum solved :).. I tried to do it without it and failed after attempting to push many commits to constraints-main branch for 3.11 https://github.com/apache/airflow/commits/constraints-main - this one will help to iterate much faster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org