You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/03/08 20:41:18 UTC

[GitHub] [airflow] eladkal opened a new pull request #22099: bump moto version

eladkal opened a new pull request #22099:
URL: https://github.com/apache/airflow/pull/22099


   We had to pin `responses` due to issue with moto lib https://github.com/apache/airflow/pull/22046
   
   `moto` fixed the problem https://github.com/spulec/moto/issues/4913 in 3.0.7 so we can just bump `moto` and drop the `responses` limit.
   
   <!--
   Thank you for contributing! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   In case of existing issue, reference it using one of the following:
   
   closes: #ISSUE
   related: #ISSUE
   
   How to write a good git commit message:
   http://chris.beams.io/posts/git-commit/
   -->
   
   ---
   **^ Add meaningful description above**
   
   Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
   In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] potiuk commented on pull request #22099: bump moto version

Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #22099:
URL: https://github.com/apache/airflow/pull/22099#issuecomment-1062705893


   Actually **moto** has already been updated to latest version so we can merge it stratight away witthout re-generating constraints :);


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] potiuk closed pull request #22099: bump moto version

Posted by GitBox <gi...@apache.org>.
potiuk closed pull request #22099:
URL: https://github.com/apache/airflow/pull/22099


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] potiuk commented on pull request #22099: bump moto version

Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #22099:
URL: https://github.com/apache/airflow/pull/22099#issuecomment-1062207672


   Temp doc build problem. Reopend to rebuild.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] eladkal commented on pull request #22099: bump moto version

Posted by GitBox <gi...@apache.org>.
eladkal commented on pull request #22099:
URL: https://github.com/apache/airflow/pull/22099#issuecomment-1062221340


   mmm I see the doc build is still failing with:
   
   ```
     apache-airflow                                               Traceback (most recent call last):
     apache-airflow                                                 File "/usr/local/lib/python3.7/site-packages/sphinx/registry.py", line 433, in load_extension
     apache-airflow                                                   mod = import_module(extname)
     apache-airflow                                                 File "/usr/local/lib/python3.7/importlib/__init__.py", line 127, in import_module
     apache-airflow                                                   return _bootstrap._gcd_import(name, package, level)
     apache-airflow                                                 File "<frozen importlib._bootstrap>", line 1006, in _gcd_import
     apache-airflow                                                 File "<frozen importlib._bootstrap>", line 983, in _find_and_load
     apache-airflow                                                 File "<frozen importlib._bootstrap>", line 965, in _find_and_load_unlocked
     apache-airflow                                               ModuleNotFoundError: No module named 'sphinxcontrib.jinja'
   ```
   
   and sphinx-jinja released version 1 hour ago
   https://pypi.org/project/sphinx-jinja/#history


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] potiuk commented on pull request #22099: bump moto version

Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #22099:
URL: https://github.com/apache/airflow/pull/22099#issuecomment-1062682134


   Generating constraints so that we can merge and push constraints at once (BTW. I am going to automate this case soon ).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] eladkal commented on pull request #22099: bump moto version

Posted by GitBox <gi...@apache.org>.
eladkal commented on pull request #22099:
URL: https://github.com/apache/airflow/pull/22099#issuecomment-1062668360


   rebased


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] eladkal commented on pull request #22099: bump moto version

Posted by GitBox <gi...@apache.org>.
eladkal commented on pull request #22099:
URL: https://github.com/apache/airflow/pull/22099#issuecomment-1062258613


   I'll rebase after either https://github.com/apache/airflow/pull/22101 or https://github.com/apache/airflow/pull/22100 merged and to resolve the sphinx issue.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] potiuk merged pull request #22099: bump moto version

Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #22099:
URL: https://github.com/apache/airflow/pull/22099


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org