You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@calcite.apache.org by "Vladimir Sitnikov (Jira)" <ji...@apache.org> on 2020/09/02 18:47:00 UTC
[jira] [Created] (CALCITE-4217) RelCrossType#isStruct should be
true rather than false
Vladimir Sitnikov created CALCITE-4217:
------------------------------------------
Summary: RelCrossType#isStruct should be true rather than false
Key: CALCITE-4217
URL: https://issues.apache.org/jira/browse/CALCITE-4217
Project: Calcite
Issue Type: Sub-task
Components: core
Affects Versions: 1.25.0
Reporter: Vladimir Sitnikov
Currently RelCrossType#isStruct returns false even though the default implementation in {{org.apache.calcite.rel.type.RelDataTypeImpl#isStruct}} is {{return fieldList != null}}
That results in {{getFieldList}} throwing assertion error (because it asserts {{isStruct}}), however RelCrossType#getFieldNames works OK because it asserts {{fieldList != null}}
I think it should be OK if we remove {{isStruct() { return false; } }} override and use {{isStruct}} assertion in both {{getFieldList}} and {{getFieldNames}}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)