You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Florian Barca <fb...@hortonworks.com> on 2015/06/10 02:23:41 UTC

Review Request 35275: [WinTP2] Adding a view fails on Windows

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35275/
-----------------------------------------------------------

Review request for Ambari, Artem Baranchuk, Jayush Luniya, and Tom Beerbower.


Bugs: AMBARI-11817
    https://issues.apache.org/jira/browse/AMBARI-11817


Repository: ambari


Description
-------

Fixed database column description in ViewInstanceEntity and UpgradeCatalog210


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ViewInstanceEntity.java c1400d74e58779f0ad1618074bb1e2ddaa8f8e75 
  ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog210.java 98d84e78ac478f74209bf4748e2fe334abbaf796 

Diff: https://reviews.apache.org/r/35275/diff/


Testing
-------

mvn clean build -> deploy -> create view -> all ok


Thanks,

Florian Barca


Re: Review Request 35275: [WinTP2] Adding a view fails on Windows

Posted by Jayush Luniya <jl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35275/#review87369
-----------------------------------------------------------

Ship it!


Ship It!

- Jayush Luniya


On June 10, 2015, 2:25 a.m., Florian Barca wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35275/
> -----------------------------------------------------------
> 
> (Updated June 10, 2015, 2:25 a.m.)
> 
> 
> Review request for Ambari, Artem Baranchuk, Jayush Luniya, and Tom Beerbower.
> 
> 
> Bugs: AMBARI-11817
>     https://issues.apache.org/jira/browse/AMBARI-11817
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Fixed database column description in ViewInstanceEntity and UpgradeCatalog210
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ViewInstanceEntity.java c1400d74e58779f0ad1618074bb1e2ddaa8f8e75 
>   ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog210.java 98d84e78ac478f74209bf4748e2fe334abbaf796 
>   ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql f71a4ede5a69f90ff437964403708878d271f094 
> 
> Diff: https://reviews.apache.org/r/35275/diff/
> 
> 
> Testing
> -------
> 
> mvn clean build -> deploy -> create view -> all ok
> 
> 
> Thanks,
> 
> Florian Barca
> 
>


Re: Review Request 35275: [WinTP2] Adding a view fails on Windows

Posted by Florian Barca <fb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35275/
-----------------------------------------------------------

(Updated June 10, 2015, 2:25 a.m.)


Review request for Ambari, Artem Baranchuk, Jayush Luniya, and Tom Beerbower.


Bugs: AMBARI-11817
    https://issues.apache.org/jira/browse/AMBARI-11817


Repository: ambari


Description
-------

Fixed database column description in ViewInstanceEntity and UpgradeCatalog210


Diffs (updated)
-----

  ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ViewInstanceEntity.java c1400d74e58779f0ad1618074bb1e2ddaa8f8e75 
  ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog210.java 98d84e78ac478f74209bf4748e2fe334abbaf796 
  ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql f71a4ede5a69f90ff437964403708878d271f094 

Diff: https://reviews.apache.org/r/35275/diff/


Testing
-------

mvn clean build -> deploy -> create view -> all ok


Thanks,

Florian Barca


Re: Review Request 35275: [WinTP2] Adding a view fails on Windows

Posted by Tom Beerbower <tb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35275/#review87333
-----------------------------------------------------------

Ship it!


Ship It!

- Tom Beerbower


On June 10, 2015, 12:23 a.m., Florian Barca wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35275/
> -----------------------------------------------------------
> 
> (Updated June 10, 2015, 12:23 a.m.)
> 
> 
> Review request for Ambari, Artem Baranchuk, Jayush Luniya, and Tom Beerbower.
> 
> 
> Bugs: AMBARI-11817
>     https://issues.apache.org/jira/browse/AMBARI-11817
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Fixed database column description in ViewInstanceEntity and UpgradeCatalog210
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ViewInstanceEntity.java c1400d74e58779f0ad1618074bb1e2ddaa8f8e75 
>   ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog210.java 98d84e78ac478f74209bf4748e2fe334abbaf796 
> 
> Diff: https://reviews.apache.org/r/35275/diff/
> 
> 
> Testing
> -------
> 
> mvn clean build -> deploy -> create view -> all ok
> 
> 
> Thanks,
> 
> Florian Barca
> 
>