You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2021/06/14 08:04:42 UTC

[GitHub] [commons-compress] arturobernalg opened a new pull request #206: Minor change:

arturobernalg opened a new pull request #206:
URL: https://github.com/apache/commons-compress/pull/206


   * Simplify conditions
   * Use diamond <>
   * Make final var


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-compress] garydgregory commented on pull request #206: Minor change:

Posted by GitBox <gi...@apache.org>.
garydgregory commented on pull request #206:
URL: https://github.com/apache/commons-compress/pull/206#issuecomment-860048708


   Please rebase on master. Recent changes should allow all builds to be green including Java 16 and 17-EA.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-compress] garydgregory merged pull request #206: Minor changes

Posted by GitBox <gi...@apache.org>.
garydgregory merged pull request #206:
URL: https://github.com/apache/commons-compress/pull/206


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-compress] garydgregory commented on a change in pull request #206: Minor changes

Posted by GitBox <gi...@apache.org>.
garydgregory commented on a change in pull request #206:
URL: https://github.com/apache/commons-compress/pull/206#discussion_r805995048



##########
File path: src/main/java/org/apache/commons/compress/archivers/zip/ZipArchiveEntry.java
##########
@@ -777,7 +777,7 @@ public String getName() {
     @Override
     public boolean isDirectory() {
         final String n = getName();
-        return n != null && n.endsWith("/");
+        return n.endsWith("/");

Review comment:
       It does seem that `getName()` can never be null, so maybe just `return getName().endsWith("/");` ? Same for other getName() call sites?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-compress] arturobernalg commented on pull request #206: Minor changes

Posted by GitBox <gi...@apache.org>.
arturobernalg commented on pull request #206:
URL: https://github.com/apache/commons-compress/pull/206#issuecomment-860092188


   > Please rebase on master. Recent changes should allow all builds to be green including Java 16 and 17-EA.
   
   Hi @garydgregory 
   done
   TY


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-compress] garydgregory commented on a change in pull request #206: Minor changes

Posted by GitBox <gi...@apache.org>.
garydgregory commented on a change in pull request #206:
URL: https://github.com/apache/commons-compress/pull/206#discussion_r805995048



##########
File path: src/main/java/org/apache/commons/compress/archivers/zip/ZipArchiveEntry.java
##########
@@ -777,7 +777,7 @@ public String getName() {
     @Override
     public boolean isDirectory() {
         final String n = getName();
-        return n != null && n.endsWith("/");
+        return n.endsWith("/");

Review comment:
       It does seem that `getName()` can never be null, so maybe just `return getName().endsWith("/");` ? Same for other getName() call sites?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-compress] coveralls edited a comment on pull request #206: Minor change:

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #206:
URL: https://github.com/apache/commons-compress/pull/206#issuecomment-860017962






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-compress] coveralls commented on pull request #206: Minor change:

Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #206:
URL: https://github.com/apache/commons-compress/pull/206#issuecomment-860017962


   
   [![Coverage Status](https://coveralls.io/builds/40531976/badge)](https://coveralls.io/builds/40531976)
   
   Coverage increased (+0.02%) to 86.833% when pulling **a62fbbe1da36b5ca9c70c701c52a347663ed86aa on arturobernalg:feature/minor_changes** into **c8e445990231114a15fbba688a0f487b7320fff2 on apache:master**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-compress] garydgregory commented on a change in pull request #206: Minor changes

Posted by GitBox <gi...@apache.org>.
garydgregory commented on a change in pull request #206:
URL: https://github.com/apache/commons-compress/pull/206#discussion_r809426094



##########
File path: src/main/java/org/apache/commons/compress/archivers/zip/ZipArchiveEntry.java
##########
@@ -777,7 +777,7 @@ public String getName() {
     @Override
     public boolean isDirectory() {
         final String n = getName();
-        return n != null && n.endsWith("/");
+        return n.endsWith("/");

Review comment:
       ping?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-compress] arturobernalg commented on a change in pull request #206: Minor changes

Posted by GitBox <gi...@apache.org>.
arturobernalg commented on a change in pull request #206:
URL: https://github.com/apache/commons-compress/pull/206#discussion_r809685597



##########
File path: src/main/java/org/apache/commons/compress/archivers/zip/ZipArchiveEntry.java
##########
@@ -777,7 +777,7 @@ public String getName() {
     @Override
     public boolean isDirectory() {
         final String n = getName();
-        return n != null && n.endsWith("/");
+        return n.endsWith("/");

Review comment:
       Changed.
   TY




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org