You are viewing a plain text version of this content. The canonical link for it is here.

Posted to user@mahout.apache.org by Alec Feuerstein <mi...@karoushi.net> on 2010/10/11 00:56:58 UTC

GenericJDBCDataModel constructor bug

Okay,

I think I really got one this time -- again...

org.apache.mahout.cf.taste.impl.model.jdbc.GenericJDBCDataModel

The constructor that takes properties calls the parent's constructor
(line 77ish):
...
          props.getProperty(GET_ALL_USERS_SQL_KEY),
          props.getProperty(GET_NUM_USERS_SQL_KEY),
          props.getProperty(GET_NUM_ITEMS_SQL_KEY),
          props.getProperty(SET_PREFERENCE_SQL_KEY),
...

GET_NUM_USERS_SQL_KEY and GET_NUM_ITEMS_SQL_KEY are inverted in parent
org.apache.mahout.cf.taste.impl.model.jdbc.AbstractJDBCDataModel (line
114ish):
...
                                  String getAllUsersSQL,
                                  String getNumItemsSQL,
                                  String getNumUsersSQL,
                                  String setPreferenceSQL,
...

-Alec

Re: GenericJDBCDataModel constructor bug

Posted by Sean Owen <sr...@gmail.com>.

Bleh, what a dumb typo. Good one, I've fixed it.

On Sun, Oct 10, 2010 at 11:56 PM, Alec Feuerstein <mi...@karoushi.net> wrote:
> Okay,
>
> I think I really got one this time -- again...
>
> org.apache.mahout.cf.taste.impl.model.jdbc.GenericJDBCDataModel
>
> The constructor that takes properties calls the parent's constructor
> (line 77ish):
> ...
>          props.getProperty(GET_ALL_USERS_SQL_KEY),
>          props.getProperty(GET_NUM_USERS_SQL_KEY),
>          props.getProperty(GET_NUM_ITEMS_SQL_KEY),
>          props.getProperty(SET_PREFERENCE_SQL_KEY),
> ...
>
> GET_NUM_USERS_SQL_KEY and GET_NUM_ITEMS_SQL_KEY are inverted in parent
> org.apache.mahout.cf.taste.impl.model.jdbc.AbstractJDBCDataModel (line
> 114ish):
> ...
>                                  String getAllUsersSQL,
>                                  String getNumItemsSQL,
>                                  String getNumUsersSQL,
>                                  String setPreferenceSQL,
> ...
>
> -Alec
>