You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@brooklyn.apache.org by aledsage <gi...@git.apache.org> on 2014/06/26 17:47:53 UTC

[GitHub] incubator-brooklyn pull request: Fix group on member unmanaged

GitHub user aledsage opened a pull request:

    https://github.com/apache/incubator-brooklyn/pull/24

    Fix group on member unmanaged

    Previously, the unmanaged entity would stay a member of the group.
    On rebind, this would fail (because the entity was a dangling reference). The actual error was caused by the attribute with the members being an ImmutableSet, so putting null in it failed.
    
    Now the unmanaged entity is immediately removed from all of its groups.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/aledsage/incubator-brooklyn fix/Group-on-memberUnmanaged-strike2

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-brooklyn/pull/24.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #24
    
----
commit e2207db602db4ac9e9d656d765526812d2b9ebe8
Author: Aled Sage <al...@gmail.com>
Date:   2014-06-09T05:42:19Z

    Group notified on member unmanaged
    
    - and member notified on group unmanaged.
    - done automatically, without need for registering listeners.
    - will be generalised to “relationships” at some point.

commit 258bd7dacc8b5fbb026a8214d99c9d541cd6474d
Author: Aled Sage <al...@gmail.com>
Date:   2014-06-24T19:37:49Z

    Deprecate DynamicGroup.stop

commit e518690e53810fd460c47b57088a2a7ebba9f628
Author: Aled Sage <al...@gmail.com>
Date:   2014-06-24T19:41:13Z

    Deserialize: discard dangling ref in ImmutableSet
    
    - If didn’t then it would fail to deserialise, which would cause 
      entire file to fail to deserialise.
      The dangling ref will have been logged plus handled by the 
      RebindExceptionHandler, so mostly harmless ignoring it here.

commit f620b977ba6f69c9ab72a7035345e268fc273b15
Author: Aled Sage <al...@gmail.com>
Date:   2014-06-24T21:27:35Z

    Fix logging on Effectors.invoke

commit 1a4aa4b306d91637ff04b2e41f7d47ba1d755d37
Author: Aled Sage <al...@gmail.com>
Date:   2014-06-24T21:27:52Z

    Tidy QuarantineGroup.expungeMembers

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-brooklyn pull request: Fix group on member unmanaged

Posted by ahgittin <gi...@git.apache.org>.

Github user ahgittin commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/24#discussion_r14504328
  
    --- Diff: api/src/main/java/brooklyn/entity/Entity.java ---
    @@ -135,11 +135,24 @@
         Collection<Group> getGroups();
     
         /**
    -     * Add this entity as a member of the given {@link Group}.
    +     * Add this entity as a member of the given {@link Group}. Called by framework.
    +     * <p>
    +     * Users should call {@link Group#addMember(Entity)} instead; this method will then 
    --- End diff --
    
    If this is the case maybe method should move to `EntityInternal` ?  But not in this PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-brooklyn pull request: Fix group on member unmanaged

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-brooklyn/pull/24


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-brooklyn pull request: Fix group on member unmanaged

Posted by ahgittin <gi...@git.apache.org>.

Github user ahgittin commented on the pull request:

    https://github.com/apache/incubator-brooklyn/pull/24#issuecomment-47886720
  
    good fixes, merging


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---