[GitHub] [superset] hughhhh commented on a change in pull request #16299: fix: copy to Clipboard order

[GitBox <gi...@apache.org>]

hughhhh commented on a change in pull request #16299:
URL: https://github.com/apache/superset/pull/16299#discussion_r691596648



##########
File path: superset-frontend/src/explore/components/DataTablesPane/index.tsx
##########
@@ -316,7 +315,10 @@ export const DataTablesPane = ({
   const TableControls = (
     <TableControlsWrapper>
       <RowCount data={data[activeTabKey]} loading={isLoading[activeTabKey]} />
-      <CopyToClipboardButton data={data[activeTabKey]} />
+      <CopyToClipboardButton
+        data={data[activeTabKey]}
+        columns={queryFormData.all_columns}

Review comment:
       nit: deconstruct all_columns
   
   ```
   const { all_columns } = queryFormData
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org