You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2021/01/18 17:32:37 UTC
[GitHub] [fineract] rrpawar96 commented on a change in pull request #1567: Upload-CreditReport FINERACT-1285
rrpawar96 commented on a change in pull request #1567:
URL: https://github.com/apache/fineract/pull/1567#discussion_r559716294
##########
File path: fineract-provider/src/main/java/org/apache/fineract/infrastructure/creditbureau/service/ThitsaWorksCreditBureauIntegrationWritePlatformServiceImpl.java
##########
@@ -434,10 +480,14 @@ public String getCreditBureauConfiguration(Integer creditBureauId, String config
creditBureauConfigurationValue = configurationParameterValue.getValue();
if (creditBureauConfigurationValue.isEmpty()) {
- baseDataValidator.reset().failWithCode("creditBureau.configuration." + configurationParameterName + ".is.not.available");
- throw new PlatformApiDataValidationException(
- "creditBureau.Configuration." + configurationParameterName + ".is.not.available",
- "creditBureau.Configuration.is.not.available", dataValidationErrors);
+ /*
+ * baseDataValidator.reset().failWithCode("creditBureau.configuration." + configurationParameterName +
+ * ".is.not.available"); throw new PlatformApiDataValidationException( "creditBureau.Configuration." +
+ * configurationParameterName + ".is.not.available", "creditBureau.Configuration.is.not.available",
+ * dataValidationErrors);
+ */
+ throw new PlatformDataIntegrityException("creditBureau.Configuration." + configurationParameterName + ".is.not.available",
+ "creditBureau.Configuration." + configurationParameterName + ".is.not.available");
Review comment:
Yes, it was the change in the implementation of the type of Exception, (PlatformDataIntegrityException instead of PlatformApiDataValidationException.) PlatformDataIntegrityException was more suitable to throw this exception.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org