You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2021/10/19 15:04:24 UTC
[GitHub] [geode-native] mmartell opened a new pull request #884: GEODE-9741: Use v142 Toolchain in Visual Studio 2019 CI Pipeline
mmartell opened a new pull request #884:
URL: https://github.com/apache/geode-native/pull/884
Currently the VS 2019 builds use the old toolchain (v141). All tests pass with v142, so just requires a small change to CI code, as well as adding the v142 tools to the Windows 2019 image.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode-native] mmartell commented on a change in pull request #884: GEODE-9741: Use v142 Toolchain in Visual Studio 2019 CI Pipeline
Posted by GitBox <gi...@apache.org>.
mmartell commented on a change in pull request #884:
URL: https://github.com/apache/geode-native/pull/884#discussion_r733943751
##########
File path: packer/windows/install-vs-2019-community.ps1
##########
@@ -21,22 +21,93 @@ write-host "Installing Visual Studio 2019 Community..."
$args = @('--add Microsoft.VisualStudio.Component.CoreEditor',
'--add Microsoft.VisualStudio.Workload.CoreEditor',
+ '--add Microsoft.NetCore.Component.Runtime.5.0',
+ '--add Microsoft.NetCore.Component.Runtime.3.1',
+ '--add Microsoft.NetCore.Component.SDK',
+ '--add Microsoft.VisualStudio.Component.NuGet',
'--add Microsoft.Net.Component.4.6.1.TargetingPack',
'--add Microsoft.VisualStudio.Component.Roslyn.Compiler',
+ '--add Microsoft.VisualStudio.Component.Roslyn.LanguageServices',
+ '--add Microsoft.VisualStudio.Component.FSharp',
+ '--add Microsoft.ComponentGroup.ClickOnce.Publish',
+ '--add Microsoft.NetCore.Component.DevelopmentTools',
+ '--add Microsoft.VisualStudio.Component.FSharp.WebTemplates',
+ '--add Microsoft.VisualStudio.ComponentGroup.WebToolsExtensions',
+ '--add Microsoft.VisualStudio.Component.DockerTools',
+ '--add Microsoft.NetCore.Component.Web',
'--add Microsoft.Net.Component.4.8.SDK',
+ '--add Microsoft.Net.Component.4.7.2.TargetingPack',
+ '--add Microsoft.Net.ComponentGroup.DevelopmentPrerequisites',
+ '--add Microsoft.VisualStudio.Component.TypeScript.4.3',
+ '--add Microsoft.VisualStudio.Component.JavaScript.TypeScript',
+ '--add Microsoft.VisualStudio.Component.JavaScript.Diagnostics',
'--add Microsoft.Component.MSBuild',
'--add Microsoft.VisualStudio.Component.TextTemplating',
+ '--add Component.Microsoft.VisualStudio.RazorExtension',
+ '--add Microsoft.VisualStudio.Component.IISExpress',
+ '--add Microsoft.VisualStudio.Component.SQL.ADAL',
+ '--add Microsoft.VisualStudio.Component.SQL.LocalDB.Runtime',
+ '--add Microsoft.VisualStudio.Component.Common.Azure.Tools',
+ '--add Microsoft.VisualStudio.Component.SQL.CLR',
+ '--add Microsoft.VisualStudio.Component.MSODBC.SQL',
+ '--add Microsoft.VisualStudio.Component.MSSQL.CMDLnUtils',
+ '--add Microsoft.VisualStudio.Component.ManagedDesktop.Core',
'--add Microsoft.Net.Component.4.5.2.TargetingPack',
+ '--add Microsoft.Net.Component.4.5.TargetingPack',
+ '--add Microsoft.VisualStudio.Component.SQL.SSDT',
+ '--add Microsoft.VisualStudio.Component.SQL.DataSources',
+ '--add Component.Microsoft.Web.LibraryManager',
+ '--add Component.Microsoft.WebTools.BrowserLink.WebLivePreview',
+ '--add Microsoft.VisualStudio.ComponentGroup.Web',
+ '--add Microsoft.VisualStudio.Component.Web',
+ '--add Microsoft.VisualStudio.ComponentGroup.Web.Client',
+ '--add Microsoft.Net.Component.4.TargetingPack',
+ '--add Microsoft.Net.Component.4.5.1.TargetingPack',
+ '--add Microsoft.Net.Component.4.6.TargetingPack',
+ '--add Microsoft.Net.ComponentGroup.TargetingPacks.Common',
+ '--add Component.Microsoft.VisualStudio.Web.AzureFunctions',
+ '--add Microsoft.VisualStudio.ComponentGroup.AzureFunctions',
+ '--add Microsoft.VisualStudio.Component.Azure.Compute.Emulator',
+ '--add Microsoft.VisualStudio.Component.Azure.Storage.Emulator',
+ '--add Microsoft.VisualStudio.Component.Azure.ClientLibs',
+ '--add Microsoft.VisualStudio.Component.Azure.AuthoringTools',
+ '--add Microsoft.VisualStudio.Component.CloudExplorer',
+ '--add Microsoft.VisualStudio.ComponentGroup.Web.CloudTools',
+ '--add Microsoft.VisualStudio.Component.DiagnosticTools',
+ '--add Microsoft.VisualStudio.Component.EntityFramework',
+ '--add Microsoft.VisualStudio.Component.AspNet45',
+ '--add Microsoft.VisualStudio.Component.AppInsights.Tools',
+ '--add Microsoft.VisualStudio.Component.WebDeploy',
+ '--add Microsoft.VisualStudio.Component.Debugger.JustInTime',
+ '--add Component.Microsoft.VisualStudio.LiveShare',
+ '--add Microsoft.VisualStudio.Component.WslDebugging',
'--add Microsoft.VisualStudio.Component.IntelliCode',
+ '--add Microsoft.VisualStudio.Workload.NetWeb',
+ '--add Microsoft.Component.PythonTools',
+ '--add Component.CPython3.x64',
'--add Microsoft.VisualStudio.Component.VC.CoreIde',
+ '--add Microsoft.VisualStudio.Component.VC.Tools.x86.x64',
+ '--add Microsoft.VisualStudio.Component.Graphics.Tools',
+ '--add Microsoft.VisualStudio.Component.VC.DiagnosticTools',
+ '--add Microsoft.VisualStudio.Component.Windows10SDK.19041',
+ '--add Microsoft.VisualStudio.Workload.Python',
+ '--add Microsoft.VisualStudio.Component.ManagedDesktop.Prerequisites',
+ '--add Microsoft.ComponentGroup.Blend',
+ '--add Microsoft.VisualStudio.Component.DotNetModelBuilder',
+ '--add Microsoft.VisualStudio.Workload.ManagedDesktop',
'--add Microsoft.VisualStudio.Component.VC.Redist.14.Latest',
'--add Microsoft.VisualStudio.ComponentGroup.NativeDesktop.Core',
+ '--add Microsoft.VisualStudio.ComponentGroup.WebToolsExtensions.CMake',
+ '--add Microsoft.VisualStudio.Component.VC.CMake.Project',
'--add Microsoft.VisualStudio.Component.VC.ATL',
- '--add Microsoft.VisualStudio.Component.Windows10SDK.16299',
- '--add Microsoft.VisualStudio.Component.VC.v141.x86.x64',
+ '--add Microsoft.VisualStudio.Component.VC.TestAdapterForBoostTest',
+ '--add Microsoft.VisualStudio.Component.VC.TestAdapterForGoogleTest',
+ '--add Microsoft.VisualStudio.Component.VC.CLI.Support',
+ '--add Microsoft.VisualStudio.Component.VC.ASAN',
+ '--add Microsoft.VisualStudio.Component.VC.Llvm.ClangToolset',
+ '--add Microsoft.VisualStudio.Component.VC.Llvm.Clang',
'--add Microsoft.VisualStudio.Workload.NativeDesktop',
- '--add Microsoft.VisualStudio.Component.VC.v141.CLI.Support',
Review comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode-native] mmartell commented on pull request #884: GEODE-9741: Use v142 Toolchain in Visual Studio 2019 CI Pipeline
Posted by GitBox <gi...@apache.org>.
mmartell commented on pull request #884:
URL: https://github.com/apache/geode-native/pull/884#issuecomment-950005117
A critical component in the Visual Studio install was missing: Microsoft.VisualStudio.Component.VC.Tools.x86.x64
This allows cmake to find the tools and be run from a normal command prompt. Also, without this component (which is included in the C++ Desktop Workload), you won't get any scripts installed for your normal shortcuts (like: x64 native tools command prompt).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode-native] mmartell commented on pull request #884: GEODE-9741: Use v142 Toolchain in Visual Studio 2019 CI Pipeline
Posted by GitBox <gi...@apache.org>.
mmartell commented on pull request #884:
URL: https://github.com/apache/geode-native/pull/884#issuecomment-950166476
Note: The ubuntu-20 build failure is not related to this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode-native] mmartell merged pull request #884: GEODE-9741: Use v142 Toolchain in Visual Studio 2019 CI Pipeline
Posted by GitBox <gi...@apache.org>.
mmartell merged pull request #884:
URL: https://github.com/apache/geode-native/pull/884
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode-native] mmartell commented on a change in pull request #884: GEODE-9741: Use v142 Toolchain in Visual Studio 2019 CI Pipeline
Posted by GitBox <gi...@apache.org>.
mmartell commented on a change in pull request #884:
URL: https://github.com/apache/geode-native/pull/884#discussion_r732190781
##########
File path: packer/windows/install-vs-2019-community.ps1
##########
@@ -21,22 +21,93 @@ write-host "Installing Visual Studio 2019 Community..."
$args = @('--add Microsoft.VisualStudio.Component.CoreEditor',
'--add Microsoft.VisualStudio.Workload.CoreEditor',
+ '--add Microsoft.NetCore.Component.Runtime.5.0',
+ '--add Microsoft.NetCore.Component.Runtime.3.1',
+ '--add Microsoft.NetCore.Component.SDK',
+ '--add Microsoft.VisualStudio.Component.NuGet',
'--add Microsoft.Net.Component.4.6.1.TargetingPack',
'--add Microsoft.VisualStudio.Component.Roslyn.Compiler',
+ '--add Microsoft.VisualStudio.Component.Roslyn.LanguageServices',
+ '--add Microsoft.VisualStudio.Component.FSharp',
+ '--add Microsoft.ComponentGroup.ClickOnce.Publish',
+ '--add Microsoft.NetCore.Component.DevelopmentTools',
+ '--add Microsoft.VisualStudio.Component.FSharp.WebTemplates',
+ '--add Microsoft.VisualStudio.ComponentGroup.WebToolsExtensions',
+ '--add Microsoft.VisualStudio.Component.DockerTools',
+ '--add Microsoft.NetCore.Component.Web',
'--add Microsoft.Net.Component.4.8.SDK',
+ '--add Microsoft.Net.Component.4.7.2.TargetingPack',
+ '--add Microsoft.Net.ComponentGroup.DevelopmentPrerequisites',
+ '--add Microsoft.VisualStudio.Component.TypeScript.4.3',
+ '--add Microsoft.VisualStudio.Component.JavaScript.TypeScript',
+ '--add Microsoft.VisualStudio.Component.JavaScript.Diagnostics',
'--add Microsoft.Component.MSBuild',
'--add Microsoft.VisualStudio.Component.TextTemplating',
+ '--add Component.Microsoft.VisualStudio.RazorExtension',
+ '--add Microsoft.VisualStudio.Component.IISExpress',
+ '--add Microsoft.VisualStudio.Component.SQL.ADAL',
+ '--add Microsoft.VisualStudio.Component.SQL.LocalDB.Runtime',
+ '--add Microsoft.VisualStudio.Component.Common.Azure.Tools',
+ '--add Microsoft.VisualStudio.Component.SQL.CLR',
+ '--add Microsoft.VisualStudio.Component.MSODBC.SQL',
+ '--add Microsoft.VisualStudio.Component.MSSQL.CMDLnUtils',
+ '--add Microsoft.VisualStudio.Component.ManagedDesktop.Core',
'--add Microsoft.Net.Component.4.5.2.TargetingPack',
+ '--add Microsoft.Net.Component.4.5.TargetingPack',
+ '--add Microsoft.VisualStudio.Component.SQL.SSDT',
+ '--add Microsoft.VisualStudio.Component.SQL.DataSources',
+ '--add Component.Microsoft.Web.LibraryManager',
+ '--add Component.Microsoft.WebTools.BrowserLink.WebLivePreview',
+ '--add Microsoft.VisualStudio.ComponentGroup.Web',
+ '--add Microsoft.VisualStudio.Component.Web',
+ '--add Microsoft.VisualStudio.ComponentGroup.Web.Client',
+ '--add Microsoft.Net.Component.4.TargetingPack',
+ '--add Microsoft.Net.Component.4.5.1.TargetingPack',
+ '--add Microsoft.Net.Component.4.6.TargetingPack',
+ '--add Microsoft.Net.ComponentGroup.TargetingPacks.Common',
+ '--add Component.Microsoft.VisualStudio.Web.AzureFunctions',
+ '--add Microsoft.VisualStudio.ComponentGroup.AzureFunctions',
+ '--add Microsoft.VisualStudio.Component.Azure.Compute.Emulator',
+ '--add Microsoft.VisualStudio.Component.Azure.Storage.Emulator',
+ '--add Microsoft.VisualStudio.Component.Azure.ClientLibs',
+ '--add Microsoft.VisualStudio.Component.Azure.AuthoringTools',
+ '--add Microsoft.VisualStudio.Component.CloudExplorer',
+ '--add Microsoft.VisualStudio.ComponentGroup.Web.CloudTools',
+ '--add Microsoft.VisualStudio.Component.DiagnosticTools',
+ '--add Microsoft.VisualStudio.Component.EntityFramework',
+ '--add Microsoft.VisualStudio.Component.AspNet45',
+ '--add Microsoft.VisualStudio.Component.AppInsights.Tools',
+ '--add Microsoft.VisualStudio.Component.WebDeploy',
+ '--add Microsoft.VisualStudio.Component.Debugger.JustInTime',
+ '--add Component.Microsoft.VisualStudio.LiveShare',
+ '--add Microsoft.VisualStudio.Component.WslDebugging',
'--add Microsoft.VisualStudio.Component.IntelliCode',
+ '--add Microsoft.VisualStudio.Workload.NetWeb',
+ '--add Microsoft.Component.PythonTools',
+ '--add Component.CPython3.x64',
'--add Microsoft.VisualStudio.Component.VC.CoreIde',
+ '--add Microsoft.VisualStudio.Component.VC.Tools.x86.x64',
+ '--add Microsoft.VisualStudio.Component.Graphics.Tools',
+ '--add Microsoft.VisualStudio.Component.VC.DiagnosticTools',
+ '--add Microsoft.VisualStudio.Component.Windows10SDK.19041',
Review comment:
The t142 image does take a lot longer: 65m vs 38m. I'm not sure which components can be removed, but it's probably a good optimization.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode-native] mmartell commented on a change in pull request #884: GEODE-9741: Use v142 Toolchain in Visual Studio 2019 CI Pipeline
Posted by GitBox <gi...@apache.org>.
mmartell commented on a change in pull request #884:
URL: https://github.com/apache/geode-native/pull/884#discussion_r734031653
##########
File path: packer/windows/install-vs-2019-community.ps1
##########
@@ -21,22 +21,93 @@ write-host "Installing Visual Studio 2019 Community..."
$args = @('--add Microsoft.VisualStudio.Component.CoreEditor',
'--add Microsoft.VisualStudio.Workload.CoreEditor',
+ '--add Microsoft.NetCore.Component.Runtime.5.0',
+ '--add Microsoft.NetCore.Component.Runtime.3.1',
+ '--add Microsoft.NetCore.Component.SDK',
+ '--add Microsoft.VisualStudio.Component.NuGet',
'--add Microsoft.Net.Component.4.6.1.TargetingPack',
'--add Microsoft.VisualStudio.Component.Roslyn.Compiler',
+ '--add Microsoft.VisualStudio.Component.Roslyn.LanguageServices',
+ '--add Microsoft.VisualStudio.Component.FSharp',
+ '--add Microsoft.ComponentGroup.ClickOnce.Publish',
+ '--add Microsoft.NetCore.Component.DevelopmentTools',
+ '--add Microsoft.VisualStudio.Component.FSharp.WebTemplates',
+ '--add Microsoft.VisualStudio.ComponentGroup.WebToolsExtensions',
+ '--add Microsoft.VisualStudio.Component.DockerTools',
+ '--add Microsoft.NetCore.Component.Web',
'--add Microsoft.Net.Component.4.8.SDK',
+ '--add Microsoft.Net.Component.4.7.2.TargetingPack',
+ '--add Microsoft.Net.ComponentGroup.DevelopmentPrerequisites',
+ '--add Microsoft.VisualStudio.Component.TypeScript.4.3',
+ '--add Microsoft.VisualStudio.Component.JavaScript.TypeScript',
+ '--add Microsoft.VisualStudio.Component.JavaScript.Diagnostics',
'--add Microsoft.Component.MSBuild',
'--add Microsoft.VisualStudio.Component.TextTemplating',
+ '--add Component.Microsoft.VisualStudio.RazorExtension',
+ '--add Microsoft.VisualStudio.Component.IISExpress',
+ '--add Microsoft.VisualStudio.Component.SQL.ADAL',
+ '--add Microsoft.VisualStudio.Component.SQL.LocalDB.Runtime',
+ '--add Microsoft.VisualStudio.Component.Common.Azure.Tools',
+ '--add Microsoft.VisualStudio.Component.SQL.CLR',
+ '--add Microsoft.VisualStudio.Component.MSODBC.SQL',
+ '--add Microsoft.VisualStudio.Component.MSSQL.CMDLnUtils',
+ '--add Microsoft.VisualStudio.Component.ManagedDesktop.Core',
'--add Microsoft.Net.Component.4.5.2.TargetingPack',
+ '--add Microsoft.Net.Component.4.5.TargetingPack',
+ '--add Microsoft.VisualStudio.Component.SQL.SSDT',
+ '--add Microsoft.VisualStudio.Component.SQL.DataSources',
+ '--add Component.Microsoft.Web.LibraryManager',
+ '--add Component.Microsoft.WebTools.BrowserLink.WebLivePreview',
+ '--add Microsoft.VisualStudio.ComponentGroup.Web',
+ '--add Microsoft.VisualStudio.Component.Web',
+ '--add Microsoft.VisualStudio.ComponentGroup.Web.Client',
+ '--add Microsoft.Net.Component.4.TargetingPack',
+ '--add Microsoft.Net.Component.4.5.1.TargetingPack',
+ '--add Microsoft.Net.Component.4.6.TargetingPack',
+ '--add Microsoft.Net.ComponentGroup.TargetingPacks.Common',
+ '--add Component.Microsoft.VisualStudio.Web.AzureFunctions',
+ '--add Microsoft.VisualStudio.ComponentGroup.AzureFunctions',
+ '--add Microsoft.VisualStudio.Component.Azure.Compute.Emulator',
+ '--add Microsoft.VisualStudio.Component.Azure.Storage.Emulator',
+ '--add Microsoft.VisualStudio.Component.Azure.ClientLibs',
+ '--add Microsoft.VisualStudio.Component.Azure.AuthoringTools',
+ '--add Microsoft.VisualStudio.Component.CloudExplorer',
+ '--add Microsoft.VisualStudio.ComponentGroup.Web.CloudTools',
+ '--add Microsoft.VisualStudio.Component.DiagnosticTools',
+ '--add Microsoft.VisualStudio.Component.EntityFramework',
+ '--add Microsoft.VisualStudio.Component.AspNet45',
+ '--add Microsoft.VisualStudio.Component.AppInsights.Tools',
+ '--add Microsoft.VisualStudio.Component.WebDeploy',
+ '--add Microsoft.VisualStudio.Component.Debugger.JustInTime',
+ '--add Component.Microsoft.VisualStudio.LiveShare',
+ '--add Microsoft.VisualStudio.Component.WslDebugging',
'--add Microsoft.VisualStudio.Component.IntelliCode',
+ '--add Microsoft.VisualStudio.Workload.NetWeb',
+ '--add Microsoft.Component.PythonTools',
+ '--add Component.CPython3.x64',
'--add Microsoft.VisualStudio.Component.VC.CoreIde',
+ '--add Microsoft.VisualStudio.Component.VC.Tools.x86.x64',
+ '--add Microsoft.VisualStudio.Component.Graphics.Tools',
+ '--add Microsoft.VisualStudio.Component.VC.DiagnosticTools',
+ '--add Microsoft.VisualStudio.Component.Windows10SDK.19041',
Review comment:
Agreed, there is no good reason for us to raise the bar for the SDK. Rolling back.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode-native] pivotal-jbarrett commented on a change in pull request #884: GEODE-9741: Use v142 Toolchain in Visual Studio 2019 CI Pipeline
Posted by GitBox <gi...@apache.org>.
pivotal-jbarrett commented on a change in pull request #884:
URL: https://github.com/apache/geode-native/pull/884#discussion_r732196450
##########
File path: packer/windows/install-vs-2019-community.ps1
##########
@@ -21,22 +21,93 @@ write-host "Installing Visual Studio 2019 Community..."
$args = @('--add Microsoft.VisualStudio.Component.CoreEditor',
'--add Microsoft.VisualStudio.Workload.CoreEditor',
+ '--add Microsoft.NetCore.Component.Runtime.5.0',
+ '--add Microsoft.NetCore.Component.Runtime.3.1',
+ '--add Microsoft.NetCore.Component.SDK',
+ '--add Microsoft.VisualStudio.Component.NuGet',
'--add Microsoft.Net.Component.4.6.1.TargetingPack',
'--add Microsoft.VisualStudio.Component.Roslyn.Compiler',
+ '--add Microsoft.VisualStudio.Component.Roslyn.LanguageServices',
+ '--add Microsoft.VisualStudio.Component.FSharp',
+ '--add Microsoft.ComponentGroup.ClickOnce.Publish',
+ '--add Microsoft.NetCore.Component.DevelopmentTools',
+ '--add Microsoft.VisualStudio.Component.FSharp.WebTemplates',
+ '--add Microsoft.VisualStudio.ComponentGroup.WebToolsExtensions',
+ '--add Microsoft.VisualStudio.Component.DockerTools',
+ '--add Microsoft.NetCore.Component.Web',
'--add Microsoft.Net.Component.4.8.SDK',
+ '--add Microsoft.Net.Component.4.7.2.TargetingPack',
+ '--add Microsoft.Net.ComponentGroup.DevelopmentPrerequisites',
+ '--add Microsoft.VisualStudio.Component.TypeScript.4.3',
+ '--add Microsoft.VisualStudio.Component.JavaScript.TypeScript',
+ '--add Microsoft.VisualStudio.Component.JavaScript.Diagnostics',
'--add Microsoft.Component.MSBuild',
'--add Microsoft.VisualStudio.Component.TextTemplating',
+ '--add Component.Microsoft.VisualStudio.RazorExtension',
+ '--add Microsoft.VisualStudio.Component.IISExpress',
+ '--add Microsoft.VisualStudio.Component.SQL.ADAL',
+ '--add Microsoft.VisualStudio.Component.SQL.LocalDB.Runtime',
+ '--add Microsoft.VisualStudio.Component.Common.Azure.Tools',
+ '--add Microsoft.VisualStudio.Component.SQL.CLR',
+ '--add Microsoft.VisualStudio.Component.MSODBC.SQL',
+ '--add Microsoft.VisualStudio.Component.MSSQL.CMDLnUtils',
+ '--add Microsoft.VisualStudio.Component.ManagedDesktop.Core',
'--add Microsoft.Net.Component.4.5.2.TargetingPack',
+ '--add Microsoft.Net.Component.4.5.TargetingPack',
+ '--add Microsoft.VisualStudio.Component.SQL.SSDT',
+ '--add Microsoft.VisualStudio.Component.SQL.DataSources',
+ '--add Component.Microsoft.Web.LibraryManager',
+ '--add Component.Microsoft.WebTools.BrowserLink.WebLivePreview',
+ '--add Microsoft.VisualStudio.ComponentGroup.Web',
+ '--add Microsoft.VisualStudio.Component.Web',
+ '--add Microsoft.VisualStudio.ComponentGroup.Web.Client',
+ '--add Microsoft.Net.Component.4.TargetingPack',
+ '--add Microsoft.Net.Component.4.5.1.TargetingPack',
+ '--add Microsoft.Net.Component.4.6.TargetingPack',
+ '--add Microsoft.Net.ComponentGroup.TargetingPacks.Common',
+ '--add Component.Microsoft.VisualStudio.Web.AzureFunctions',
+ '--add Microsoft.VisualStudio.ComponentGroup.AzureFunctions',
+ '--add Microsoft.VisualStudio.Component.Azure.Compute.Emulator',
+ '--add Microsoft.VisualStudio.Component.Azure.Storage.Emulator',
+ '--add Microsoft.VisualStudio.Component.Azure.ClientLibs',
+ '--add Microsoft.VisualStudio.Component.Azure.AuthoringTools',
+ '--add Microsoft.VisualStudio.Component.CloudExplorer',
+ '--add Microsoft.VisualStudio.ComponentGroup.Web.CloudTools',
+ '--add Microsoft.VisualStudio.Component.DiagnosticTools',
+ '--add Microsoft.VisualStudio.Component.EntityFramework',
+ '--add Microsoft.VisualStudio.Component.AspNet45',
+ '--add Microsoft.VisualStudio.Component.AppInsights.Tools',
+ '--add Microsoft.VisualStudio.Component.WebDeploy',
+ '--add Microsoft.VisualStudio.Component.Debugger.JustInTime',
+ '--add Component.Microsoft.VisualStudio.LiveShare',
+ '--add Microsoft.VisualStudio.Component.WslDebugging',
'--add Microsoft.VisualStudio.Component.IntelliCode',
+ '--add Microsoft.VisualStudio.Workload.NetWeb',
+ '--add Microsoft.Component.PythonTools',
+ '--add Component.CPython3.x64',
'--add Microsoft.VisualStudio.Component.VC.CoreIde',
+ '--add Microsoft.VisualStudio.Component.VC.Tools.x86.x64',
+ '--add Microsoft.VisualStudio.Component.Graphics.Tools',
+ '--add Microsoft.VisualStudio.Component.VC.DiagnosticTools',
+ '--add Microsoft.VisualStudio.Component.Windows10SDK.19041',
+ '--add Microsoft.VisualStudio.Workload.Python',
+ '--add Microsoft.VisualStudio.Component.ManagedDesktop.Prerequisites',
+ '--add Microsoft.ComponentGroup.Blend',
+ '--add Microsoft.VisualStudio.Component.DotNetModelBuilder',
+ '--add Microsoft.VisualStudio.Workload.ManagedDesktop',
'--add Microsoft.VisualStudio.Component.VC.Redist.14.Latest',
'--add Microsoft.VisualStudio.ComponentGroup.NativeDesktop.Core',
+ '--add Microsoft.VisualStudio.ComponentGroup.WebToolsExtensions.CMake',
+ '--add Microsoft.VisualStudio.Component.VC.CMake.Project',
'--add Microsoft.VisualStudio.Component.VC.ATL',
- '--add Microsoft.VisualStudio.Component.Windows10SDK.16299',
- '--add Microsoft.VisualStudio.Component.VC.v141.x86.x64',
+ '--add Microsoft.VisualStudio.Component.VC.TestAdapterForBoostTest',
+ '--add Microsoft.VisualStudio.Component.VC.TestAdapterForGoogleTest',
+ '--add Microsoft.VisualStudio.Component.VC.CLI.Support',
+ '--add Microsoft.VisualStudio.Component.VC.ASAN',
+ '--add Microsoft.VisualStudio.Component.VC.Llvm.ClangToolset',
+ '--add Microsoft.VisualStudio.Component.VC.Llvm.Clang',
'--add Microsoft.VisualStudio.Workload.NativeDesktop',
- '--add Microsoft.VisualStudio.Component.VC.v141.CLI.Support',
Review comment:
Replace `Microsoft.VisualStudio.Component.VC.v141.CLI.Support` with `Microsoft.VisualStudio.Component.VC.14.20.CLI.Support`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode-native] mmartell commented on a change in pull request #884: GEODE-9741: Use v142 Toolchain in Visual Studio 2019 CI Pipeline
Posted by GitBox <gi...@apache.org>.
mmartell commented on a change in pull request #884:
URL: https://github.com/apache/geode-native/pull/884#discussion_r732182041
##########
File path: packer/windows/install-vs-2019-community.ps1
##########
@@ -21,22 +21,93 @@ write-host "Installing Visual Studio 2019 Community..."
$args = @('--add Microsoft.VisualStudio.Component.CoreEditor',
'--add Microsoft.VisualStudio.Workload.CoreEditor',
+ '--add Microsoft.NetCore.Component.Runtime.5.0',
+ '--add Microsoft.NetCore.Component.Runtime.3.1',
+ '--add Microsoft.NetCore.Component.SDK',
+ '--add Microsoft.VisualStudio.Component.NuGet',
'--add Microsoft.Net.Component.4.6.1.TargetingPack',
'--add Microsoft.VisualStudio.Component.Roslyn.Compiler',
+ '--add Microsoft.VisualStudio.Component.Roslyn.LanguageServices',
+ '--add Microsoft.VisualStudio.Component.FSharp',
+ '--add Microsoft.ComponentGroup.ClickOnce.Publish',
+ '--add Microsoft.NetCore.Component.DevelopmentTools',
+ '--add Microsoft.VisualStudio.Component.FSharp.WebTemplates',
+ '--add Microsoft.VisualStudio.ComponentGroup.WebToolsExtensions',
+ '--add Microsoft.VisualStudio.Component.DockerTools',
+ '--add Microsoft.NetCore.Component.Web',
'--add Microsoft.Net.Component.4.8.SDK',
+ '--add Microsoft.Net.Component.4.7.2.TargetingPack',
+ '--add Microsoft.Net.ComponentGroup.DevelopmentPrerequisites',
+ '--add Microsoft.VisualStudio.Component.TypeScript.4.3',
+ '--add Microsoft.VisualStudio.Component.JavaScript.TypeScript',
+ '--add Microsoft.VisualStudio.Component.JavaScript.Diagnostics',
'--add Microsoft.Component.MSBuild',
'--add Microsoft.VisualStudio.Component.TextTemplating',
+ '--add Component.Microsoft.VisualStudio.RazorExtension',
+ '--add Microsoft.VisualStudio.Component.IISExpress',
+ '--add Microsoft.VisualStudio.Component.SQL.ADAL',
+ '--add Microsoft.VisualStudio.Component.SQL.LocalDB.Runtime',
+ '--add Microsoft.VisualStudio.Component.Common.Azure.Tools',
+ '--add Microsoft.VisualStudio.Component.SQL.CLR',
+ '--add Microsoft.VisualStudio.Component.MSODBC.SQL',
+ '--add Microsoft.VisualStudio.Component.MSSQL.CMDLnUtils',
+ '--add Microsoft.VisualStudio.Component.ManagedDesktop.Core',
'--add Microsoft.Net.Component.4.5.2.TargetingPack',
+ '--add Microsoft.Net.Component.4.5.TargetingPack',
+ '--add Microsoft.VisualStudio.Component.SQL.SSDT',
+ '--add Microsoft.VisualStudio.Component.SQL.DataSources',
+ '--add Component.Microsoft.Web.LibraryManager',
+ '--add Component.Microsoft.WebTools.BrowserLink.WebLivePreview',
+ '--add Microsoft.VisualStudio.ComponentGroup.Web',
+ '--add Microsoft.VisualStudio.Component.Web',
+ '--add Microsoft.VisualStudio.ComponentGroup.Web.Client',
+ '--add Microsoft.Net.Component.4.TargetingPack',
+ '--add Microsoft.Net.Component.4.5.1.TargetingPack',
+ '--add Microsoft.Net.Component.4.6.TargetingPack',
+ '--add Microsoft.Net.ComponentGroup.TargetingPacks.Common',
+ '--add Component.Microsoft.VisualStudio.Web.AzureFunctions',
+ '--add Microsoft.VisualStudio.ComponentGroup.AzureFunctions',
+ '--add Microsoft.VisualStudio.Component.Azure.Compute.Emulator',
+ '--add Microsoft.VisualStudio.Component.Azure.Storage.Emulator',
+ '--add Microsoft.VisualStudio.Component.Azure.ClientLibs',
+ '--add Microsoft.VisualStudio.Component.Azure.AuthoringTools',
+ '--add Microsoft.VisualStudio.Component.CloudExplorer',
+ '--add Microsoft.VisualStudio.ComponentGroup.Web.CloudTools',
+ '--add Microsoft.VisualStudio.Component.DiagnosticTools',
+ '--add Microsoft.VisualStudio.Component.EntityFramework',
+ '--add Microsoft.VisualStudio.Component.AspNet45',
+ '--add Microsoft.VisualStudio.Component.AppInsights.Tools',
+ '--add Microsoft.VisualStudio.Component.WebDeploy',
+ '--add Microsoft.VisualStudio.Component.Debugger.JustInTime',
+ '--add Component.Microsoft.VisualStudio.LiveShare',
+ '--add Microsoft.VisualStudio.Component.WslDebugging',
'--add Microsoft.VisualStudio.Component.IntelliCode',
+ '--add Microsoft.VisualStudio.Workload.NetWeb',
+ '--add Microsoft.Component.PythonTools',
+ '--add Component.CPython3.x64',
'--add Microsoft.VisualStudio.Component.VC.CoreIde',
+ '--add Microsoft.VisualStudio.Component.VC.Tools.x86.x64',
+ '--add Microsoft.VisualStudio.Component.Graphics.Tools',
+ '--add Microsoft.VisualStudio.Component.VC.DiagnosticTools',
+ '--add Microsoft.VisualStudio.Component.Windows10SDK.19041',
Review comment:
> This results in a change in the minimum toolchain and runtime an application all its other dependencies must rely on. I don't think this is something we can do in a minor release without at least discussing the ramifications on the dev@geode list.
I believe the goal is to ship a binary based on the t142 toolchain. We already ship a t141 based binary. This PR adds the new binary, but doesn't overwrite the t141 binary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode-native] pivotal-jbarrett commented on a change in pull request #884: GEODE-9741: Use v142 Toolchain in Visual Studio 2019 CI Pipeline
Posted by GitBox <gi...@apache.org>.
pivotal-jbarrett commented on a change in pull request #884:
URL: https://github.com/apache/geode-native/pull/884#discussion_r732072002
##########
File path: packer/windows/install-vs-2019-community.ps1
##########
@@ -21,22 +21,93 @@ write-host "Installing Visual Studio 2019 Community..."
$args = @('--add Microsoft.VisualStudio.Component.CoreEditor',
'--add Microsoft.VisualStudio.Workload.CoreEditor',
+ '--add Microsoft.NetCore.Component.Runtime.5.0',
+ '--add Microsoft.NetCore.Component.Runtime.3.1',
+ '--add Microsoft.NetCore.Component.SDK',
+ '--add Microsoft.VisualStudio.Component.NuGet',
'--add Microsoft.Net.Component.4.6.1.TargetingPack',
'--add Microsoft.VisualStudio.Component.Roslyn.Compiler',
+ '--add Microsoft.VisualStudio.Component.Roslyn.LanguageServices',
+ '--add Microsoft.VisualStudio.Component.FSharp',
+ '--add Microsoft.ComponentGroup.ClickOnce.Publish',
+ '--add Microsoft.NetCore.Component.DevelopmentTools',
+ '--add Microsoft.VisualStudio.Component.FSharp.WebTemplates',
+ '--add Microsoft.VisualStudio.ComponentGroup.WebToolsExtensions',
+ '--add Microsoft.VisualStudio.Component.DockerTools',
+ '--add Microsoft.NetCore.Component.Web',
'--add Microsoft.Net.Component.4.8.SDK',
+ '--add Microsoft.Net.Component.4.7.2.TargetingPack',
+ '--add Microsoft.Net.ComponentGroup.DevelopmentPrerequisites',
+ '--add Microsoft.VisualStudio.Component.TypeScript.4.3',
+ '--add Microsoft.VisualStudio.Component.JavaScript.TypeScript',
+ '--add Microsoft.VisualStudio.Component.JavaScript.Diagnostics',
'--add Microsoft.Component.MSBuild',
'--add Microsoft.VisualStudio.Component.TextTemplating',
+ '--add Component.Microsoft.VisualStudio.RazorExtension',
+ '--add Microsoft.VisualStudio.Component.IISExpress',
+ '--add Microsoft.VisualStudio.Component.SQL.ADAL',
+ '--add Microsoft.VisualStudio.Component.SQL.LocalDB.Runtime',
+ '--add Microsoft.VisualStudio.Component.Common.Azure.Tools',
+ '--add Microsoft.VisualStudio.Component.SQL.CLR',
+ '--add Microsoft.VisualStudio.Component.MSODBC.SQL',
+ '--add Microsoft.VisualStudio.Component.MSSQL.CMDLnUtils',
+ '--add Microsoft.VisualStudio.Component.ManagedDesktop.Core',
'--add Microsoft.Net.Component.4.5.2.TargetingPack',
+ '--add Microsoft.Net.Component.4.5.TargetingPack',
+ '--add Microsoft.VisualStudio.Component.SQL.SSDT',
+ '--add Microsoft.VisualStudio.Component.SQL.DataSources',
+ '--add Component.Microsoft.Web.LibraryManager',
+ '--add Component.Microsoft.WebTools.BrowserLink.WebLivePreview',
+ '--add Microsoft.VisualStudio.ComponentGroup.Web',
+ '--add Microsoft.VisualStudio.Component.Web',
+ '--add Microsoft.VisualStudio.ComponentGroup.Web.Client',
+ '--add Microsoft.Net.Component.4.TargetingPack',
+ '--add Microsoft.Net.Component.4.5.1.TargetingPack',
+ '--add Microsoft.Net.Component.4.6.TargetingPack',
+ '--add Microsoft.Net.ComponentGroup.TargetingPacks.Common',
+ '--add Component.Microsoft.VisualStudio.Web.AzureFunctions',
+ '--add Microsoft.VisualStudio.ComponentGroup.AzureFunctions',
+ '--add Microsoft.VisualStudio.Component.Azure.Compute.Emulator',
+ '--add Microsoft.VisualStudio.Component.Azure.Storage.Emulator',
+ '--add Microsoft.VisualStudio.Component.Azure.ClientLibs',
+ '--add Microsoft.VisualStudio.Component.Azure.AuthoringTools',
+ '--add Microsoft.VisualStudio.Component.CloudExplorer',
+ '--add Microsoft.VisualStudio.ComponentGroup.Web.CloudTools',
+ '--add Microsoft.VisualStudio.Component.DiagnosticTools',
+ '--add Microsoft.VisualStudio.Component.EntityFramework',
+ '--add Microsoft.VisualStudio.Component.AspNet45',
+ '--add Microsoft.VisualStudio.Component.AppInsights.Tools',
+ '--add Microsoft.VisualStudio.Component.WebDeploy',
+ '--add Microsoft.VisualStudio.Component.Debugger.JustInTime',
+ '--add Component.Microsoft.VisualStudio.LiveShare',
+ '--add Microsoft.VisualStudio.Component.WslDebugging',
'--add Microsoft.VisualStudio.Component.IntelliCode',
+ '--add Microsoft.VisualStudio.Workload.NetWeb',
+ '--add Microsoft.Component.PythonTools',
+ '--add Component.CPython3.x64',
'--add Microsoft.VisualStudio.Component.VC.CoreIde',
+ '--add Microsoft.VisualStudio.Component.VC.Tools.x86.x64',
+ '--add Microsoft.VisualStudio.Component.Graphics.Tools',
+ '--add Microsoft.VisualStudio.Component.VC.DiagnosticTools',
+ '--add Microsoft.VisualStudio.Component.Windows10SDK.19041',
Review comment:
Why are we installing all these additional and unnecessary tooling in the image? This has caused issues in the past with the image builds taking very long or hanging.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode-native] pivotal-jbarrett commented on a change in pull request #884: GEODE-9741: Use v142 Toolchain in Visual Studio 2019 CI Pipeline
Posted by GitBox <gi...@apache.org>.
pivotal-jbarrett commented on a change in pull request #884:
URL: https://github.com/apache/geode-native/pull/884#discussion_r732196996
##########
File path: packer/windows/install-vs-2019-community.ps1
##########
@@ -21,22 +21,93 @@ write-host "Installing Visual Studio 2019 Community..."
$args = @('--add Microsoft.VisualStudio.Component.CoreEditor',
'--add Microsoft.VisualStudio.Workload.CoreEditor',
+ '--add Microsoft.NetCore.Component.Runtime.5.0',
+ '--add Microsoft.NetCore.Component.Runtime.3.1',
+ '--add Microsoft.NetCore.Component.SDK',
+ '--add Microsoft.VisualStudio.Component.NuGet',
'--add Microsoft.Net.Component.4.6.1.TargetingPack',
'--add Microsoft.VisualStudio.Component.Roslyn.Compiler',
+ '--add Microsoft.VisualStudio.Component.Roslyn.LanguageServices',
+ '--add Microsoft.VisualStudio.Component.FSharp',
+ '--add Microsoft.ComponentGroup.ClickOnce.Publish',
+ '--add Microsoft.NetCore.Component.DevelopmentTools',
+ '--add Microsoft.VisualStudio.Component.FSharp.WebTemplates',
+ '--add Microsoft.VisualStudio.ComponentGroup.WebToolsExtensions',
+ '--add Microsoft.VisualStudio.Component.DockerTools',
+ '--add Microsoft.NetCore.Component.Web',
'--add Microsoft.Net.Component.4.8.SDK',
+ '--add Microsoft.Net.Component.4.7.2.TargetingPack',
+ '--add Microsoft.Net.ComponentGroup.DevelopmentPrerequisites',
+ '--add Microsoft.VisualStudio.Component.TypeScript.4.3',
+ '--add Microsoft.VisualStudio.Component.JavaScript.TypeScript',
+ '--add Microsoft.VisualStudio.Component.JavaScript.Diagnostics',
'--add Microsoft.Component.MSBuild',
'--add Microsoft.VisualStudio.Component.TextTemplating',
+ '--add Component.Microsoft.VisualStudio.RazorExtension',
+ '--add Microsoft.VisualStudio.Component.IISExpress',
+ '--add Microsoft.VisualStudio.Component.SQL.ADAL',
+ '--add Microsoft.VisualStudio.Component.SQL.LocalDB.Runtime',
+ '--add Microsoft.VisualStudio.Component.Common.Azure.Tools',
+ '--add Microsoft.VisualStudio.Component.SQL.CLR',
+ '--add Microsoft.VisualStudio.Component.MSODBC.SQL',
+ '--add Microsoft.VisualStudio.Component.MSSQL.CMDLnUtils',
+ '--add Microsoft.VisualStudio.Component.ManagedDesktop.Core',
'--add Microsoft.Net.Component.4.5.2.TargetingPack',
+ '--add Microsoft.Net.Component.4.5.TargetingPack',
+ '--add Microsoft.VisualStudio.Component.SQL.SSDT',
+ '--add Microsoft.VisualStudio.Component.SQL.DataSources',
+ '--add Component.Microsoft.Web.LibraryManager',
+ '--add Component.Microsoft.WebTools.BrowserLink.WebLivePreview',
+ '--add Microsoft.VisualStudio.ComponentGroup.Web',
+ '--add Microsoft.VisualStudio.Component.Web',
+ '--add Microsoft.VisualStudio.ComponentGroup.Web.Client',
+ '--add Microsoft.Net.Component.4.TargetingPack',
+ '--add Microsoft.Net.Component.4.5.1.TargetingPack',
+ '--add Microsoft.Net.Component.4.6.TargetingPack',
+ '--add Microsoft.Net.ComponentGroup.TargetingPacks.Common',
+ '--add Component.Microsoft.VisualStudio.Web.AzureFunctions',
+ '--add Microsoft.VisualStudio.ComponentGroup.AzureFunctions',
+ '--add Microsoft.VisualStudio.Component.Azure.Compute.Emulator',
+ '--add Microsoft.VisualStudio.Component.Azure.Storage.Emulator',
+ '--add Microsoft.VisualStudio.Component.Azure.ClientLibs',
+ '--add Microsoft.VisualStudio.Component.Azure.AuthoringTools',
+ '--add Microsoft.VisualStudio.Component.CloudExplorer',
+ '--add Microsoft.VisualStudio.ComponentGroup.Web.CloudTools',
+ '--add Microsoft.VisualStudio.Component.DiagnosticTools',
+ '--add Microsoft.VisualStudio.Component.EntityFramework',
+ '--add Microsoft.VisualStudio.Component.AspNet45',
+ '--add Microsoft.VisualStudio.Component.AppInsights.Tools',
+ '--add Microsoft.VisualStudio.Component.WebDeploy',
+ '--add Microsoft.VisualStudio.Component.Debugger.JustInTime',
+ '--add Component.Microsoft.VisualStudio.LiveShare',
+ '--add Microsoft.VisualStudio.Component.WslDebugging',
'--add Microsoft.VisualStudio.Component.IntelliCode',
+ '--add Microsoft.VisualStudio.Workload.NetWeb',
+ '--add Microsoft.Component.PythonTools',
+ '--add Component.CPython3.x64',
'--add Microsoft.VisualStudio.Component.VC.CoreIde',
+ '--add Microsoft.VisualStudio.Component.VC.Tools.x86.x64',
+ '--add Microsoft.VisualStudio.Component.Graphics.Tools',
+ '--add Microsoft.VisualStudio.Component.VC.DiagnosticTools',
+ '--add Microsoft.VisualStudio.Component.Windows10SDK.19041',
Review comment:
Aside from the change you found for the SDK, the only other changes should be to the tools versions and I included those changes in follow up comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode-native] mmartell commented on a change in pull request #884: GEODE-9741: Use v142 Toolchain in Visual Studio 2019 CI Pipeline
Posted by GitBox <gi...@apache.org>.
mmartell commented on a change in pull request #884:
URL: https://github.com/apache/geode-native/pull/884#discussion_r732190781
##########
File path: packer/windows/install-vs-2019-community.ps1
##########
@@ -21,22 +21,93 @@ write-host "Installing Visual Studio 2019 Community..."
$args = @('--add Microsoft.VisualStudio.Component.CoreEditor',
'--add Microsoft.VisualStudio.Workload.CoreEditor',
+ '--add Microsoft.NetCore.Component.Runtime.5.0',
+ '--add Microsoft.NetCore.Component.Runtime.3.1',
+ '--add Microsoft.NetCore.Component.SDK',
+ '--add Microsoft.VisualStudio.Component.NuGet',
'--add Microsoft.Net.Component.4.6.1.TargetingPack',
'--add Microsoft.VisualStudio.Component.Roslyn.Compiler',
+ '--add Microsoft.VisualStudio.Component.Roslyn.LanguageServices',
+ '--add Microsoft.VisualStudio.Component.FSharp',
+ '--add Microsoft.ComponentGroup.ClickOnce.Publish',
+ '--add Microsoft.NetCore.Component.DevelopmentTools',
+ '--add Microsoft.VisualStudio.Component.FSharp.WebTemplates',
+ '--add Microsoft.VisualStudio.ComponentGroup.WebToolsExtensions',
+ '--add Microsoft.VisualStudio.Component.DockerTools',
+ '--add Microsoft.NetCore.Component.Web',
'--add Microsoft.Net.Component.4.8.SDK',
+ '--add Microsoft.Net.Component.4.7.2.TargetingPack',
+ '--add Microsoft.Net.ComponentGroup.DevelopmentPrerequisites',
+ '--add Microsoft.VisualStudio.Component.TypeScript.4.3',
+ '--add Microsoft.VisualStudio.Component.JavaScript.TypeScript',
+ '--add Microsoft.VisualStudio.Component.JavaScript.Diagnostics',
'--add Microsoft.Component.MSBuild',
'--add Microsoft.VisualStudio.Component.TextTemplating',
+ '--add Component.Microsoft.VisualStudio.RazorExtension',
+ '--add Microsoft.VisualStudio.Component.IISExpress',
+ '--add Microsoft.VisualStudio.Component.SQL.ADAL',
+ '--add Microsoft.VisualStudio.Component.SQL.LocalDB.Runtime',
+ '--add Microsoft.VisualStudio.Component.Common.Azure.Tools',
+ '--add Microsoft.VisualStudio.Component.SQL.CLR',
+ '--add Microsoft.VisualStudio.Component.MSODBC.SQL',
+ '--add Microsoft.VisualStudio.Component.MSSQL.CMDLnUtils',
+ '--add Microsoft.VisualStudio.Component.ManagedDesktop.Core',
'--add Microsoft.Net.Component.4.5.2.TargetingPack',
+ '--add Microsoft.Net.Component.4.5.TargetingPack',
+ '--add Microsoft.VisualStudio.Component.SQL.SSDT',
+ '--add Microsoft.VisualStudio.Component.SQL.DataSources',
+ '--add Component.Microsoft.Web.LibraryManager',
+ '--add Component.Microsoft.WebTools.BrowserLink.WebLivePreview',
+ '--add Microsoft.VisualStudio.ComponentGroup.Web',
+ '--add Microsoft.VisualStudio.Component.Web',
+ '--add Microsoft.VisualStudio.ComponentGroup.Web.Client',
+ '--add Microsoft.Net.Component.4.TargetingPack',
+ '--add Microsoft.Net.Component.4.5.1.TargetingPack',
+ '--add Microsoft.Net.Component.4.6.TargetingPack',
+ '--add Microsoft.Net.ComponentGroup.TargetingPacks.Common',
+ '--add Component.Microsoft.VisualStudio.Web.AzureFunctions',
+ '--add Microsoft.VisualStudio.ComponentGroup.AzureFunctions',
+ '--add Microsoft.VisualStudio.Component.Azure.Compute.Emulator',
+ '--add Microsoft.VisualStudio.Component.Azure.Storage.Emulator',
+ '--add Microsoft.VisualStudio.Component.Azure.ClientLibs',
+ '--add Microsoft.VisualStudio.Component.Azure.AuthoringTools',
+ '--add Microsoft.VisualStudio.Component.CloudExplorer',
+ '--add Microsoft.VisualStudio.ComponentGroup.Web.CloudTools',
+ '--add Microsoft.VisualStudio.Component.DiagnosticTools',
+ '--add Microsoft.VisualStudio.Component.EntityFramework',
+ '--add Microsoft.VisualStudio.Component.AspNet45',
+ '--add Microsoft.VisualStudio.Component.AppInsights.Tools',
+ '--add Microsoft.VisualStudio.Component.WebDeploy',
+ '--add Microsoft.VisualStudio.Component.Debugger.JustInTime',
+ '--add Component.Microsoft.VisualStudio.LiveShare',
+ '--add Microsoft.VisualStudio.Component.WslDebugging',
'--add Microsoft.VisualStudio.Component.IntelliCode',
+ '--add Microsoft.VisualStudio.Workload.NetWeb',
+ '--add Microsoft.Component.PythonTools',
+ '--add Component.CPython3.x64',
'--add Microsoft.VisualStudio.Component.VC.CoreIde',
+ '--add Microsoft.VisualStudio.Component.VC.Tools.x86.x64',
+ '--add Microsoft.VisualStudio.Component.Graphics.Tools',
+ '--add Microsoft.VisualStudio.Component.VC.DiagnosticTools',
+ '--add Microsoft.VisualStudio.Component.Windows10SDK.19041',
Review comment:
The t142 image does take a lot longer: 65m vs 38. I'm not sure which components can be removed, but it's probably a good optimization.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode-native] pivotal-jbarrett commented on a change in pull request #884: GEODE-9741: Use v142 Toolchain in Visual Studio 2019 CI Pipeline
Posted by GitBox <gi...@apache.org>.
pivotal-jbarrett commented on a change in pull request #884:
URL: https://github.com/apache/geode-native/pull/884#discussion_r732198295
##########
File path: packer/windows/install-vs-2019-community.ps1
##########
@@ -21,22 +21,93 @@ write-host "Installing Visual Studio 2019 Community..."
$args = @('--add Microsoft.VisualStudio.Component.CoreEditor',
'--add Microsoft.VisualStudio.Workload.CoreEditor',
+ '--add Microsoft.NetCore.Component.Runtime.5.0',
+ '--add Microsoft.NetCore.Component.Runtime.3.1',
+ '--add Microsoft.NetCore.Component.SDK',
+ '--add Microsoft.VisualStudio.Component.NuGet',
'--add Microsoft.Net.Component.4.6.1.TargetingPack',
'--add Microsoft.VisualStudio.Component.Roslyn.Compiler',
+ '--add Microsoft.VisualStudio.Component.Roslyn.LanguageServices',
+ '--add Microsoft.VisualStudio.Component.FSharp',
+ '--add Microsoft.ComponentGroup.ClickOnce.Publish',
+ '--add Microsoft.NetCore.Component.DevelopmentTools',
+ '--add Microsoft.VisualStudio.Component.FSharp.WebTemplates',
+ '--add Microsoft.VisualStudio.ComponentGroup.WebToolsExtensions',
+ '--add Microsoft.VisualStudio.Component.DockerTools',
+ '--add Microsoft.NetCore.Component.Web',
'--add Microsoft.Net.Component.4.8.SDK',
+ '--add Microsoft.Net.Component.4.7.2.TargetingPack',
+ '--add Microsoft.Net.ComponentGroup.DevelopmentPrerequisites',
+ '--add Microsoft.VisualStudio.Component.TypeScript.4.3',
+ '--add Microsoft.VisualStudio.Component.JavaScript.TypeScript',
+ '--add Microsoft.VisualStudio.Component.JavaScript.Diagnostics',
'--add Microsoft.Component.MSBuild',
'--add Microsoft.VisualStudio.Component.TextTemplating',
+ '--add Component.Microsoft.VisualStudio.RazorExtension',
+ '--add Microsoft.VisualStudio.Component.IISExpress',
+ '--add Microsoft.VisualStudio.Component.SQL.ADAL',
+ '--add Microsoft.VisualStudio.Component.SQL.LocalDB.Runtime',
+ '--add Microsoft.VisualStudio.Component.Common.Azure.Tools',
+ '--add Microsoft.VisualStudio.Component.SQL.CLR',
+ '--add Microsoft.VisualStudio.Component.MSODBC.SQL',
+ '--add Microsoft.VisualStudio.Component.MSSQL.CMDLnUtils',
+ '--add Microsoft.VisualStudio.Component.ManagedDesktop.Core',
'--add Microsoft.Net.Component.4.5.2.TargetingPack',
+ '--add Microsoft.Net.Component.4.5.TargetingPack',
+ '--add Microsoft.VisualStudio.Component.SQL.SSDT',
+ '--add Microsoft.VisualStudio.Component.SQL.DataSources',
+ '--add Component.Microsoft.Web.LibraryManager',
+ '--add Component.Microsoft.WebTools.BrowserLink.WebLivePreview',
+ '--add Microsoft.VisualStudio.ComponentGroup.Web',
+ '--add Microsoft.VisualStudio.Component.Web',
+ '--add Microsoft.VisualStudio.ComponentGroup.Web.Client',
+ '--add Microsoft.Net.Component.4.TargetingPack',
+ '--add Microsoft.Net.Component.4.5.1.TargetingPack',
+ '--add Microsoft.Net.Component.4.6.TargetingPack',
+ '--add Microsoft.Net.ComponentGroup.TargetingPacks.Common',
+ '--add Component.Microsoft.VisualStudio.Web.AzureFunctions',
+ '--add Microsoft.VisualStudio.ComponentGroup.AzureFunctions',
+ '--add Microsoft.VisualStudio.Component.Azure.Compute.Emulator',
+ '--add Microsoft.VisualStudio.Component.Azure.Storage.Emulator',
+ '--add Microsoft.VisualStudio.Component.Azure.ClientLibs',
+ '--add Microsoft.VisualStudio.Component.Azure.AuthoringTools',
+ '--add Microsoft.VisualStudio.Component.CloudExplorer',
+ '--add Microsoft.VisualStudio.ComponentGroup.Web.CloudTools',
+ '--add Microsoft.VisualStudio.Component.DiagnosticTools',
+ '--add Microsoft.VisualStudio.Component.EntityFramework',
+ '--add Microsoft.VisualStudio.Component.AspNet45',
+ '--add Microsoft.VisualStudio.Component.AppInsights.Tools',
+ '--add Microsoft.VisualStudio.Component.WebDeploy',
+ '--add Microsoft.VisualStudio.Component.Debugger.JustInTime',
+ '--add Component.Microsoft.VisualStudio.LiveShare',
+ '--add Microsoft.VisualStudio.Component.WslDebugging',
'--add Microsoft.VisualStudio.Component.IntelliCode',
+ '--add Microsoft.VisualStudio.Workload.NetWeb',
+ '--add Microsoft.Component.PythonTools',
+ '--add Component.CPython3.x64',
'--add Microsoft.VisualStudio.Component.VC.CoreIde',
+ '--add Microsoft.VisualStudio.Component.VC.Tools.x86.x64',
+ '--add Microsoft.VisualStudio.Component.Graphics.Tools',
+ '--add Microsoft.VisualStudio.Component.VC.DiagnosticTools',
+ '--add Microsoft.VisualStudio.Component.Windows10SDK.19041',
+ '--add Microsoft.VisualStudio.Workload.Python',
+ '--add Microsoft.VisualStudio.Component.ManagedDesktop.Prerequisites',
+ '--add Microsoft.ComponentGroup.Blend',
+ '--add Microsoft.VisualStudio.Component.DotNetModelBuilder',
+ '--add Microsoft.VisualStudio.Workload.ManagedDesktop',
'--add Microsoft.VisualStudio.Component.VC.Redist.14.Latest',
Review comment:
This particular component would get the latest 14.x toolkit each time the image is built and result in a moving minimum target for MSVC runtime.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode-native] echobravopapa commented on a change in pull request #884: GEODE-9741: Use v142 Toolchain in Visual Studio 2019 CI Pipeline
Posted by GitBox <gi...@apache.org>.
echobravopapa commented on a change in pull request #884:
URL: https://github.com/apache/geode-native/pull/884#discussion_r732025247
##########
File path: ci/base/base.yml
##########
@@ -72,7 +72,7 @@ builds:
with_dot_net: #@ True
#@yaml/map-key-override
params:
- CMAKE_CONFIGURE_FLAGS: "-A x64 -Tv141,version=14.16,host=x64 -DCMAKE_SYSTEM_VERSION=10.0.16299.0"
+ CMAKE_CONFIGURE_FLAGS: "-A x64 -Tv142,version=14.29,host=x64 -DCMAKE_SYSTEM_VERSION=10.0.19041.0"
Review comment:
will this change effect the vs2017/v141 pipes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode-native] mmartell commented on a change in pull request #884: GEODE-9741: Use v142 Toolchain in Visual Studio 2019 CI Pipeline
Posted by GitBox <gi...@apache.org>.
mmartell commented on a change in pull request #884:
URL: https://github.com/apache/geode-native/pull/884#discussion_r732061918
##########
File path: ci/base/base.yml
##########
@@ -72,7 +72,7 @@ builds:
with_dot_net: #@ True
#@yaml/map-key-override
params:
- CMAKE_CONFIGURE_FLAGS: "-A x64 -Tv141,version=14.16,host=x64 -DCMAKE_SYSTEM_VERSION=10.0.16299.0"
+ CMAKE_CONFIGURE_FLAGS: "-A x64 -Tv142,version=14.29,host=x64 -DCMAKE_SYSTEM_VERSION=10.0.19041.0"
Review comment:
We could use .. for CMAKE_CONFIGURE_FLAGS, which will utilize the latest toolchain installed on the system. However, it seems prudent to stick with the explicit tools versions to insulate us from unexpected issues.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode-native] pivotal-jbarrett commented on a change in pull request #884: GEODE-9741: Use v142 Toolchain in Visual Studio 2019 CI Pipeline
Posted by GitBox <gi...@apache.org>.
pivotal-jbarrett commented on a change in pull request #884:
URL: https://github.com/apache/geode-native/pull/884#discussion_r732197681
##########
File path: packer/windows/install-vs-2019-community.ps1
##########
@@ -21,22 +21,93 @@ write-host "Installing Visual Studio 2019 Community..."
$args = @('--add Microsoft.VisualStudio.Component.CoreEditor',
'--add Microsoft.VisualStudio.Workload.CoreEditor',
+ '--add Microsoft.NetCore.Component.Runtime.5.0',
+ '--add Microsoft.NetCore.Component.Runtime.3.1',
+ '--add Microsoft.NetCore.Component.SDK',
+ '--add Microsoft.VisualStudio.Component.NuGet',
'--add Microsoft.Net.Component.4.6.1.TargetingPack',
'--add Microsoft.VisualStudio.Component.Roslyn.Compiler',
+ '--add Microsoft.VisualStudio.Component.Roslyn.LanguageServices',
+ '--add Microsoft.VisualStudio.Component.FSharp',
+ '--add Microsoft.ComponentGroup.ClickOnce.Publish',
+ '--add Microsoft.NetCore.Component.DevelopmentTools',
+ '--add Microsoft.VisualStudio.Component.FSharp.WebTemplates',
+ '--add Microsoft.VisualStudio.ComponentGroup.WebToolsExtensions',
+ '--add Microsoft.VisualStudio.Component.DockerTools',
+ '--add Microsoft.NetCore.Component.Web',
'--add Microsoft.Net.Component.4.8.SDK',
+ '--add Microsoft.Net.Component.4.7.2.TargetingPack',
+ '--add Microsoft.Net.ComponentGroup.DevelopmentPrerequisites',
+ '--add Microsoft.VisualStudio.Component.TypeScript.4.3',
+ '--add Microsoft.VisualStudio.Component.JavaScript.TypeScript',
+ '--add Microsoft.VisualStudio.Component.JavaScript.Diagnostics',
'--add Microsoft.Component.MSBuild',
'--add Microsoft.VisualStudio.Component.TextTemplating',
+ '--add Component.Microsoft.VisualStudio.RazorExtension',
+ '--add Microsoft.VisualStudio.Component.IISExpress',
+ '--add Microsoft.VisualStudio.Component.SQL.ADAL',
+ '--add Microsoft.VisualStudio.Component.SQL.LocalDB.Runtime',
+ '--add Microsoft.VisualStudio.Component.Common.Azure.Tools',
+ '--add Microsoft.VisualStudio.Component.SQL.CLR',
+ '--add Microsoft.VisualStudio.Component.MSODBC.SQL',
+ '--add Microsoft.VisualStudio.Component.MSSQL.CMDLnUtils',
+ '--add Microsoft.VisualStudio.Component.ManagedDesktop.Core',
'--add Microsoft.Net.Component.4.5.2.TargetingPack',
+ '--add Microsoft.Net.Component.4.5.TargetingPack',
+ '--add Microsoft.VisualStudio.Component.SQL.SSDT',
+ '--add Microsoft.VisualStudio.Component.SQL.DataSources',
+ '--add Component.Microsoft.Web.LibraryManager',
+ '--add Component.Microsoft.WebTools.BrowserLink.WebLivePreview',
+ '--add Microsoft.VisualStudio.ComponentGroup.Web',
+ '--add Microsoft.VisualStudio.Component.Web',
+ '--add Microsoft.VisualStudio.ComponentGroup.Web.Client',
+ '--add Microsoft.Net.Component.4.TargetingPack',
+ '--add Microsoft.Net.Component.4.5.1.TargetingPack',
+ '--add Microsoft.Net.Component.4.6.TargetingPack',
+ '--add Microsoft.Net.ComponentGroup.TargetingPacks.Common',
+ '--add Component.Microsoft.VisualStudio.Web.AzureFunctions',
+ '--add Microsoft.VisualStudio.ComponentGroup.AzureFunctions',
+ '--add Microsoft.VisualStudio.Component.Azure.Compute.Emulator',
+ '--add Microsoft.VisualStudio.Component.Azure.Storage.Emulator',
+ '--add Microsoft.VisualStudio.Component.Azure.ClientLibs',
+ '--add Microsoft.VisualStudio.Component.Azure.AuthoringTools',
+ '--add Microsoft.VisualStudio.Component.CloudExplorer',
+ '--add Microsoft.VisualStudio.ComponentGroup.Web.CloudTools',
+ '--add Microsoft.VisualStudio.Component.DiagnosticTools',
+ '--add Microsoft.VisualStudio.Component.EntityFramework',
+ '--add Microsoft.VisualStudio.Component.AspNet45',
+ '--add Microsoft.VisualStudio.Component.AppInsights.Tools',
+ '--add Microsoft.VisualStudio.Component.WebDeploy',
+ '--add Microsoft.VisualStudio.Component.Debugger.JustInTime',
+ '--add Component.Microsoft.VisualStudio.LiveShare',
+ '--add Microsoft.VisualStudio.Component.WslDebugging',
'--add Microsoft.VisualStudio.Component.IntelliCode',
+ '--add Microsoft.VisualStudio.Workload.NetWeb',
+ '--add Microsoft.Component.PythonTools',
+ '--add Component.CPython3.x64',
'--add Microsoft.VisualStudio.Component.VC.CoreIde',
+ '--add Microsoft.VisualStudio.Component.VC.Tools.x86.x64',
+ '--add Microsoft.VisualStudio.Component.Graphics.Tools',
+ '--add Microsoft.VisualStudio.Component.VC.DiagnosticTools',
+ '--add Microsoft.VisualStudio.Component.Windows10SDK.19041',
Review comment:
Actually, the SDK probably shouldn't change unless the intent is to change the lower limit on Windows version supported by the library too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode-native] mmartell commented on pull request #884: GEODE-9741: Use v142 Toolchain in Visual Studio 2019 CI Pipeline
Posted by GitBox <gi...@apache.org>.
mmartell commented on pull request #884:
URL: https://github.com/apache/geode-native/pull/884#issuecomment-948990628
Actually, looks like there is still a problem related to my last commit. Investigating.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode-native] mmartell commented on a change in pull request #884: GEODE-9741: Use v142 Toolchain in Visual Studio 2019 CI Pipeline
Posted by GitBox <gi...@apache.org>.
mmartell commented on a change in pull request #884:
URL: https://github.com/apache/geode-native/pull/884#discussion_r733943601
##########
File path: packer/windows/install-vs-2019-community.ps1
##########
@@ -21,22 +21,93 @@ write-host "Installing Visual Studio 2019 Community..."
$args = @('--add Microsoft.VisualStudio.Component.CoreEditor',
'--add Microsoft.VisualStudio.Workload.CoreEditor',
+ '--add Microsoft.NetCore.Component.Runtime.5.0',
+ '--add Microsoft.NetCore.Component.Runtime.3.1',
+ '--add Microsoft.NetCore.Component.SDK',
+ '--add Microsoft.VisualStudio.Component.NuGet',
'--add Microsoft.Net.Component.4.6.1.TargetingPack',
'--add Microsoft.VisualStudio.Component.Roslyn.Compiler',
+ '--add Microsoft.VisualStudio.Component.Roslyn.LanguageServices',
+ '--add Microsoft.VisualStudio.Component.FSharp',
+ '--add Microsoft.ComponentGroup.ClickOnce.Publish',
+ '--add Microsoft.NetCore.Component.DevelopmentTools',
+ '--add Microsoft.VisualStudio.Component.FSharp.WebTemplates',
+ '--add Microsoft.VisualStudio.ComponentGroup.WebToolsExtensions',
+ '--add Microsoft.VisualStudio.Component.DockerTools',
+ '--add Microsoft.NetCore.Component.Web',
'--add Microsoft.Net.Component.4.8.SDK',
+ '--add Microsoft.Net.Component.4.7.2.TargetingPack',
+ '--add Microsoft.Net.ComponentGroup.DevelopmentPrerequisites',
+ '--add Microsoft.VisualStudio.Component.TypeScript.4.3',
+ '--add Microsoft.VisualStudio.Component.JavaScript.TypeScript',
+ '--add Microsoft.VisualStudio.Component.JavaScript.Diagnostics',
'--add Microsoft.Component.MSBuild',
'--add Microsoft.VisualStudio.Component.TextTemplating',
+ '--add Component.Microsoft.VisualStudio.RazorExtension',
+ '--add Microsoft.VisualStudio.Component.IISExpress',
+ '--add Microsoft.VisualStudio.Component.SQL.ADAL',
+ '--add Microsoft.VisualStudio.Component.SQL.LocalDB.Runtime',
+ '--add Microsoft.VisualStudio.Component.Common.Azure.Tools',
+ '--add Microsoft.VisualStudio.Component.SQL.CLR',
+ '--add Microsoft.VisualStudio.Component.MSODBC.SQL',
+ '--add Microsoft.VisualStudio.Component.MSSQL.CMDLnUtils',
+ '--add Microsoft.VisualStudio.Component.ManagedDesktop.Core',
'--add Microsoft.Net.Component.4.5.2.TargetingPack',
+ '--add Microsoft.Net.Component.4.5.TargetingPack',
+ '--add Microsoft.VisualStudio.Component.SQL.SSDT',
+ '--add Microsoft.VisualStudio.Component.SQL.DataSources',
+ '--add Component.Microsoft.Web.LibraryManager',
+ '--add Component.Microsoft.WebTools.BrowserLink.WebLivePreview',
+ '--add Microsoft.VisualStudio.ComponentGroup.Web',
+ '--add Microsoft.VisualStudio.Component.Web',
+ '--add Microsoft.VisualStudio.ComponentGroup.Web.Client',
+ '--add Microsoft.Net.Component.4.TargetingPack',
+ '--add Microsoft.Net.Component.4.5.1.TargetingPack',
+ '--add Microsoft.Net.Component.4.6.TargetingPack',
+ '--add Microsoft.Net.ComponentGroup.TargetingPacks.Common',
+ '--add Component.Microsoft.VisualStudio.Web.AzureFunctions',
+ '--add Microsoft.VisualStudio.ComponentGroup.AzureFunctions',
+ '--add Microsoft.VisualStudio.Component.Azure.Compute.Emulator',
+ '--add Microsoft.VisualStudio.Component.Azure.Storage.Emulator',
+ '--add Microsoft.VisualStudio.Component.Azure.ClientLibs',
+ '--add Microsoft.VisualStudio.Component.Azure.AuthoringTools',
+ '--add Microsoft.VisualStudio.Component.CloudExplorer',
+ '--add Microsoft.VisualStudio.ComponentGroup.Web.CloudTools',
+ '--add Microsoft.VisualStudio.Component.DiagnosticTools',
+ '--add Microsoft.VisualStudio.Component.EntityFramework',
+ '--add Microsoft.VisualStudio.Component.AspNet45',
+ '--add Microsoft.VisualStudio.Component.AppInsights.Tools',
+ '--add Microsoft.VisualStudio.Component.WebDeploy',
+ '--add Microsoft.VisualStudio.Component.Debugger.JustInTime',
+ '--add Component.Microsoft.VisualStudio.LiveShare',
+ '--add Microsoft.VisualStudio.Component.WslDebugging',
'--add Microsoft.VisualStudio.Component.IntelliCode',
+ '--add Microsoft.VisualStudio.Workload.NetWeb',
+ '--add Microsoft.Component.PythonTools',
+ '--add Component.CPython3.x64',
'--add Microsoft.VisualStudio.Component.VC.CoreIde',
+ '--add Microsoft.VisualStudio.Component.VC.Tools.x86.x64',
+ '--add Microsoft.VisualStudio.Component.Graphics.Tools',
+ '--add Microsoft.VisualStudio.Component.VC.DiagnosticTools',
+ '--add Microsoft.VisualStudio.Component.Windows10SDK.19041',
+ '--add Microsoft.VisualStudio.Workload.Python',
+ '--add Microsoft.VisualStudio.Component.ManagedDesktop.Prerequisites',
+ '--add Microsoft.ComponentGroup.Blend',
+ '--add Microsoft.VisualStudio.Component.DotNetModelBuilder',
+ '--add Microsoft.VisualStudio.Workload.ManagedDesktop',
'--add Microsoft.VisualStudio.Component.VC.Redist.14.Latest',
'--add Microsoft.VisualStudio.ComponentGroup.NativeDesktop.Core',
+ '--add Microsoft.VisualStudio.ComponentGroup.WebToolsExtensions.CMake',
+ '--add Microsoft.VisualStudio.Component.VC.CMake.Project',
'--add Microsoft.VisualStudio.Component.VC.ATL',
- '--add Microsoft.VisualStudio.Component.Windows10SDK.16299',
- '--add Microsoft.VisualStudio.Component.VC.v141.x86.x64',
Review comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode-native] mmartell commented on a change in pull request #884: GEODE-9741: Use v142 Toolchain in Visual Studio 2019 CI Pipeline
Posted by GitBox <gi...@apache.org>.
mmartell commented on a change in pull request #884:
URL: https://github.com/apache/geode-native/pull/884#discussion_r732053680
##########
File path: ci/base/base.yml
##########
@@ -72,7 +72,7 @@ builds:
with_dot_net: #@ True
#@yaml/map-key-override
params:
- CMAKE_CONFIGURE_FLAGS: "-A x64 -Tv141,version=14.16,host=x64 -DCMAKE_SYSTEM_VERSION=10.0.16299.0"
+ CMAKE_CONFIGURE_FLAGS: "-A x64 -Tv142,version=14.29,host=x64 -DCMAKE_SYSTEM_VERSION=10.0.19041.0"
Review comment:
No. This is only for the Windows-2019 builds. The vs-2017 build (see line 64 above) are not affected.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode-native] pivotal-jbarrett commented on a change in pull request #884: GEODE-9741: Use v142 Toolchain in Visual Studio 2019 CI Pipeline
Posted by GitBox <gi...@apache.org>.
pivotal-jbarrett commented on a change in pull request #884:
URL: https://github.com/apache/geode-native/pull/884#discussion_r732196044
##########
File path: packer/windows/install-vs-2019-community.ps1
##########
@@ -21,22 +21,93 @@ write-host "Installing Visual Studio 2019 Community..."
$args = @('--add Microsoft.VisualStudio.Component.CoreEditor',
'--add Microsoft.VisualStudio.Workload.CoreEditor',
+ '--add Microsoft.NetCore.Component.Runtime.5.0',
+ '--add Microsoft.NetCore.Component.Runtime.3.1',
+ '--add Microsoft.NetCore.Component.SDK',
+ '--add Microsoft.VisualStudio.Component.NuGet',
'--add Microsoft.Net.Component.4.6.1.TargetingPack',
'--add Microsoft.VisualStudio.Component.Roslyn.Compiler',
+ '--add Microsoft.VisualStudio.Component.Roslyn.LanguageServices',
+ '--add Microsoft.VisualStudio.Component.FSharp',
+ '--add Microsoft.ComponentGroup.ClickOnce.Publish',
+ '--add Microsoft.NetCore.Component.DevelopmentTools',
+ '--add Microsoft.VisualStudio.Component.FSharp.WebTemplates',
+ '--add Microsoft.VisualStudio.ComponentGroup.WebToolsExtensions',
+ '--add Microsoft.VisualStudio.Component.DockerTools',
+ '--add Microsoft.NetCore.Component.Web',
'--add Microsoft.Net.Component.4.8.SDK',
+ '--add Microsoft.Net.Component.4.7.2.TargetingPack',
+ '--add Microsoft.Net.ComponentGroup.DevelopmentPrerequisites',
+ '--add Microsoft.VisualStudio.Component.TypeScript.4.3',
+ '--add Microsoft.VisualStudio.Component.JavaScript.TypeScript',
+ '--add Microsoft.VisualStudio.Component.JavaScript.Diagnostics',
'--add Microsoft.Component.MSBuild',
'--add Microsoft.VisualStudio.Component.TextTemplating',
+ '--add Component.Microsoft.VisualStudio.RazorExtension',
+ '--add Microsoft.VisualStudio.Component.IISExpress',
+ '--add Microsoft.VisualStudio.Component.SQL.ADAL',
+ '--add Microsoft.VisualStudio.Component.SQL.LocalDB.Runtime',
+ '--add Microsoft.VisualStudio.Component.Common.Azure.Tools',
+ '--add Microsoft.VisualStudio.Component.SQL.CLR',
+ '--add Microsoft.VisualStudio.Component.MSODBC.SQL',
+ '--add Microsoft.VisualStudio.Component.MSSQL.CMDLnUtils',
+ '--add Microsoft.VisualStudio.Component.ManagedDesktop.Core',
'--add Microsoft.Net.Component.4.5.2.TargetingPack',
+ '--add Microsoft.Net.Component.4.5.TargetingPack',
+ '--add Microsoft.VisualStudio.Component.SQL.SSDT',
+ '--add Microsoft.VisualStudio.Component.SQL.DataSources',
+ '--add Component.Microsoft.Web.LibraryManager',
+ '--add Component.Microsoft.WebTools.BrowserLink.WebLivePreview',
+ '--add Microsoft.VisualStudio.ComponentGroup.Web',
+ '--add Microsoft.VisualStudio.Component.Web',
+ '--add Microsoft.VisualStudio.ComponentGroup.Web.Client',
+ '--add Microsoft.Net.Component.4.TargetingPack',
+ '--add Microsoft.Net.Component.4.5.1.TargetingPack',
+ '--add Microsoft.Net.Component.4.6.TargetingPack',
+ '--add Microsoft.Net.ComponentGroup.TargetingPacks.Common',
+ '--add Component.Microsoft.VisualStudio.Web.AzureFunctions',
+ '--add Microsoft.VisualStudio.ComponentGroup.AzureFunctions',
+ '--add Microsoft.VisualStudio.Component.Azure.Compute.Emulator',
+ '--add Microsoft.VisualStudio.Component.Azure.Storage.Emulator',
+ '--add Microsoft.VisualStudio.Component.Azure.ClientLibs',
+ '--add Microsoft.VisualStudio.Component.Azure.AuthoringTools',
+ '--add Microsoft.VisualStudio.Component.CloudExplorer',
+ '--add Microsoft.VisualStudio.ComponentGroup.Web.CloudTools',
+ '--add Microsoft.VisualStudio.Component.DiagnosticTools',
+ '--add Microsoft.VisualStudio.Component.EntityFramework',
+ '--add Microsoft.VisualStudio.Component.AspNet45',
+ '--add Microsoft.VisualStudio.Component.AppInsights.Tools',
+ '--add Microsoft.VisualStudio.Component.WebDeploy',
+ '--add Microsoft.VisualStudio.Component.Debugger.JustInTime',
+ '--add Component.Microsoft.VisualStudio.LiveShare',
+ '--add Microsoft.VisualStudio.Component.WslDebugging',
'--add Microsoft.VisualStudio.Component.IntelliCode',
+ '--add Microsoft.VisualStudio.Workload.NetWeb',
+ '--add Microsoft.Component.PythonTools',
+ '--add Component.CPython3.x64',
'--add Microsoft.VisualStudio.Component.VC.CoreIde',
+ '--add Microsoft.VisualStudio.Component.VC.Tools.x86.x64',
+ '--add Microsoft.VisualStudio.Component.Graphics.Tools',
+ '--add Microsoft.VisualStudio.Component.VC.DiagnosticTools',
+ '--add Microsoft.VisualStudio.Component.Windows10SDK.19041',
+ '--add Microsoft.VisualStudio.Workload.Python',
+ '--add Microsoft.VisualStudio.Component.ManagedDesktop.Prerequisites',
+ '--add Microsoft.ComponentGroup.Blend',
+ '--add Microsoft.VisualStudio.Component.DotNetModelBuilder',
+ '--add Microsoft.VisualStudio.Workload.ManagedDesktop',
'--add Microsoft.VisualStudio.Component.VC.Redist.14.Latest',
'--add Microsoft.VisualStudio.ComponentGroup.NativeDesktop.Core',
+ '--add Microsoft.VisualStudio.ComponentGroup.WebToolsExtensions.CMake',
+ '--add Microsoft.VisualStudio.Component.VC.CMake.Project',
'--add Microsoft.VisualStudio.Component.VC.ATL',
- '--add Microsoft.VisualStudio.Component.Windows10SDK.16299',
- '--add Microsoft.VisualStudio.Component.VC.v141.x86.x64',
Review comment:
Replace `Microsoft.VisualStudio.Component.VC.v141.x86.x64` with `Microsoft.VisualStudio.Component.VC.14.20.x86.x64`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org