You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "domoritz (via GitHub)" <gi...@apache.org> on 2023/06/11 17:21:06 UTC
[GitHub] [arrow] domoritz opened a new pull request, #36032: GH-36031: [JS]: Update dependencies
domoritz opened a new pull request, #36032:
URL: https://github.com/apache/arrow/pull/36032
Fixes #36031
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] domoritz commented on a diff in pull request #36032: GH-36031: [JS]: Update dependencies
Posted by "domoritz (via GitHub)" <gi...@apache.org>.
domoritz commented on code in PR #36032:
URL: https://github.com/apache/arrow/pull/36032#discussion_r1225871392
##########
js/src/util/buffer.ts:
##########
@@ -63,7 +63,7 @@ export function joinUint8Arrays(chunks: Uint8Array[], size?: number | null): [Ui
// streaming, where we may be reading partial byte ranges out of the same underlying ArrayBuffer
const result = collapseContiguousByteRanges(chunks);
const byteLength = result.reduce((x, b) => x + b.byteLength, 0);
- let source: Uint8Array, sliced: Uint8Array, buffer: Uint8Array | void;
+ let source: Uint8Array, sliced: Uint8Array, buffer: Uint8Array | undefined;
Review Comment:
Without this change, TS is not happy.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #36032: GH-36031: [JS]: Update dependencies
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #36032:
URL: https://github.com/apache/arrow/pull/36032#issuecomment-1586254512
:warning: GitHub issue #36031 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] domoritz merged pull request #36032: GH-36031: [JS]: Update dependencies
Posted by "domoritz (via GitHub)" <gi...@apache.org>.
domoritz merged PR #36032:
URL: https://github.com/apache/arrow/pull/36032
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] conbench-apache-arrow[bot] commented on pull request #36032: GH-36031: [JS]: Update dependencies
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #36032:
URL: https://github.com/apache/arrow/pull/36032#issuecomment-1612907199
Conbench analyzed the 6 benchmark runs on commit `a1122c81`.
There were 4 benchmark results indicating a performance regression:
- Commit Run on `arm64-m6g-linux-compute` at [2023-06-27 01:52:50Z](http://conbench.ursa.dev/compare/runs/cbf2e72a11bc49e09b04555a219f12cd...c529a930178845f09fc7a2adc6603c47/)
- [params=<STATIC_VECTOR(std::string)>, source=cpp-micro, suite=arrow-small-vector-benchmark](http://conbench.ursa.dev/compare/benchmarks/0649a1ccab8772438000746c4d8d90bc...0649a41907b77d1980008a19d8661bd4)
- Commit Run on `ursa-thinkcentre-m75q` at [2023-06-28 06:29:02Z](http://conbench.ursa.dev/compare/runs/5c6d0410cf894854a318a6932498e1cb...56c06afdfa244f2991964c8586e3fe77/)
- [params=<BooleanType>/1048576/0, source=cpp-micro, suite=arrow-acero-aggregate-benchmark](http://conbench.ursa.dev/compare/benchmarks/0649bab8d02c72b280008f716f31a082...0649bd351fd275c78000e99152507077)
- and 2 more (see the report linked below)
The [full Conbench report](https://github.com/apache/arrow/runs/14653102286) has more details.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org