You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hc.apache.org by ol...@apache.org on 2017/05/11 18:17:57 UTC
[22/42] httpcomponents-core git commit: HTTPCORE-447: HttpHost#create
does not throw IllegalArgumentException for empty string
HTTPCORE-447: HttpHost#create does not throw IllegalArgumentException for empty string
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpcore/branches/4.4.x@1784126 13f79535-47bb-0310-9956-ffa450edef68
Project: http://git-wip-us.apache.org/repos/asf/httpcomponents-core/repo
Commit: http://git-wip-us.apache.org/repos/asf/httpcomponents-core/commit/c069b86f
Tree: http://git-wip-us.apache.org/repos/asf/httpcomponents-core/tree/c069b86f
Diff: http://git-wip-us.apache.org/repos/asf/httpcomponents-core/diff/c069b86f
Branch: refs/heads/4.4.x
Commit: c069b86f2c2f5e82bf735bdf2106b90d8ab8060a
Parents: 92de9e0
Author: Oleg Kalnichevski <ol...@apache.org>
Authored: Thu Feb 23 13:22:39 2017 +0000
Committer: Oleg Kalnichevski <ol...@apache.org>
Committed: Thu May 11 20:16:43 2017 +0200
----------------------------------------------------------------------
httpcore/src/main/java/org/apache/http/util/Args.java | 3 +++
httpcore/src/test/java/org/apache/http/TestHttpHost.java | 5 +++++
2 files changed, 8 insertions(+)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/httpcomponents-core/blob/c069b86f/httpcore/src/main/java/org/apache/http/util/Args.java
----------------------------------------------------------------------
diff --git a/httpcore/src/main/java/org/apache/http/util/Args.java b/httpcore/src/main/java/org/apache/http/util/Args.java
index 9eb8a25..6f08674 100644
--- a/httpcore/src/main/java/org/apache/http/util/Args.java
+++ b/httpcore/src/main/java/org/apache/http/util/Args.java
@@ -80,6 +80,9 @@ public class Args {
if (argument == null) {
throw new IllegalArgumentException(name + " may not be null");
}
+ if (argument.length() == 0) {
+ throw new IllegalArgumentException(name + " may not be empty");
+ }
if (TextUtils.containsBlanks(argument)) {
throw new IllegalArgumentException(name + " may not contain blanks");
}
http://git-wip-us.apache.org/repos/asf/httpcomponents-core/blob/c069b86f/httpcore/src/test/java/org/apache/http/TestHttpHost.java
----------------------------------------------------------------------
diff --git a/httpcore/src/test/java/org/apache/http/TestHttpHost.java b/httpcore/src/test/java/org/apache/http/TestHttpHost.java
index 71f161b..674d9e3 100644
--- a/httpcore/src/test/java/org/apache/http/TestHttpHost.java
+++ b/httpcore/src/test/java/org/apache/http/TestHttpHost.java
@@ -222,6 +222,11 @@ public class TestHttpHost {
Assert.fail("IllegalArgumentException expected");
} catch (final IllegalArgumentException expected) {
}
+ try {
+ HttpHost.create("");
+ Assert.fail("IllegalArgumentException expected");
+ } catch (final IllegalArgumentException expected) {
+ }
}
}