[GitHub] [spark] cloud-fan commented on a diff in pull request #40137: [SPARK-42049][SQL][FOLLOWUP] Always filter away invalid ordering/partitioning

["cloud-fan (via GitHub)" <gi...@apache.org>]

cloud-fan commented on code in PR #40137:
URL: https://github.com/apache/spark/pull/40137#discussion_r1115678677


##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/AliasAwareOutputExpression.scala:
##########
@@ -114,7 +114,11 @@ trait AliasAwareQueryOutputOrdering[T <: QueryPlan[T]]
         }
       }.takeWhile(_.isDefined).flatten.toSeq
     } else {
-      orderingExpressions
+      // Make sure the returned ordering are valid (only reference output attributes of the current

Review Comment:
   good point!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org