You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by lu...@apache.org on 2003/10/05 23:00:38 UTC
cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/coyote/tomcat5 CoyoteConnector.java
luehe 2003/10/05 14:00:38
Modified: catalina/src/share/org/apache/coyote/tomcat5
CoyoteConnector.java
Log:
Set the tcpNoDelay property on the underlying socket even if this
property has not been set explicitly on CoyoteConnector (in which case
the property of the underlying socket is set to TRUE, the default in
CoyoteConnector).
This restores the behaviour in earlier CoyoteConnector versions and
fixes a huge performance degradation.
Revision Changes Path
1.29 +8 -1 jakarta-tomcat-catalina/catalina/src/share/org/apache/coyote/tomcat5/CoyoteConnector.java
Index: CoyoteConnector.java
===================================================================
RCS file: /home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/coyote/tomcat5/CoyoteConnector.java,v
retrieving revision 1.28
retrieving revision 1.29
diff -u -r1.28 -r1.29
--- CoyoteConnector.java 2 Sep 2003 21:21:59 -0000 1.28
+++ CoyoteConnector.java 5 Oct 2003 21:00:38 -0000 1.29
@@ -364,6 +364,13 @@
private String URIEncoding = null;
+ // ------------------------------------------------------------ Constructor
+
+ public CoyoteConnector() {
+ setProperty("tcpNoDelay", String.valueOf(tcpNoDelay));
+ }
+
+
// ------------------------------------------------------------- Properties
/**
---------------------------------------------------------------------
To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org
Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/coyote/tomcat5
CoyoteConnector.java
Posted by Remy Maucherat <re...@apache.org>.
Bill Barker wrote:
>>luehe 2003/10/05 14:00:38
>>
>> Modified: catalina/src/share/org/apache/coyote/tomcat5
>> CoyoteConnector.java
>> Log:
>> Set the tcpNoDelay property on the underlying socket even if this
>> property has not been set explicitly on CoyoteConnector (in which case
>> the property of the underlying socket is set to TRUE, the default in
>> CoyoteConnector).
>>
>> This restores the behaviour in earlier CoyoteConnector versions and
>> fixes a huge performance degradation.
>
>
> I'm -1 on this. There shouldn't be default properties set from the
> Connector. If you want the default to be 'true', then change either default
> it in the Http11Protocol, or change the current default value in
> PoolTcpEndpoint.
I completely agree with that.
Remy
---------------------------------------------------------------------
To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org
Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/coyote/tomcat5 CoyoteConnector.java
Posted by Bill Barker <wb...@wilshire.com>.
----- Original Message -----
From: <lu...@apache.org>
To: <ja...@apache.org>
Sent: Sunday, October 05, 2003 2:00 PM
Subject: cvs commit:
jakarta-tomcat-catalina/catalina/src/share/org/apache/coyote/tomcat5
CoyoteConnector.java
> luehe 2003/10/05 14:00:38
>
> Modified: catalina/src/share/org/apache/coyote/tomcat5
> CoyoteConnector.java
> Log:
> Set the tcpNoDelay property on the underlying socket even if this
> property has not been set explicitly on CoyoteConnector (in which case
> the property of the underlying socket is set to TRUE, the default in
> CoyoteConnector).
>
> This restores the behaviour in earlier CoyoteConnector versions and
> fixes a huge performance degradation.
I'm -1 on this. There shouldn't be default properties set from the
Connector. If you want the default to be 'true', then change either default
it in the Http11Protocol, or change the current default value in
PoolTcpEndpoint.