You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/09/24 15:38:24 UTC

[GitHub] [spark] tgravescs commented on a change in pull request #34087: [Spark-36821][SQL] Make class ColumnarBatch extendable - addendum

tgravescs commented on a change in pull request #34087:
URL: https://github.com/apache/spark/pull/34087#discussion_r715716831



##########
File path: sql/catalyst/src/main/java/org/apache/spark/sql/vectorized/ColumnarBatch.java
##########
@@ -32,11 +28,11 @@
  */
 @Evolving
 public class ColumnarBatch implements AutoCloseable {

Review comment:
       I assume we want DeveloperAPI tag
   
   it would be nice to add more to description stating why public and not final and intent on others using.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org