You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hive.apache.org by "Miklos Gergely (JIRA)" <ji...@apache.org> on 2019/07/04 20:17:00 UTC

[jira] [Commented] (HIVE-21959) Clean up Concatenate and Msck DDL commands

    [ https://issues.apache.org/jira/browse/HIVE-21959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16878874#comment-16878874 ] 

Miklos Gergely commented on HIVE-21959:
---------------------------------------

[~jcamachorodriguez] could you please review: [https://github.com/apache/hive/pull/703]

> Clean up Concatenate and Msck DDL commands
> ------------------------------------------
>
>                 Key: HIVE-21959
>                 URL: https://issues.apache.org/jira/browse/HIVE-21959
>             Project: Hive
>          Issue Type: Sub-task
>          Components: Hive
>    Affects Versions: 3.1.1
>            Reporter: Miklos Gergely
>            Assignee: Miklos Gergely
>            Priority: Major
>              Labels: pull-request-available, refactor-ddl
>             Fix For: 4.0.0
>
>         Attachments: HIVE-21959.01.patch
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> Concatenate and Msck DDL use basic data structure implementations instead of their interfaces for variable declaration, like ArrayList instead of List, LinkedHashMap instead of Map, etc. This is due to a lot of similar issues in the code, which needs to be cleaned.
> Concatenate also had a non-immutable Desc class, that needs to be transformed into an immutable one. Concatenate operation code should be cut into smaller functions.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)