You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by uce <gi...@git.apache.org> on 2017/02/28 16:42:04 UTC
[GitHub] flink pull request #3430: [FLINK-5402] [FLINK-5389] Increase test timeouts
GitHub user uce opened a pull request:
https://github.com/apache/flink/pull/3430
[FLINK-5402] [FLINK-5389] Increase test timeouts
Some users reported running into timeouts due to too "aggressive" timeouts for certain configurations (as mentioned by Dawid in FLINK-5402).
The changed timeouts don't affect the failure free runtime of the tests.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/uce/flink test_timeouts
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/3430.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3430
----
commit eed1ea009867675197a8cd1bf2b48df5e30d3e49
Author: Ufuk Celebi <uc...@apache.org>
Date: 2017-02-28T16:39:20Z
[FLINK-5402] [tests] Remove JUnit timeouts in AkkaRpcServiceTest
commit e0eabe41a833228e10cb1ec7e6f3afa7c9bc00d9
Author: Ufuk Celebi <uc...@apache.org>
Date: 2017-02-28T16:40:03Z
[FLINK-5389] [tests] Increate ask timeout in JobSubmitTest
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #3430: [FLINK-5402] [FLINK-5389] Increase test timeouts
Posted by uce <gi...@git.apache.org>.
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/3430#discussion_r103498419
--- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/rpc/akka/AkkaRpcServiceTest.java ---
@@ -135,7 +135,7 @@ public void testGetAddress() {
* @throws ExecutionException
* @throws InterruptedException
*/
- @Test(timeout = 1000)
+ @Test
--- End diff --
@tillrohrmann Is is OK to remove these timeouts? We still catch this with the build timeout stack traces if no progress happens. As an alternative, we can increase the timeout to a higher value.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #3430: [FLINK-5402] [FLINK-5389] Increase test timeouts
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/3430
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #3430: [FLINK-5402] [FLINK-5389] Increase test timeouts
Posted by tillrohrmann <gi...@git.apache.org>.
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/3430#discussion_r103646797
--- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/rpc/akka/AkkaRpcServiceTest.java ---
@@ -135,7 +135,7 @@ public void testGetAddress() {
* @throws ExecutionException
* @throws InterruptedException
*/
- @Test(timeout = 1000)
+ @Test
--- End diff --
It should be ok to remove the timeout, but I think that the build timeout stack traces are not so nice to see which test case actually caused the timeout. The reason for this is that there are multiple test cases being executed in parallel.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #3430: [FLINK-5402] [FLINK-5389] Increase test timeouts
Posted by tillrohrmann <gi...@git.apache.org>.
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/3430#discussion_r103649079
--- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/rpc/akka/AkkaRpcServiceTest.java ---
@@ -135,7 +135,7 @@ public void testGetAddress() {
* @throws ExecutionException
* @throws InterruptedException
*/
- @Test(timeout = 1000)
+ @Test
--- End diff --
yes
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #3430: [FLINK-5402] [FLINK-5389] Increase test timeouts
Posted by uce <gi...@git.apache.org>.
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/3430#discussion_r103647638
--- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/rpc/akka/AkkaRpcServiceTest.java ---
@@ -135,7 +135,7 @@ public void testGetAddress() {
* @throws ExecutionException
* @throws InterruptedException
*/
- @Test(timeout = 1000)
+ @Test
--- End diff --
OK, never noticed this problem, but will check it the next time. Maybe we can improve something. ;-) I'll leave the JUnit timeout and increase it to a higher value like 60000. I think that's a good compromise?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---