You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ambari.apache.org by GitBox <gi...@apache.org> on 2022/11/04 13:32:43 UTC
[GitHub] [ambari-metrics] lucasbak opened a new pull request, #52: AMBARI-25402 Please provide jvm metrics for kafka components in Ambari
lucasbak opened a new pull request, #52:
URL: https://github.com/apache/ambari-metrics/pull/52
## What changes were proposed in this pull request?
AMBARI-25402 Please provide jvm metrics for kafka components in Ambari (forward)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@ambari.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@ambari.apache.org
For additional commands, e-mail: commits-help@ambari.apache.org
[GitHub] [ambari-metrics] kevinw66 commented on a diff in pull request #52: AMBARI-25402 Please provide jvm metrics for kafka components in Ambari
Posted by GitBox <gi...@apache.org>.
kevinw66 commented on code in PR #52:
URL: https://github.com/apache/ambari-metrics/pull/52#discussion_r1015820612
##########
ambari-metrics-kafka-sink/src/main/java/org/apache/hadoop/metrics2/sink/kafka/KafkaTimelineMetricsReporter.java:
##########
@@ -81,7 +80,6 @@ public class KafkaTimelineMetricsReporter extends AbstractTimelineMetricsSink
private static final String TIMELINE_DEFAULT_PROTOCOL = "http";
private static final String EXCLUDED_METRICS_PROPERTY = "external.kafka.metrics.exclude.prefix";
private static final String INCLUDED_METRICS_PROPERTY = "external.kafka.metrics.include.prefix";
- private static final String INCLUDED_METRICS_REGEX_PROPERTY = "external.kafka.metrics.include.regex";
Review Comment:
Looks like this was added on AMBARI-24797, why delete here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@ambari.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@ambari.apache.org
For additional commands, e-mail: commits-help@ambari.apache.org
[GitHub] [ambari-metrics] lucasbak commented on a diff in pull request #52: AMBARI-25402 Please provide jvm metrics for kafka components in Ambari
Posted by GitBox <gi...@apache.org>.
lucasbak commented on code in PR #52:
URL: https://github.com/apache/ambari-metrics/pull/52#discussion_r1015905512
##########
ambari-metrics-kafka-sink/src/main/java/org/apache/hadoop/metrics2/sink/kafka/KafkaTimelineMetricsReporter.java:
##########
@@ -81,7 +80,6 @@ public class KafkaTimelineMetricsReporter extends AbstractTimelineMetricsSink
private static final String TIMELINE_DEFAULT_PROTOCOL = "http";
private static final String EXCLUDED_METRICS_PROPERTY = "external.kafka.metrics.exclude.prefix";
private static final String INCLUDED_METRICS_PROPERTY = "external.kafka.metrics.include.prefix";
- private static final String INCLUDED_METRICS_REGEX_PROPERTY = "external.kafka.metrics.include.regex";
Review Comment:
It was not part for branch-2.7 but as AMBARI-24797 target fix version is 2.8, we should keep it.
Let's remove this deletion !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@ambari.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@ambari.apache.org
For additional commands, e-mail: commits-help@ambari.apache.org
[GitHub] [ambari-metrics] kevinw66 merged pull request #52: AMBARI-25402 Please provide jvm metrics for kafka components in Ambari
Posted by GitBox <gi...@apache.org>.
kevinw66 merged PR #52:
URL: https://github.com/apache/ambari-metrics/pull/52
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@ambari.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@ambari.apache.org
For additional commands, e-mail: commits-help@ambari.apache.org