You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/01/27 17:20:43 UTC

[GitHub] [tvm] jwfromm commented on pull request #9811: PackedFunction to return params from the .so module, show warning when no params are set

jwfromm commented on pull request #9811:
URL: https://github.com/apache/tvm/pull/9811#issuecomment-1023461773


   After thinking about this PR a little more, I'm of the opinion that we probably should not add input checking to GraphExecutor::Run. It's important that we keep Run as minimal as possible, and the checking of inputs and more importantly printing of the warning may cause Run to be slower. I like the rest of this PR but think we should drop `input_set_`. What do you think @junrushao1994?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org