Re: [PR] SolrRequest.getParams never null; and clarify mutability [solr]

["dsmiley (via GitHub)" <gi...@apache.org>]

dsmiley commented on code in PR #3140:
URL: https://github.com/apache/solr/pull/3140#discussion_r1938508213


##########
solr/core/src/java/org/apache/solr/handler/api/V2ApiUtils.java:
##########
@@ -91,9 +91,6 @@ public static void squashIntoNamedListWithoutHeader(
   }
 
   public static String getMediaTypeFromWtParam(SolrParams params, String defaultMediaType) {
-    if (params == null) {

Review Comment:
   It turns out SolrQueryRequest.getParams will always be non-null (because `org.apache.solr.servlet.SolrRequestParsers#parseQueryString(java.lang.String)` is what initializes it, always non-null) but this fact is not documented.  I'll increase the scope here a little to cover that since there's little to it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org