You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Qian Zhang <zh...@cn.ibm.com> on 2016/04/29 02:19:09 UTC
Re: Review Request 46799: Added capabilities support to mesos-execute.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46799/#review131021
-----------------------------------------------------------
src/cli/execute.cpp (lines 43 - 46)
<https://reviews.apache.org/r/46799/#comment194956>
I think we should add this before `#include <mesos/type_utils.hpp>` to keep them in alphabet order.
src/cli/execute.cpp (lines 172 - 175)
<https://reviews.apache.org/r/46799/#comment194961>
Can we only add this flag in Linux? Then user will not see this flag at all when running `mesos-execute` in other platorms.
- Qian Zhang
On April 29, 2016, 5:49 a.m., Jojy Varghese wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46799/
> -----------------------------------------------------------
>
> (Updated April 29, 2016, 5:49 a.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This change introduces two flags: `user` and `capabilities`.
>
> user: used to specify the user name for the command.
> capabilities: comma separated list of capabilities the task
> requires.
>
>
> Diffs
> -----
>
> src/cli/execute.cpp 4711e80314e2fc4cde077bebd9a8167324c3254e
>
> Diff: https://reviews.apache.org/r/46799/diff/
>
>
> Testing
> -------
>
> make check.
>
>
> Thanks,
>
> Jojy Varghese
>
>
Re: Review Request 46799: Added capabilities support to mesos-execute.
Posted by Qian Zhang <zh...@cn.ibm.com>.
> On April 29, 2016, 8:19 a.m., Qian Zhang wrote:
> > src/cli/execute.cpp, lines 172-175
> > <https://reviews.apache.org/r/46799/diff/1/?file=1365019#file1365019line172>
> >
> > Can we only add this flag in Linux? Then user will not see this flag at all when running `mesos-execute` in other platorms.
>
> Jojy Varghese wrote:
> I avoided that logic as it would mean spreading `ifdef` all over the file.
Right, but I think that is the common way to handle the platform-specific logic, you can take a look at: https://github.com/apache/mesos/blob/master/src/slave/containerizer/mesos/containerizer.cpp, in this file, we use `#ifdef __linux__` for all the isolators which can be only enabled on Linux.
- Qian
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46799/#review131021
-----------------------------------------------------------
On April 30, 2016, 2:41 a.m., Jojy Varghese wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46799/
> -----------------------------------------------------------
>
> (Updated April 30, 2016, 2:41 a.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This change introduces two flags: `user` and `capabilities`.
>
> user: used to specify the user name for the command.
> capabilities: comma separated list of capabilities the task
> requires.
>
>
> Diffs
> -----
>
> src/cli/execute.cpp 4711e80314e2fc4cde077bebd9a8167324c3254e
>
> Diff: https://reviews.apache.org/r/46799/diff/
>
>
> Testing
> -------
>
> make check.
>
>
> Thanks,
>
> Jojy Varghese
>
>
Re: Review Request 46799: Added capabilities support to mesos-execute.
Posted by Jojy Varghese <jo...@mesosphere.io>.
> On April 29, 2016, 12:19 a.m., Qian Zhang wrote:
> > src/cli/execute.cpp, lines 172-175
> > <https://reviews.apache.org/r/46799/diff/1/?file=1365019#file1365019line172>
> >
> > Can we only add this flag in Linux? Then user will not see this flag at all when running `mesos-execute` in other platorms.
I avoided that logic as it would mean spreading `ifdef` all over the file.
- Jojy
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46799/#review131021
-----------------------------------------------------------
On April 28, 2016, 9:49 p.m., Jojy Varghese wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46799/
> -----------------------------------------------------------
>
> (Updated April 28, 2016, 9:49 p.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This change introduces two flags: `user` and `capabilities`.
>
> user: used to specify the user name for the command.
> capabilities: comma separated list of capabilities the task
> requires.
>
>
> Diffs
> -----
>
> src/cli/execute.cpp 4711e80314e2fc4cde077bebd9a8167324c3254e
>
> Diff: https://reviews.apache.org/r/46799/diff/
>
>
> Testing
> -------
>
> make check.
>
>
> Thanks,
>
> Jojy Varghese
>
>