You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2020/09/08 04:09:42 UTC
[GitHub] [dubbo-go-hessian2] skyao opened a new pull request #234: fix fields name mismatch in Duration class
skyao opened a new pull request #234:
URL: https://github.com/apache/dubbo-go-hessian2/pull/234
**What this PR does**:
1. fix fields name mismatch in Duration class: it should be "seconds/nanos", not "second/nano"
2. improve the test data for better verification: don't use "0" for int field, because event it dismatch the actual field, it still will be "0" because of the default value is "0" for int.
3. improve other test data
**Which issue(s) this PR fixes**:
<!--
*Automatically closes linked issue when PR is merged.
Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`.
_If PR is about `failing-tests or flakes`, please post the related issues/tests in a comment and do not use `Fixes`_*
-->
Fixes #
**Special notes for your reviewer**:
**Does this PR introduce a user-facing change?**:
<!--
If no, just write "NONE" in the release-note block below.
If yes, a release note is required:
Enter your extended release note in the block below. If the PR requires additional action from users switching to the new release, include the string "action required".
-->
```release-note
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-hessian2] skyao commented on a change in pull request #234: fix fields name mismatch in Duration class
Posted by GitBox <gi...@apache.org>.
skyao commented on a change in pull request #234:
URL: https://github.com/apache/dubbo-go-hessian2/pull/234#discussion_r484667183
##########
File path: java8_time/duration.go
##########
@@ -18,8 +18,8 @@
package java8_time
type Duration struct {
- Second int64 `hessian:"second"`
- Nano int32 `hessian:"nano"`
+ Seconds int64 `hessian:"seconds"`
Review comment:
This is NOT rename, but change the wrong name to the correct one which java used.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-hessian2] AlexStocks commented on a change in pull request #234: fix fields name mismatch in Duration class
Posted by GitBox <gi...@apache.org>.
AlexStocks commented on a change in pull request #234:
URL: https://github.com/apache/dubbo-go-hessian2/pull/234#discussion_r484647319
##########
File path: java8_time/duration.go
##########
@@ -18,8 +18,8 @@
package java8_time
type Duration struct {
- Second int64 `hessian:"second"`
- Nano int32 `hessian:"nano"`
+ Seconds int64 `hessian:"seconds"`
Review comment:
I can not agree with u. Pls do not change the var name.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-hessian2] skyao commented on a change in pull request #234: fix fields name mismatch in Duration class
Posted by GitBox <gi...@apache.org>.
skyao commented on a change in pull request #234:
URL: https://github.com/apache/dubbo-go-hessian2/pull/234#discussion_r484667183
##########
File path: java8_time/duration.go
##########
@@ -18,8 +18,8 @@
package java8_time
type Duration struct {
- Second int64 `hessian:"second"`
- Nano int32 `hessian:"nano"`
+ Seconds int64 `hessian:"seconds"`
Review comment:
This is NOT rename, but correct the wrong name to the correct one which java used.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-hessian2] AlexStocks merged pull request #234: fix fields name mismatch in Duration class
Posted by GitBox <gi...@apache.org>.
AlexStocks merged pull request #234:
URL: https://github.com/apache/dubbo-go-hessian2/pull/234
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-hessian2] AlexStocks commented on a change in pull request #234: fix fields name mismatch in Duration class
Posted by GitBox <gi...@apache.org>.
AlexStocks commented on a change in pull request #234:
URL: https://github.com/apache/dubbo-go-hessian2/pull/234#discussion_r484827055
##########
File path: java8_time/duration.go
##########
@@ -18,8 +18,8 @@
package java8_time
type Duration struct {
- Second int64 `hessian:"second"`
- Nano int32 `hessian:"nano"`
+ Seconds int64 `hessian:"seconds"`
Review comment:
got it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org