You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/07/25 21:23:40 UTC

[GitHub] [arrow-rs] jhorstmann commented on issue #614: Get MIRI running against parquet crate

jhorstmann commented on issue #614:
URL: https://github.com/apache/arrow-rs/issues/614#issuecomment-886259653


   Not really familiar with that code, but there is a FIXME comment about the alignment after pointer casts here: https://github.com/apache/arrow-rs/blob/1d6c37452f74a6443d269d0bdfc2c3738130fd5e/parquet/src/util/bit_util.rs#L556
   
   If the alignment can't be guaranteed to be valid for u32, one possible solution could be to replace all `*in_buf` in bit_packing.rs with `std::ptr::read_unaligned(in_buf)`. On x86 that would not have any performance impact.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org