[GitHub] [iceberg] rdblue commented on a change in pull request #1570: Run hive storage handler tests for both Parquet and ORC

[GitBox <gi...@apache.org>]

rdblue commented on a change in pull request #1570:
URL: https://github.com/apache/iceberg/pull/1570#discussion_r502830214



##########
File path: mr/src/test/java/org/apache/iceberg/mr/hive/HiveIcebergStorageHandlerBaseTest.java
##########
@@ -136,18 +136,50 @@ public void after() throws Exception {
     }
   }
 
+  // PARQUET
+
+  @Test
+  public void testScanEmptyTableParquet() throws IOException {

Review comment:
       Rather than creating more test cases, we usually parameterize the test suite. [`TestIdentityPartitionData`](https://github.com/apache/iceberg/blob/425b10cea34eef11cca9cf0d237e02274f6dc958/spark/src/test/java/org/apache/iceberg/spark/source/TestIdentityPartitionData.java) is an example. Could you use that approach instead? Or is there a reason why you chose to do it this way?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org