You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/01/28 16:38:59 UTC
[GitHub] [tvm] FZYUAN-1 opened a new pull request #10098: [Op][Topi] 5 ops can accept unsigned integers as indices
FZYUAN-1 opened a new pull request #10098:
URL: https://github.com/apache/tvm/pull/10098
Hello community,
This PR links to #10064. 5 ops (scatter, scatter_add, scatter_nd, unravel_index, adv_index) accept unsigned integers as indices. Somehow unravel_index with uint indices may raise
```
Check failed: y != 0 (0 vs. 0)
```
in function
https://github.com/apache/tvm/blob/e6af87491eb250a3266b1f09b36055c6ee79146b/src/arith/const_int_bound.cc#L486.
I tried to figure out why shape[v] can be 0 in https://github.com/apache/tvm/blob/7b9fd1e2ab5e0af927f202faef5d682706608fc7/include/tvm/topi/transform.h#L383,
but I failed to understand.
Thank reviewers for your help and your time speeding in CR.
cc @AndrewZhaoLuo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] AndrewZhaoLuo merged pull request #10098: [Op][Topi] 5 ops can accept unsigned integers as indices
Posted by GitBox <gi...@apache.org>.
AndrewZhaoLuo merged pull request #10098:
URL: https://github.com/apache/tvm/pull/10098
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] FZYUAN-1 edited a comment on pull request #10098: [Op][Topi] 5 ops can accept unsigned integers as indices
Posted by GitBox <gi...@apache.org>.
FZYUAN-1 edited a comment on pull request #10098:
URL: https://github.com/apache/tvm/pull/10098#issuecomment-1024879007
> LGTM mostly, just lmk the plan to deal with unravel_index
Thanks for your help! I prefer to drop unravel_index and open a PR later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] AndrewZhaoLuo edited a comment on pull request #10098: [Op][Topi] 5 ops can accept unsigned integers as indices
Posted by GitBox <gi...@apache.org>.
AndrewZhaoLuo edited a comment on pull request #10098:
URL: https://github.com/apache/tvm/pull/10098#issuecomment-1024670599
Debugging I've worked the issue to likely `src/tir/transforms/narrow_datatype.cc`, my guess analysis here does not take into account uint types
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] AndrewZhaoLuo commented on pull request #10098: [Op][Topi] 5 ops can accept unsigned integers as indices
Posted by GitBox <gi...@apache.org>.
AndrewZhaoLuo commented on pull request #10098:
URL: https://github.com/apache/tvm/pull/10098#issuecomment-1024670599
Debugging I've worked the issue to likely `src/tir/transforms/narrow_datatype.cc`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] FZYUAN-1 edited a comment on pull request #10098: [Op][Topi] 5 ops can accept unsigned integers as indices
Posted by GitBox <gi...@apache.org>.
FZYUAN-1 edited a comment on pull request #10098:
URL: https://github.com/apache/tvm/pull/10098#issuecomment-1024879007
> LGTM mostly, just lmk the plan to deal with unravel_index
Thanks for your help! I prefer to drop unravel_index and open a PR later. As its test was not included, this PR is ready for merge now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] FZYUAN-1 commented on pull request #10098: [Op][Topi] 5 ops can accept unsigned integers as indices
Posted by GitBox <gi...@apache.org>.
FZYUAN-1 commented on pull request #10098:
URL: https://github.com/apache/tvm/pull/10098#issuecomment-1024879007
> LGTM mostly, just lmk the plan to deal with unravel_index
Thanks for your help! I prefer to drop unravel_index and open a PR later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] AndrewZhaoLuo commented on pull request #10098: [Op][Topi] 5 ops can accept unsigned integers as indices
Posted by GitBox <gi...@apache.org>.
AndrewZhaoLuo commented on pull request #10098:
URL: https://github.com/apache/tvm/pull/10098#issuecomment-1024725194
https://github.com/apache/tvm/pull/10102 <-- fix here. There is another error now with unravel index now though. You can try digging more, or you can drop unravel_index for later PR (which I recommend)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org