You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by st...@apache.org on 2020/02/07 17:41:47 UTC

[hbase] branch master updated: HBASE-23779 Up the default fork count; make count relative to CPU count (#1108) ADDENDUM: Refactor that comes of discussion up on https://github.com/apache/yetus/pull/86 because what I committed originally, and amended in a subsequent ADDENDUM is not taking effect.

This is an automated email from the ASF dual-hosted git repository.

stack pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/hbase.git


The following commit(s) were added to refs/heads/master by this push:
     new ef380e0   HBASE-23779 Up the default fork count; make count relative to CPU count (#1108)  ADDENDUM: Refactor that comes of discussion up on https://github.com/apache/yetus/pull/86  because what I committed originally, and amended in a subsequent  ADDENDUM is not taking effect.
ef380e0 is described below

commit ef380e0a2e3ba138391968126fd0e9d5c910df88
Author: stack <st...@apache.org>
AuthorDate: Fri Feb 7 09:40:51 2020 -0800

     HBASE-23779 Up the default fork count; make count relative to CPU count (#1108)
     ADDENDUM: Refactor that comes of discussion up on https://github.com/apache/yetus/pull/86
     because what I committed originally, and amended in a subsequent
     ADDENDUM is not taking effect.
---
 dev-support/hbase-personality.sh | 14 +++++---------
 1 file changed, 5 insertions(+), 9 deletions(-)

diff --git a/dev-support/hbase-personality.sh b/dev-support/hbase-personality.sh
index 169f19a..7f961c0 100755
--- a/dev-support/hbase-personality.sh
+++ b/dev-support/hbase-personality.sh
@@ -82,14 +82,6 @@ function personality_globals
   # Override the maven options
   MAVEN_OPTS="${MAVEN_OPTS:-"-Xms4G -Xmx4G"}"
 
-  # Pass maven a -T argument. Should make it run faster. Pass conservative value.
-  # Default is one thread. 0.5C on an apache box of 24 cores and 2 executors should
-  # make for 6 threads? Lets see. Setting this here for yetus to pick up. See
-  # https://yetus.apache.org/documentation/0.11.1/precommit-advanced/#global-definitions
-  # See below for more on -T:
-  # https://cwiki.apache.org/confluence/display/MAVEN/Parallel+builds+in+Maven+3
-  MAVEN_ARGS=("-T0.5C" "${MAVEN_ARGS[@]}")
-
   # Yetus 0.7.0 enforces limits. Default proclimit is 1000.
   # Up it. See HBASE-19902 for how we arrived at this number.
   #shellcheck disable=SC2034
@@ -148,7 +140,11 @@ function personality_modules
 
   clear_personality_queue
 
-  extra="-DHBasePatchProcess"
+  # Pass maven a -T argument. Should make it run faster. Pass conservative value.
+  # Default is one thread. 0.5C on an apache box of 24 cores and 2 executors should
+  # make for 6 threads? Lets see. See below for more on -T:
+  # https://cwiki.apache.org/confluence/display/MAVEN/Parallel+builds+in+Maven+3
+  extra="-T0.5C -DHBasePatchProcess"
   if [[ "${PATCH_BRANCH}" = branch-1* ]]; then
     extra="${extra} -Dhttps.protocols=TLSv1.2"
   fi