You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by "chia7712 (via GitHub)" <gi...@apache.org> on 2025/05/01 17:11:16 UTC

Re: [PR] MINOR: Clean up CloseOptions [kafka]

chia7712 commented on code in PR #19571:
URL: https://github.com/apache/kafka/pull/19571#discussion_r2070537206


##########
clients/src/main/java/org/apache/kafka/clients/consumer/CloseOptions.java:
##########
@@ -84,10 +77,7 @@ public static CloseOptions timeout(final Duration timeout) {
      * @return a new {@code CloseOptions} instance with the specified group membership operation.
      */
     public static CloseOptions groupMembershipOperation(final GroupMembershipOperation operation) {

Review Comment:
   Could you please add unit test for it?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org