You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/02/19 12:47:50 UTC
[GitHub] [spark] peter-toth opened a new pull request #31592: [SPARK-34421][SQL][3.0] Resolve temporary functions and views in views with CTEs
peter-toth opened a new pull request #31592:
URL: https://github.com/apache/spark/pull/31592
### What changes were proposed in this pull request?
This PR:
- Fixes a bug that doesn't report analysis error when it should:
```
CREATE TEMPORARY VIEW temp_view AS SELECT 0;
CREATE VIEW view_on_temp_view AS WITH cte AS (SELECT * FROM temp_view) SELECT * FROM cte
```
by properly checking temporary objects in view definitions with CTEs.
### Why are the changes needed?
To fix a bug.
### Does this PR introduce _any_ user-facing change?
Yes, analysis error is thrown as expected.
### How was this patch tested?
Added new UT + existing ones.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31592: [SPARK-34421][SQL][3.0] Resolve temporary functions and views in views with CTEs
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31592:
URL: https://github.com/apache/spark/pull/31592#issuecomment-782170954
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39852/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31592: [SPARK-34421][SQL][3.0] Resolve temporary functions and views in views with CTEs
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31592:
URL: https://github.com/apache/spark/pull/31592#issuecomment-782242082
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135268/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31592: [SPARK-34421][SQL][3.0] Resolve temporary functions and views in views with CTEs
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31592:
URL: https://github.com/apache/spark/pull/31592#issuecomment-782168226
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39852/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31592: [SPARK-34421][SQL][3.0] Resolve temporary functions and views in views with CTEs
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31592:
URL: https://github.com/apache/spark/pull/31592#issuecomment-782242082
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135268/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31592: [SPARK-34421][SQL][3.0] Resolve temporary functions and views in views with CTEs
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31592:
URL: https://github.com/apache/spark/pull/31592#issuecomment-782085165
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39848/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #31592: [SPARK-34421][SQL][3.0] Resolve temporary functions and views in views with CTEs
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #31592:
URL: https://github.com/apache/spark/pull/31592#issuecomment-783074887
thanks, merging to 3.0!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31592: [SPARK-34421][SQL][3.0] Resolve temporary functions and views in views with CTEs
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31592:
URL: https://github.com/apache/spark/pull/31592#issuecomment-782070724
**[Test build #135268 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135268/testReport)** for PR 31592 at commit [`9630b72`](https://github.com/apache/spark/commit/9630b72b6bb53a0a7e5fad3883ee415a7a2a9cdc).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31592: [SPARK-34421][SQL][3.0] Resolve temporary functions and views in views with CTEs
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31592:
URL: https://github.com/apache/spark/pull/31592#issuecomment-782217791
**[Test build #135268 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135268/testReport)** for PR 31592 at commit [`9630b72`](https://github.com/apache/spark/commit/9630b72b6bb53a0a7e5fad3883ee415a7a2a9cdc).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #31592: [SPARK-34421][SQL][3.0] Resolve temporary functions and views in views with CTEs
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #31592:
URL: https://github.com/apache/spark/pull/31592#discussion_r579247092
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala
##########
@@ -3650,6 +3650,84 @@ class SQLQuerySuite extends QueryTest with SharedSparkSession with AdaptiveSpark
}
}
}
+
+ test("SPARK-34421: Resolve temporary objects in temporary views with CTEs") {
Review comment:
The new SQL temp view feature is not in 3.0, and I think we can remove this test, because it should pass in 3.0 without this fix.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31592: [SPARK-34421][SQL][3.0] Resolve temporary functions and views in views with CTEs
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31592:
URL: https://github.com/apache/spark/pull/31592#issuecomment-782309991
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135271/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #31592: [SPARK-34421][SQL][3.0] Resolve temporary functions and views in views with CTEs
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31592:
URL: https://github.com/apache/spark/pull/31592#issuecomment-782070724
**[Test build #135268 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135268/testReport)** for PR 31592 at commit [`9630b72`](https://github.com/apache/spark/commit/9630b72b6bb53a0a7e5fad3883ee415a7a2a9cdc).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31592: [SPARK-34421][SQL][3.0] Resolve temporary functions and views in views with CTEs
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31592:
URL: https://github.com/apache/spark/pull/31592#issuecomment-782097005
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39848/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31592: [SPARK-34421][SQL][3.0] Resolve temporary functions and views in views with CTEs
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31592:
URL: https://github.com/apache/spark/pull/31592#issuecomment-782148397
**[Test build #135271 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135271/testReport)** for PR 31592 at commit [`92df840`](https://github.com/apache/spark/commit/92df8406026593fce14f3b6efb0aea73747ecfe5).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31592: [SPARK-34421][SQL][3.0] Resolve temporary functions and views in views with CTEs
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31592:
URL: https://github.com/apache/spark/pull/31592#issuecomment-782170923
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39852/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31592: [SPARK-34421][SQL][3.0] Resolve temporary functions and views in views with CTEs
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31592:
URL: https://github.com/apache/spark/pull/31592#issuecomment-782097041
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39848/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] peter-toth commented on a change in pull request #31592: [SPARK-34421][SQL][3.0] Resolve temporary functions and views in views with CTEs
Posted by GitBox <gi...@apache.org>.
peter-toth commented on a change in pull request #31592:
URL: https://github.com/apache/spark/pull/31592#discussion_r579258578
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala
##########
@@ -3650,6 +3650,84 @@ class SQLQuerySuite extends QueryTest with SharedSparkSession with AdaptiveSpark
}
}
}
+
+ test("SPARK-34421: Resolve temporary objects in temporary views with CTEs") {
Review comment:
Yes it passes as expected. All right, removed in 92df8406026593fce14f3b6efb0aea73747ecfe5
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31592: [SPARK-34421][SQL][3.0] Resolve temporary functions and views in views with CTEs
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31592:
URL: https://github.com/apache/spark/pull/31592#issuecomment-782285351
**[Test build #135271 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135271/testReport)** for PR 31592 at commit [`92df840`](https://github.com/apache/spark/commit/92df8406026593fce14f3b6efb0aea73747ecfe5).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan closed pull request #31592: [SPARK-34421][SQL][3.0] Resolve temporary functions and views in views with CTEs
Posted by GitBox <gi...@apache.org>.
cloud-fan closed pull request #31592:
URL: https://github.com/apache/spark/pull/31592
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31592: [SPARK-34421][SQL][3.0] Resolve temporary functions and views in views with CTEs
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31592:
URL: https://github.com/apache/spark/pull/31592#issuecomment-782097041
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39848/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31592: [SPARK-34421][SQL][3.0] Resolve temporary functions and views in views with CTEs
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31592:
URL: https://github.com/apache/spark/pull/31592#issuecomment-782309991
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135271/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31592: [SPARK-34421][SQL][3.0] Resolve temporary functions and views in views with CTEs
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31592:
URL: https://github.com/apache/spark/pull/31592#issuecomment-782170954
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39852/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #31592: [SPARK-34421][SQL][3.0] Resolve temporary functions and views in views with CTEs
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31592:
URL: https://github.com/apache/spark/pull/31592#issuecomment-782148397
**[Test build #135271 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135271/testReport)** for PR 31592 at commit [`92df840`](https://github.com/apache/spark/commit/92df8406026593fce14f3b6efb0aea73747ecfe5).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org