You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/03/12 17:05:07 UTC
[GitHub] [superset] etr2460 opened a new pull request #13602: fix: ParsedQuery subselect edge case
etr2460 opened a new pull request #13602:
URL: https://github.com/apache/superset/pull/13602
### SUMMARY
I found that aliased subselects would break the logic to extract table names from a query. When using sqlparse, it seemed like the query got expanded more than expected when the alias was added:
```
>>> import sqlparse
>>> sqlparse.parse("SELECT f1, (SELECT count(1) FROM t2) FROM t1")[0]._pprint_tree()
|- 0 DML 'SELECT'
|- 1 Whitespace ' '
|- 2 Identifier 'f1'
| `- 0 Name 'f1'
|- 3 Punctuation ','
|- 4 Whitespace ' '
|- 5 Parenthesis '(SELEC...'
| |- 0 Punctuation '('
| |- 1 DML 'SELECT'
| |- 2 Whitespace ' '
| |- 3 Function 'count(...'
| | |- 0 Identifier 'count'
| | | `- 0 Name 'count'
| | `- 1 Parenthesis '(1)'
| | |- 0 Punctuation '('
| | |- 1 Integer '1'
| | `- 2 Punctuation ')'
| |- 4 Whitespace ' '
| |- 5 Keyword 'FROM'
| |- 6 Whitespace ' '
| |- 7 Identifier 't2'
| | `- 0 Name 't2'
| `- 8 Punctuation ')'
|- 6 Whitespace ' '
|- 7 Keyword 'FROM'
|- 8 Whitespace ' '
`- 9 Identifier 't1'
`- 0 Name 't1'
>>> sqlparse.parse("SELECT f1, (SELECT count(1) FROM t2) as f2 FROM t1")[0]._pprint_tree()
|- 0 DML 'SELECT'
|- 1 Whitespace ' '
|- 2 IdentifierList 'f1, (S...'
| |- 0 Identifier 'f1'
| | `- 0 Name 'f1'
| |- 1 Punctuation ','
| |- 2 Whitespace ' '
| `- 3 Identifier '(SELEC...'
| |- 0 Parenthesis '(SELEC...'
| | |- 0 Punctuation '('
| | |- 1 DML 'SELECT'
| | |- 2 Whitespace ' '
| | |- 3 Function 'count(...'
| | | |- 0 Identifier 'count'
| | | | `- 0 Name 'count'
| | | `- 1 Parenthesis '(1)'
| | | |- 0 Punctuation '('
| | | |- 1 Integer '1'
| | | `- 2 Punctuation ')'
| | |- 4 Whitespace ' '
| | |- 5 Keyword 'FROM'
| | |- 6 Whitespace ' '
| | |- 7 Identifier 't2'
| | | `- 0 Name 't2'
| | `- 8 Punctuation ')'
| |- 1 Whitespace ' '
| |- 2 Keyword 'as'
| |- 3 Whitespace ' '
| `- 4 Identifier 'f2'
| `- 0 Name 'f2'
|- 3 Whitespace ' '
|- 4 Keyword 'FROM'
|- 5 Whitespace ' '
`- 6 Identifier 't1'
`- 0 Name 't1'
```
This adds logic to recursively explore sections wrapped in parens, which seems safe and didn't break any of the existing tests while allowing mine to pass. That said, would love any thoughts on a better way to do this too
### TEST PLAN
CI
to: @villebro @lilykuang @serenajiang @bkyryliuk
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13602: fix: ParsedQuery subselect edge case
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13602:
URL: https://github.com/apache/superset/pull/13602#issuecomment-797636951
# [Codecov](https://codecov.io/gh/apache/superset/pull/13602?src=pr&el=h1) Report
> Merging [#13602](https://codecov.io/gh/apache/superset/pull/13602?src=pr&el=desc) (91dacad) into [master](https://codecov.io/gh/apache/superset/commit/de0c6c9c56636d48b199af78b50ea91cb43b8f9f?el=desc) (de0c6c9) will **decrease** coverage by `9.78%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/superset/pull/13602?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13602 +/- ##
==========================================
- Coverage 80.93% 71.14% -9.79%
==========================================
Files 304 827 +523
Lines 24807 41441 +16634
Branches 0 4300 +4300
==========================================
+ Hits 20077 29485 +9408
- Misses 4730 11956 +7226
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.73% <ø> (?)` | |
| hive | `80.07% <100.00%> (ø)` | |
| mysql | `80.37% <100.00%> (ø)` | |
| postgres | `80.42% <100.00%> (ø)` | |
| presto | `?` | |
| python | `80.81% <100.00%> (-0.12%)` | :arrow_down: |
| sqlite | `80.03% <100.00%> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13602?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/sql\_parse.py](https://codecov.io/gh/apache/superset/pull/13602/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3BhcnNlLnB5) | `99.38% <100.00%> (ø)` | |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/13602/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `82.84% <0.00%> (-5.86%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/13602/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.55% <0.00%> (-0.28%)` | :arrow_down: |
| [...d/src/dashboard/components/FiltersBadge/Styles.tsx](https://codecov.io/gh/apache/superset/pull/13602/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0ZpbHRlcnNCYWRnZS9TdHlsZXMudHN4) | `63.15% <0.00%> (ø)` | |
| [superset-frontend/src/logger/actions/index.ts](https://codecov.io/gh/apache/superset/pull/13602/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2xvZ2dlci9hY3Rpb25zL2luZGV4LnRz) | `100.00% <0.00%> (ø)` | |
| [...perset-frontend/src/components/FormLabel/index.tsx](https://codecov.io/gh/apache/superset/pull/13602/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRm9ybUxhYmVsL2luZGV4LnRzeA==) | `100.00% <0.00%> (ø)` | |
| [...frontend/src/SqlLab/components/QueryStateLabel.jsx](https://codecov.io/gh/apache/superset/pull/13602/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1F1ZXJ5U3RhdGVMYWJlbC5qc3g=) | `40.00% <0.00%> (ø)` | |
| [.../controls/MetricControl/AdhocMetricEditPopover.jsx](https://codecov.io/gh/apache/superset/pull/13602/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL0FkaG9jTWV0cmljRWRpdFBvcG92ZXIuanN4) | `77.09% <0.00%> (ø)` | |
| [...rset-frontend/src/components/IconTooltip/index.tsx](https://codecov.io/gh/apache/superset/pull/13602/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSWNvblRvb2x0aXAvaW5kZXgudHN4) | `13.33% <0.00%> (ø)` | |
| [superset-frontend/src/modules/dates.js](https://codecov.io/gh/apache/superset/pull/13602/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL21vZHVsZXMvZGF0ZXMuanM=) | `75.00% <0.00%> (ø)` | |
| ... and [516 more](https://codecov.io/gh/apache/superset/pull/13602/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13602?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13602?src=pr&el=footer). Last update [de0c6c9...62d304b](https://codecov.io/gh/apache/superset/pull/13602?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] serenajiang commented on a change in pull request #13602: fix: ParsedQuery subselect edge case
Posted by GitBox <gi...@apache.org>.
serenajiang commented on a change in pull request #13602:
URL: https://github.com/apache/superset/pull/13602#discussion_r593387639
##########
File path: superset/sql_parse.py
##########
@@ -278,7 +285,11 @@ def _extract_from_token( # pylint: disable=too-many-branches
table_name_preceding_token = False
for item in token.tokens:
- if item.is_group and not self._is_identifier(item):
+ if (item.is_group and not self._is_identifier(item)) or (
Review comment:
`item.is_group and (not self.is_identifier(item) or isinstance(item.tokens[0], Parenthesis))`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13602: fix: ParsedQuery subselect edge case
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13602:
URL: https://github.com/apache/superset/pull/13602#issuecomment-797636951
# [Codecov](https://codecov.io/gh/apache/superset/pull/13602?src=pr&el=h1) Report
> Merging [#13602](https://codecov.io/gh/apache/superset/pull/13602?src=pr&el=desc) (4cc8dc5) into [master](https://codecov.io/gh/apache/superset/commit/de0c6c9c56636d48b199af78b50ea91cb43b8f9f?el=desc) (de0c6c9) will **decrease** coverage by `9.62%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/superset/pull/13602?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13602 +/- ##
==========================================
- Coverage 80.93% 71.31% -9.63%
==========================================
Files 304 784 +480
Lines 24807 38743 +13936
Branches 0 3706 +3706
==========================================
+ Hits 20077 27628 +7551
- Misses 4730 11115 +6385
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `54.92% <ø> (?)` | |
| hive | `?` | |
| mysql | `80.37% <100.00%> (ø)` | |
| postgres | `80.43% <100.00%> (+<0.01%)` | :arrow_up: |
| presto | `?` | |
| python | `80.51% <100.00%> (-0.42%)` | :arrow_down: |
| sqlite | `80.03% <100.00%> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13602?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/sql\_parse.py](https://codecov.io/gh/apache/superset/pull/13602/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3BhcnNlLnB5) | `99.38% <100.00%> (ø)` | |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/13602/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/13602/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `74.23% <0.00%> (-16.54%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/13602/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.79% <0.00%> (-6.91%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/13602/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `81.03% <0.00%> (-1.73%)` | :arrow_down: |
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/13602/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `85.67% <0.00%> (-0.49%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/13602/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.55% <0.00%> (-0.28%)` | :arrow_down: |
| [...frontend/src/explore/components/DataTablesPane.tsx](https://codecov.io/gh/apache/superset/pull/13602/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhVGFibGVzUGFuZS50c3g=) | `56.52% <0.00%> (ø)` | |
| [...ntend/src/dashboard/components/dnd/handleScroll.ts](https://codecov.io/gh/apache/superset/pull/13602/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2RuZC9oYW5kbGVTY3JvbGwudHM=) | `15.38% <0.00%> (ø)` | |
| [.../dashboard/util/charts/getEffectiveExtraFilters.ts](https://codecov.io/gh/apache/superset/pull/13602/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2NoYXJ0cy9nZXRFZmZlY3RpdmVFeHRyYUZpbHRlcnMudHM=) | `100.00% <0.00%> (ø)` | |
| ... and [477 more](https://codecov.io/gh/apache/superset/pull/13602/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13602?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13602?src=pr&el=footer). Last update [de0c6c9...4cc8dc5](https://codecov.io/gh/apache/superset/pull/13602?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13602: fix: ParsedQuery subselect edge case
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13602:
URL: https://github.com/apache/superset/pull/13602#issuecomment-797636951
# [Codecov](https://codecov.io/gh/apache/superset/pull/13602?src=pr&el=h1) Report
> Merging [#13602](https://codecov.io/gh/apache/superset/pull/13602?src=pr&el=desc) (91dacad) into [master](https://codecov.io/gh/apache/superset/commit/de0c6c9c56636d48b199af78b50ea91cb43b8f9f?el=desc) (de0c6c9) will **decrease** coverage by `9.78%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/superset/pull/13602?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13602 +/- ##
==========================================
- Coverage 80.93% 71.14% -9.79%
==========================================
Files 304 827 +523
Lines 24807 41441 +16634
Branches 0 4300 +4300
==========================================
+ Hits 20077 29485 +9408
- Misses 4730 11956 +7226
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.73% <ø> (?)` | |
| hive | `80.05% <100.00%> (-0.02%)` | :arrow_down: |
| mysql | `80.37% <100.00%> (ø)` | |
| postgres | `80.42% <100.00%> (ø)` | |
| presto | `?` | |
| python | `80.81% <100.00%> (-0.12%)` | :arrow_down: |
| sqlite | `80.03% <100.00%> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13602?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/sql\_parse.py](https://codecov.io/gh/apache/superset/pull/13602/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3BhcnNlLnB5) | `99.38% <100.00%> (ø)` | |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/13602/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `82.84% <0.00%> (-5.86%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/13602/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.55% <0.00%> (-0.28%)` | :arrow_down: |
| [...d/src/dashboard/components/FiltersBadge/Styles.tsx](https://codecov.io/gh/apache/superset/pull/13602/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0ZpbHRlcnNCYWRnZS9TdHlsZXMudHN4) | `63.15% <0.00%> (ø)` | |
| [superset-frontend/src/logger/actions/index.ts](https://codecov.io/gh/apache/superset/pull/13602/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2xvZ2dlci9hY3Rpb25zL2luZGV4LnRz) | `100.00% <0.00%> (ø)` | |
| [...perset-frontend/src/components/FormLabel/index.tsx](https://codecov.io/gh/apache/superset/pull/13602/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRm9ybUxhYmVsL2luZGV4LnRzeA==) | `100.00% <0.00%> (ø)` | |
| [...frontend/src/SqlLab/components/QueryStateLabel.jsx](https://codecov.io/gh/apache/superset/pull/13602/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1F1ZXJ5U3RhdGVMYWJlbC5qc3g=) | `40.00% <0.00%> (ø)` | |
| [.../controls/MetricControl/AdhocMetricEditPopover.jsx](https://codecov.io/gh/apache/superset/pull/13602/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL0FkaG9jTWV0cmljRWRpdFBvcG92ZXIuanN4) | `77.09% <0.00%> (ø)` | |
| [...rset-frontend/src/components/IconTooltip/index.tsx](https://codecov.io/gh/apache/superset/pull/13602/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSWNvblRvb2x0aXAvaW5kZXgudHN4) | `13.33% <0.00%> (ø)` | |
| [superset-frontend/src/modules/dates.js](https://codecov.io/gh/apache/superset/pull/13602/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL21vZHVsZXMvZGF0ZXMuanM=) | `75.00% <0.00%> (ø)` | |
| ... and [516 more](https://codecov.io/gh/apache/superset/pull/13602/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13602?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13602?src=pr&el=footer). Last update [de0c6c9...62d304b](https://codecov.io/gh/apache/superset/pull/13602?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13602: fix: ParsedQuery subselect edge case
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13602:
URL: https://github.com/apache/superset/pull/13602#issuecomment-797636951
# [Codecov](https://codecov.io/gh/apache/superset/pull/13602?src=pr&el=h1) Report
> Merging [#13602](https://codecov.io/gh/apache/superset/pull/13602?src=pr&el=desc) (91dacad) into [master](https://codecov.io/gh/apache/superset/commit/de0c6c9c56636d48b199af78b50ea91cb43b8f9f?el=desc) (de0c6c9) will **decrease** coverage by `9.78%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/superset/pull/13602?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13602 +/- ##
==========================================
- Coverage 80.93% 71.14% -9.79%
==========================================
Files 304 827 +523
Lines 24807 41441 +16634
Branches 0 4300 +4300
==========================================
+ Hits 20077 29485 +9408
- Misses 4730 11956 +7226
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.73% <ø> (?)` | |
| hive | `80.07% <100.00%> (ø)` | |
| mysql | `80.37% <100.00%> (ø)` | |
| postgres | `80.42% <100.00%> (ø)` | |
| presto | `?` | |
| python | `80.81% <100.00%> (-0.12%)` | :arrow_down: |
| sqlite | `80.03% <100.00%> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13602?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/sql\_parse.py](https://codecov.io/gh/apache/superset/pull/13602/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3BhcnNlLnB5) | `99.38% <100.00%> (ø)` | |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/13602/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `82.84% <0.00%> (-5.86%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/13602/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.55% <0.00%> (-0.28%)` | :arrow_down: |
| [...d/src/dashboard/components/FiltersBadge/Styles.tsx](https://codecov.io/gh/apache/superset/pull/13602/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0ZpbHRlcnNCYWRnZS9TdHlsZXMudHN4) | `63.15% <0.00%> (ø)` | |
| [superset-frontend/src/logger/actions/index.ts](https://codecov.io/gh/apache/superset/pull/13602/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2xvZ2dlci9hY3Rpb25zL2luZGV4LnRz) | `100.00% <0.00%> (ø)` | |
| [...perset-frontend/src/components/FormLabel/index.tsx](https://codecov.io/gh/apache/superset/pull/13602/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRm9ybUxhYmVsL2luZGV4LnRzeA==) | `100.00% <0.00%> (ø)` | |
| [...frontend/src/SqlLab/components/QueryStateLabel.jsx](https://codecov.io/gh/apache/superset/pull/13602/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1F1ZXJ5U3RhdGVMYWJlbC5qc3g=) | `40.00% <0.00%> (ø)` | |
| [.../controls/MetricControl/AdhocMetricEditPopover.jsx](https://codecov.io/gh/apache/superset/pull/13602/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL0FkaG9jTWV0cmljRWRpdFBvcG92ZXIuanN4) | `77.09% <0.00%> (ø)` | |
| [...rset-frontend/src/components/IconTooltip/index.tsx](https://codecov.io/gh/apache/superset/pull/13602/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSWNvblRvb2x0aXAvaW5kZXgudHN4) | `13.33% <0.00%> (ø)` | |
| [superset-frontend/src/modules/dates.js](https://codecov.io/gh/apache/superset/pull/13602/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL21vZHVsZXMvZGF0ZXMuanM=) | `75.00% <0.00%> (ø)` | |
| ... and [516 more](https://codecov.io/gh/apache/superset/pull/13602/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13602?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13602?src=pr&el=footer). Last update [de0c6c9...4cc8dc5](https://codecov.io/gh/apache/superset/pull/13602?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13602: fix: ParsedQuery subselect edge case
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13602:
URL: https://github.com/apache/superset/pull/13602#issuecomment-797636951
# [Codecov](https://codecov.io/gh/apache/superset/pull/13602?src=pr&el=h1) Report
> Merging [#13602](https://codecov.io/gh/apache/superset/pull/13602?src=pr&el=desc) (4cc8dc5) into [master](https://codecov.io/gh/apache/superset/commit/de0c6c9c56636d48b199af78b50ea91cb43b8f9f?el=desc) (de0c6c9) will **decrease** coverage by `9.97%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/superset/pull/13602?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13602 +/- ##
==========================================
- Coverage 80.93% 70.96% -9.98%
==========================================
Files 304 828 +524
Lines 24807 41443 +16636
Branches 0 4300 +4300
==========================================
+ Hits 20077 29409 +9332
- Misses 4730 12034 +7304
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.72% <ø> (?)` | |
| hive | `?` | |
| mysql | `80.37% <100.00%> (ø)` | |
| postgres | `80.43% <100.00%> (+<0.01%)` | :arrow_up: |
| presto | `?` | |
| python | `80.51% <100.00%> (-0.42%)` | :arrow_down: |
| sqlite | `80.03% <100.00%> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13602?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/sql\_parse.py](https://codecov.io/gh/apache/superset/pull/13602/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3BhcnNlLnB5) | `99.38% <100.00%> (ø)` | |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/13602/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/13602/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `74.23% <0.00%> (-16.54%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/13602/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.79% <0.00%> (-6.91%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/13602/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `81.03% <0.00%> (-1.73%)` | :arrow_down: |
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/13602/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `85.67% <0.00%> (-0.49%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/13602/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.55% <0.00%> (-0.28%)` | :arrow_down: |
| [superset-frontend/src/dataMask/reducer.ts](https://codecov.io/gh/apache/superset/pull/13602/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2RhdGFNYXNrL3JlZHVjZXIudHM=) | `100.00% <0.00%> (ø)` | |
| [...onents/ErrorMessage/ErrorMessageWithStackTrace.tsx](https://codecov.io/gh/apache/superset/pull/13602/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL0Vycm9yTWVzc2FnZVdpdGhTdGFja1RyYWNlLnRzeA==) | `7.14% <0.00%> (ø)` | |
| [...Control/AdhocFilterEditPopoverSimpleTabContent.jsx](https://codecov.io/gh/apache/superset/pull/13602/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyRWRpdFBvcG92ZXJTaW1wbGVUYWJDb250ZW50LmpzeA==) | `3.33% <0.00%> (ø)` | |
| ... and [521 more](https://codecov.io/gh/apache/superset/pull/13602/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13602?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13602?src=pr&el=footer). Last update [de0c6c9...4cc8dc5](https://codecov.io/gh/apache/superset/pull/13602?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] etr2460 commented on a change in pull request #13602: fix: ParsedQuery subselect edge case
Posted by GitBox <gi...@apache.org>.
etr2460 commented on a change in pull request #13602:
URL: https://github.com/apache/superset/pull/13602#discussion_r593406784
##########
File path: superset/sql_parse.py
##########
@@ -278,7 +285,11 @@ def _extract_from_token( # pylint: disable=too-many-branches
table_name_preceding_token = False
for item in token.tokens:
- if item.is_group and not self._is_identifier(item):
+ if (item.is_group and not self._is_identifier(item)) or (
Review comment:
i think it's equivalent, do you think it's as readable?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13602: fix: ParsedQuery subselect edge case
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13602:
URL: https://github.com/apache/superset/pull/13602#issuecomment-797636951
# [Codecov](https://codecov.io/gh/apache/superset/pull/13602?src=pr&el=h1) Report
> Merging [#13602](https://codecov.io/gh/apache/superset/pull/13602?src=pr&el=desc) (91dacad) into [master](https://codecov.io/gh/apache/superset/commit/de0c6c9c56636d48b199af78b50ea91cb43b8f9f?el=desc) (de0c6c9) will **decrease** coverage by `9.84%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/superset/pull/13602?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13602 +/- ##
==========================================
- Coverage 80.81% 70.96% -9.85%
==========================================
Files 304 827 +523
Lines 24807 41441 +16634
Branches 0 4300 +4300
==========================================
+ Hits 20048 29410 +9362
- Misses 4759 12031 +7272
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.73% <ø> (?)` | |
| hive | `?` | |
| mysql | `80.37% <100.00%> (ø)` | |
| postgres | `80.42% <100.00%> (ø)` | |
| python | `80.51% <100.00%> (-0.31%)` | :arrow_down: |
| sqlite | `80.03% <100.00%> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13602?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/sql\_parse.py](https://codecov.io/gh/apache/superset/pull/13602/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3BhcnNlLnB5) | `99.38% <100.00%> (ø)` | |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/13602/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/13602/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `74.23% <0.00%> (-16.54%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/13602/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `81.03% <0.00%> (-1.73%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/13602/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.79% <0.00%> (-1.05%)` | :arrow_down: |
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/13602/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `85.67% <0.00%> (-0.49%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/utils/sqlKeywords.ts](https://codecov.io/gh/apache/superset/pull/13602/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi91dGlscy9zcWxLZXl3b3Jkcy50cw==) | `100.00% <0.00%> (ø)` | |
| [superset-frontend/src/components/Select/utils.ts](https://codecov.io/gh/apache/superset/pull/13602/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L3V0aWxzLnRz) | `86.66% <0.00%> (ø)` | |
| [...ontend/src/dashboard/util/getChartIdsFromLayout.js](https://codecov.io/gh/apache/superset/pull/13602/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldENoYXJ0SWRzRnJvbUxheW91dC5qcw==) | `100.00% <0.00%> (ø)` | |
| [superset-frontend/src/dataMask/actions.ts](https://codecov.io/gh/apache/superset/pull/13602/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2RhdGFNYXNrL2FjdGlvbnMudHM=) | `100.00% <0.00%> (ø)` | |
| ... and [519 more](https://codecov.io/gh/apache/superset/pull/13602/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13602?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13602?src=pr&el=footer). Last update [de0c6c9...62d304b](https://codecov.io/gh/apache/superset/pull/13602?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13602: fix: ParsedQuery subselect edge case
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13602:
URL: https://github.com/apache/superset/pull/13602#issuecomment-797636951
# [Codecov](https://codecov.io/gh/apache/superset/pull/13602?src=pr&el=h1) Report
> Merging [#13602](https://codecov.io/gh/apache/superset/pull/13602?src=pr&el=desc) (91dacad) into [master](https://codecov.io/gh/apache/superset/commit/de0c6c9c56636d48b199af78b50ea91cb43b8f9f?el=desc) (de0c6c9) will **decrease** coverage by `9.49%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/superset/pull/13602?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13602 +/- ##
==========================================
- Coverage 80.81% 71.32% -9.50%
==========================================
Files 304 780 +476
Lines 24807 38686 +13879
Branches 0 3682 +3682
==========================================
+ Hits 20048 27593 +7545
- Misses 4759 11093 +6334
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `54.90% <ø> (?)` | |
| hive | `?` | |
| mysql | `80.37% <100.00%> (ø)` | |
| postgres | `80.42% <100.00%> (ø)` | |
| python | `80.51% <100.00%> (-0.31%)` | :arrow_down: |
| sqlite | `80.03% <100.00%> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13602?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/sql\_parse.py](https://codecov.io/gh/apache/superset/pull/13602/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3BhcnNlLnB5) | `99.38% <100.00%> (ø)` | |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/13602/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/13602/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `74.23% <0.00%> (-16.54%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/13602/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `81.03% <0.00%> (-1.73%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/13602/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.79% <0.00%> (-1.05%)` | :arrow_down: |
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/13602/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `85.67% <0.00%> (-0.49%)` | :arrow_down: |
| [...hooks/useComponentDidMount/useComponentDidMount.ts](https://codecov.io/gh/apache/superset/pull/13602/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9ob29rcy91c2VDb21wb25lbnREaWRNb3VudC91c2VDb21wb25lbnREaWRNb3VudC50cw==) | `100.00% <0.00%> (ø)` | |
| [...rontend/src/dashboard/containers/DashboardGrid.jsx](https://codecov.io/gh/apache/superset/pull/13602/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0Rhc2hib2FyZEdyaWQuanN4) | `100.00% <0.00%> (ø)` | |
| [.../src/dashboard/components/BuilderComponentPane.tsx](https://codecov.io/gh/apache/superset/pull/13602/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0J1aWxkZXJDb21wb25lbnRQYW5lLnRzeA==) | `100.00% <0.00%> (ø)` | |
| [superset-frontend/src/dataMask/actions.ts](https://codecov.io/gh/apache/superset/pull/13602/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2RhdGFNYXNrL2FjdGlvbnMudHM=) | `60.00% <0.00%> (ø)` | |
| ... and [472 more](https://codecov.io/gh/apache/superset/pull/13602/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13602?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13602?src=pr&el=footer). Last update [de0c6c9...62d304b](https://codecov.io/gh/apache/superset/pull/13602?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] etr2460 merged pull request #13602: fix: ParsedQuery subselect edge case
Posted by GitBox <gi...@apache.org>.
etr2460 merged pull request #13602:
URL: https://github.com/apache/superset/pull/13602
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13602: fix: ParsedQuery subselect edge case
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13602:
URL: https://github.com/apache/superset/pull/13602#issuecomment-797636951
# [Codecov](https://codecov.io/gh/apache/superset/pull/13602?src=pr&el=h1) Report
> Merging [#13602](https://codecov.io/gh/apache/superset/pull/13602?src=pr&el=desc) (4cc8dc5) into [master](https://codecov.io/gh/apache/superset/commit/de0c6c9c56636d48b199af78b50ea91cb43b8f9f?el=desc) (de0c6c9) will **decrease** coverage by `9.97%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/superset/pull/13602?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13602 +/- ##
==========================================
- Coverage 80.93% 70.96% -9.98%
==========================================
Files 304 828 +524
Lines 24807 41443 +16636
Branches 0 4300 +4300
==========================================
+ Hits 20077 29409 +9332
- Misses 4730 12034 +7304
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.72% <ø> (?)` | |
| hive | `?` | |
| mysql | `80.37% <100.00%> (ø)` | |
| postgres | `80.42% <100.00%> (ø)` | |
| presto | `?` | |
| python | `80.51% <100.00%> (-0.42%)` | :arrow_down: |
| sqlite | `80.03% <100.00%> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13602?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/sql\_parse.py](https://codecov.io/gh/apache/superset/pull/13602/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3BhcnNlLnB5) | `99.38% <100.00%> (ø)` | |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/13602/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/13602/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `74.23% <0.00%> (-16.54%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/13602/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.79% <0.00%> (-6.91%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/13602/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `81.03% <0.00%> (-1.73%)` | :arrow_down: |
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/13602/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `85.67% <0.00%> (-0.49%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/13602/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.55% <0.00%> (-0.28%)` | :arrow_down: |
| [...ontrols/DndColumnSelectControl/DndMetricSelect.tsx](https://codecov.io/gh/apache/superset/pull/13602/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EbmRDb2x1bW5TZWxlY3RDb250cm9sL0RuZE1ldHJpY1NlbGVjdC50c3g=) | `4.42% <0.00%> (ø)` | |
| [...rset-frontend/src/components/ListView/ListView.tsx](https://codecov.io/gh/apache/superset/pull/13602/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGlzdFZpZXcvTGlzdFZpZXcudHN4) | `92.04% <0.00%> (ø)` | |
| [...teFilterControl/components/DateFunctionTooltip.tsx](https://codecov.io/gh/apache/superset/pull/13602/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9jb21wb25lbnRzL0RhdGVGdW5jdGlvblRvb2x0aXAudHN4) | `100.00% <0.00%> (ø)` | |
| ... and [521 more](https://codecov.io/gh/apache/superset/pull/13602/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13602?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13602?src=pr&el=footer). Last update [de0c6c9...4cc8dc5](https://codecov.io/gh/apache/superset/pull/13602?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #13602: fix: ParsedQuery subselect edge case
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #13602:
URL: https://github.com/apache/superset/pull/13602#issuecomment-797636951
# [Codecov](https://codecov.io/gh/apache/superset/pull/13602?src=pr&el=h1) Report
> Merging [#13602](https://codecov.io/gh/apache/superset/pull/13602?src=pr&el=desc) (91dacad) into [master](https://codecov.io/gh/apache/superset/commit/de0c6c9c56636d48b199af78b50ea91cb43b8f9f?el=desc) (de0c6c9) will **decrease** coverage by `0.30%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/superset/pull/13602?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13602 +/- ##
==========================================
- Coverage 80.81% 80.51% -0.31%
==========================================
Files 304 304
Lines 24807 24807
==========================================
- Hits 20048 19973 -75
- Misses 4759 4834 +75
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| mysql | `80.37% <100.00%> (ø)` | |
| postgres | `80.42% <100.00%> (ø)` | |
| python | `80.51% <100.00%> (-0.31%)` | :arrow_down: |
| sqlite | `80.03% <100.00%> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13602?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/sql\_parse.py](https://codecov.io/gh/apache/superset/pull/13602/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3BhcnNlLnB5) | `99.38% <100.00%> (ø)` | |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/13602/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/13602/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `74.23% <0.00%> (-16.54%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/13602/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `81.03% <0.00%> (-1.73%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/13602/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.79% <0.00%> (-1.05%)` | :arrow_down: |
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/13602/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `85.67% <0.00%> (-0.49%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13602?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13602?src=pr&el=footer). Last update [de0c6c9...62d304b](https://codecov.io/gh/apache/superset/pull/13602?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] etr2460 commented on pull request #13602: fix: ParsedQuery subselect edge case
Posted by GitBox <gi...@apache.org>.
etr2460 commented on pull request #13602:
URL: https://github.com/apache/superset/pull/13602#issuecomment-797749612
add the parens test you recommended
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org