You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by gauravaradhye <gi...@git.apache.org> on 2015/06/26 10:30:09 UTC
[GitHub] cloudstack pull request: CLOUDSTACK-8582: Skipping unsuitable test...
GitHub user gauravaradhye opened a pull request:
https://github.com/apache/cloudstack/pull/532
CLOUDSTACK-8582: Skipping unsuitable test cases for simulator
Modifying tags for test cases which shouldn't be run on simulator (Test cases requiring download of templates/ISOs and creation of templates from snapshots)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gauravaradhye/cloudstack 8582
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/532.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #532
----
commit d39ddb18ff2f780e95db4978400d964329364b0c
Author: Gaurav Aradhye <ga...@clogeny.com>
Date: 2015-06-26T08:09:07Z
CLOUDSTACK-8582: Skipping unsuitable test cases for simulator
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8582: Skipping unsuitable test...
Posted by sanju1010 <gi...@git.apache.org>.
Github user sanju1010 commented on the pull request:
https://github.com/apache/cloudstack/pull/532#issuecomment-115609404
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8582: Skipping unsuitable test...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/532
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8582: Skipping unsuitable test...
Posted by gauravaradhye <gi...@git.apache.org>.
Github user gauravaradhye commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/532#discussion_r33338559
--- Diff: test/integration/component/test_ps_domain_limits.py ---
@@ -194,7 +194,7 @@ def setupAccounts(self):
return [FAIL, e, None]
return [PASS, None, users]
- @attr(tags=["advanced", "selfservice"])
+ @attr(tags=["advanced", "selfservice"], required_hardware="false")
--- End diff --
Yes it can run, it only concerns primary storage counts.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8582: Skipping unsuitable test...
Posted by runseb <gi...@git.apache.org>.
Github user runseb commented on the pull request:
https://github.com/apache/cloudstack/pull/532#issuecomment-116534604
these tests used to be required_hardware=true, and now it's false. So when are we running these tests ? Are they included in Travis runs, in which case we are loosing tests with this ?
Also does this pass pep8, flake8 etc ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
Re: [GitHub] cloudstack pull request: CLOUDSTACK-8582: Skipping
unsuitable test...
Posted by Sanjeev N <sa...@apache.org>.
if required_hardware=false means these tests can run on Simulator.
On Thu, Jul 2, 2015 at 3:06 PM, runseb <gi...@git.apache.org> wrote:
> Github user runseb commented on the pull request:
>
> https://github.com/apache/cloudstack/pull/532#issuecomment-117977659
>
> @gauravaradhye if you answer my questions I can give a LGTM :)
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastructure@apache.org or file a JIRA ticket
> with INFRA.
> ---
>
[GitHub] cloudstack pull request: CLOUDSTACK-8582: Skipping unsuitable test...
Posted by runseb <gi...@git.apache.org>.
Github user runseb commented on the pull request:
https://github.com/apache/cloudstack/pull/532#issuecomment-117977659
@gauravaradhye if you answer my questions I can give a LGTM :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8582: Skipping unsuitable test...
Posted by gauravaradhye <gi...@git.apache.org>.
Github user gauravaradhye commented on the pull request:
https://github.com/apache/cloudstack/pull/532#issuecomment-120846548
@runseb Sorry for delayed response, I was away for two weeks.
As said by Sanjeev, the tests were wrongly tagged. required_hardware = "true" implies test can't be run on simulator and should not be, as it requires resources other than just management server.
I have only corrected the tags in this test and did not make any other changes such fixing pep8 issues, as it would confuse the reviewer.
I hope this answers your questions, please let me know in case anything unclear.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8582: Skipping unsuitable test...
Posted by bhaisaab <gi...@git.apache.org>.
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/532#issuecomment-121829768
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8582: Skipping unsuitable test...
Posted by sanju1010 <gi...@git.apache.org>.
Github user sanju1010 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/532#discussion_r33338448
--- Diff: test/integration/component/test_ps_domain_limits.py ---
@@ -194,7 +194,7 @@ def setupAccounts(self):
return [FAIL, e, None]
return [PASS, None, users]
- @attr(tags=["advanced", "selfservice"])
+ @attr(tags=["advanced", "selfservice"], required_hardware="false")
--- End diff --
Is this test needs to be run on simulator?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8582: Skipping unsuitable test...
Posted by gauravaradhye <gi...@git.apache.org>.
Github user gauravaradhye commented on the pull request:
https://github.com/apache/cloudstack/pull/532#issuecomment-116523709
Need a second LGTM, anyone?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---