You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Owen O'Malley (JIRA)" <ji...@apache.org> on 2009/11/14 01:29:40 UTC
[jira] Created: (HADOOP-6374) JUnit tests should never depend on
anything in conf
JUnit tests should never depend on anything in conf
---------------------------------------------------
Key: HADOOP-6374
URL: https://issues.apache.org/jira/browse/HADOOP-6374
Project: Hadoop Common
Issue Type: Bug
Components: test
Reporter: Owen O'Malley
Priority: Blocker
The recent change to mapred-queues.xml that causes many mapreduce tests to break unless you delete conf/mapred-queues.xml out of your build tree is bad. We need to make sure that nothing in conf is used in the unit tests. One potential solution is to copy the templates into build/test/conf and use that instead.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6374) JUnit tests should never depend on
anything in conf
Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6374?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Konstantin Boudnik updated HADOOP-6374:
---------------------------------------
Resolution: Fixed
Fix Version/s: 0.22.0
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
I've just committed this to the trunk. Thanks Anatoli!
> JUnit tests should never depend on anything in conf
> ---------------------------------------------------
>
> Key: HADOOP-6374
> URL: https://issues.apache.org/jira/browse/HADOOP-6374
> Project: Hadoop Common
> Issue Type: Bug
> Components: test
> Reporter: Owen O'Malley
> Assignee: Anatoli Fomenko
> Priority: Blocker
> Fix For: 0.22.0
>
> Attachments: HADOOP-6374.patch
>
>
> The recent change to mapred-queues.xml that causes many mapreduce tests to break unless you delete conf/mapred-queues.xml out of your build tree is bad. We need to make sure that nothing in conf is used in the unit tests. One potential solution is to copy the templates into build/test/conf and use that instead.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6374) JUnit tests should never depend on
anything in conf
Posted by "Anatoli Fomenko (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6374?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Anatoli Fomenko updated HADOOP-6374:
------------------------------------
Status: Patch Available (was: Open)
Please review the submitted patch.
The patch is the same as in MAPREDUCE-1369, attached at 2010-01-11 04:04 AM (with different line numbers), and details are the same as described in the comment to MAPREDUCE-1369 added at 11/Jan/10 04:12 AM.
> JUnit tests should never depend on anything in conf
> ---------------------------------------------------
>
> Key: HADOOP-6374
> URL: https://issues.apache.org/jira/browse/HADOOP-6374
> Project: Hadoop Common
> Issue Type: Bug
> Components: test
> Reporter: Owen O'Malley
> Assignee: Anatoli Fomenko
> Priority: Blocker
> Attachments: HADOOP-6374.patch
>
>
> The recent change to mapred-queues.xml that causes many mapreduce tests to break unless you delete conf/mapred-queues.xml out of your build tree is bad. We need to make sure that nothing in conf is used in the unit tests. One potential solution is to copy the templates into build/test/conf and use that instead.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6374) JUnit tests should never depend on
anything in conf
Posted by "Anatoli Fomenko (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12798572#action_12798572 ]
Anatoli Fomenko commented on HADOOP-6374:
-----------------------------------------
Similar issue has been created for Map/Reduce (MAPREDUCE-1369, see Issue Links). Perhaps, a similar issue should be also created for HDFS.
> JUnit tests should never depend on anything in conf
> ---------------------------------------------------
>
> Key: HADOOP-6374
> URL: https://issues.apache.org/jira/browse/HADOOP-6374
> Project: Hadoop Common
> Issue Type: Bug
> Components: test
> Reporter: Owen O'Malley
> Assignee: Anatoli Fomenko
> Priority: Blocker
>
> The recent change to mapred-queues.xml that causes many mapreduce tests to break unless you delete conf/mapred-queues.xml out of your build tree is bad. We need to make sure that nothing in conf is used in the unit tests. One potential solution is to copy the templates into build/test/conf and use that instead.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6374) JUnit tests should never depend on
anything in conf
Posted by "Anatoli Fomenko (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6374?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Anatoli Fomenko updated HADOOP-6374:
------------------------------------
Attachment: HADOOP-6374.patch
> JUnit tests should never depend on anything in conf
> ---------------------------------------------------
>
> Key: HADOOP-6374
> URL: https://issues.apache.org/jira/browse/HADOOP-6374
> Project: Hadoop Common
> Issue Type: Bug
> Components: test
> Reporter: Owen O'Malley
> Assignee: Anatoli Fomenko
> Priority: Blocker
> Attachments: HADOOP-6374.patch
>
>
> The recent change to mapred-queues.xml that causes many mapreduce tests to break unless you delete conf/mapred-queues.xml out of your build tree is bad. We need to make sure that nothing in conf is used in the unit tests. One potential solution is to copy the templates into build/test/conf and use that instead.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6374) JUnit tests should never depend on
anything in conf
Posted by "Anatoli Fomenko (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12798722#action_12798722 ]
Anatoli Fomenko commented on HADOOP-6374:
-----------------------------------------
Please review the submitted patch. Thanks.
> JUnit tests should never depend on anything in conf
> ---------------------------------------------------
>
> Key: HADOOP-6374
> URL: https://issues.apache.org/jira/browse/HADOOP-6374
> Project: Hadoop Common
> Issue Type: Bug
> Components: test
> Reporter: Owen O'Malley
> Assignee: Anatoli Fomenko
> Priority: Blocker
> Attachments: HADOOP-6374.patch
>
>
> The recent change to mapred-queues.xml that causes many mapreduce tests to break unless you delete conf/mapred-queues.xml out of your build tree is bad. We need to make sure that nothing in conf is used in the unit tests. One potential solution is to copy the templates into build/test/conf and use that instead.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6374) JUnit tests should never depend on
anything in conf
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12804714#action_12804714 ]
Hudson commented on HADOOP-6374:
--------------------------------
Integrated in Hadoop-Common-trunk #229 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk/229/])
> JUnit tests should never depend on anything in conf
> ---------------------------------------------------
>
> Key: HADOOP-6374
> URL: https://issues.apache.org/jira/browse/HADOOP-6374
> Project: Hadoop Common
> Issue Type: Bug
> Components: test
> Affects Versions: 0.21.0, 0.22.0
> Reporter: Owen O'Malley
> Assignee: Anatoli Fomenko
> Priority: Blocker
> Fix For: 0.21.0, 0.22.0
>
> Attachments: HADOOP-6374.patch
>
>
> The recent change to mapred-queues.xml that causes many mapreduce tests to break unless you delete conf/mapred-queues.xml out of your build tree is bad. We need to make sure that nothing in conf is used in the unit tests. One potential solution is to copy the templates into build/test/conf and use that instead.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6374) JUnit tests should never depend on
anything in conf
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12798594#action_12798594 ]
Hadoop QA commented on HADOOP-6374:
-----------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12429870/HADOOP-6374.patch
against trunk revision 897023.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 1 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/268/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/268/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/268/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/268/console
This message is automatically generated.
> JUnit tests should never depend on anything in conf
> ---------------------------------------------------
>
> Key: HADOOP-6374
> URL: https://issues.apache.org/jira/browse/HADOOP-6374
> Project: Hadoop Common
> Issue Type: Bug
> Components: test
> Reporter: Owen O'Malley
> Assignee: Anatoli Fomenko
> Priority: Blocker
> Attachments: HADOOP-6374.patch
>
>
> The recent change to mapred-queues.xml that causes many mapreduce tests to break unless you delete conf/mapred-queues.xml out of your build tree is bad. We need to make sure that nothing in conf is used in the unit tests. One potential solution is to copy the templates into build/test/conf and use that instead.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6374) JUnit tests should never depend on
anything in conf
Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12803182#action_12803182 ]
Konstantin Boudnik commented on HADOOP-6374:
--------------------------------------------
+1 patch looks good. I see that a similar JIRA has been open for MapReduce. I think the same needs to be done for HDFS subproject.
I also have ran all Common's tests and they seem to be just fine with the patch in place. I'm going to commit it.
> JUnit tests should never depend on anything in conf
> ---------------------------------------------------
>
> Key: HADOOP-6374
> URL: https://issues.apache.org/jira/browse/HADOOP-6374
> Project: Hadoop Common
> Issue Type: Bug
> Components: test
> Reporter: Owen O'Malley
> Assignee: Anatoli Fomenko
> Priority: Blocker
> Attachments: HADOOP-6374.patch
>
>
> The recent change to mapred-queues.xml that causes many mapreduce tests to break unless you delete conf/mapred-queues.xml out of your build tree is bad. We need to make sure that nothing in conf is used in the unit tests. One potential solution is to copy the templates into build/test/conf and use that instead.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (HADOOP-6374) JUnit tests should never depend on
anything in conf
Posted by "Anatoli Fomenko (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6374?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Anatoli Fomenko reassigned HADOOP-6374:
---------------------------------------
Assignee: Anatoli Fomenko
> JUnit tests should never depend on anything in conf
> ---------------------------------------------------
>
> Key: HADOOP-6374
> URL: https://issues.apache.org/jira/browse/HADOOP-6374
> Project: Hadoop Common
> Issue Type: Bug
> Components: test
> Reporter: Owen O'Malley
> Assignee: Anatoli Fomenko
> Priority: Blocker
>
> The recent change to mapred-queues.xml that causes many mapreduce tests to break unless you delete conf/mapred-queues.xml out of your build tree is bad. We need to make sure that nothing in conf is used in the unit tests. One potential solution is to copy the templates into build/test/conf and use that instead.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6374) JUnit tests should never depend on
anything in conf
Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6374?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Konstantin Boudnik updated HADOOP-6374:
---------------------------------------
Affects Version/s: 0.22.0
0.21.0
Fix Version/s: 0.21.0
> JUnit tests should never depend on anything in conf
> ---------------------------------------------------
>
> Key: HADOOP-6374
> URL: https://issues.apache.org/jira/browse/HADOOP-6374
> Project: Hadoop Common
> Issue Type: Bug
> Components: test
> Affects Versions: 0.21.0, 0.22.0
> Reporter: Owen O'Malley
> Assignee: Anatoli Fomenko
> Priority: Blocker
> Fix For: 0.21.0, 0.22.0
>
> Attachments: HADOOP-6374.patch
>
>
> The recent change to mapred-queues.xml that causes many mapreduce tests to break unless you delete conf/mapred-queues.xml out of your build tree is bad. We need to make sure that nothing in conf is used in the unit tests. One potential solution is to copy the templates into build/test/conf and use that instead.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6374) JUnit tests should never depend on
anything in conf
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12804768#action_12804768 ]
Hudson commented on HADOOP-6374:
--------------------------------
Integrated in Hadoop-Common-trunk-Commit #147 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk-Commit/147/])
> JUnit tests should never depend on anything in conf
> ---------------------------------------------------
>
> Key: HADOOP-6374
> URL: https://issues.apache.org/jira/browse/HADOOP-6374
> Project: Hadoop Common
> Issue Type: Bug
> Components: test
> Affects Versions: 0.21.0, 0.22.0
> Reporter: Owen O'Malley
> Assignee: Anatoli Fomenko
> Priority: Blocker
> Fix For: 0.21.0, 0.22.0
>
> Attachments: HADOOP-6374.patch
>
>
> The recent change to mapred-queues.xml that causes many mapreduce tests to break unless you delete conf/mapred-queues.xml out of your build tree is bad. We need to make sure that nothing in conf is used in the unit tests. One potential solution is to copy the templates into build/test/conf and use that instead.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6374) JUnit tests should never depend on
anything in conf
Posted by "Anatoli Fomenko (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12798723#action_12798723 ]
Anatoli Fomenko commented on HADOOP-6374:
-----------------------------------------
Please review the submitted patch. Thanks.
> JUnit tests should never depend on anything in conf
> ---------------------------------------------------
>
> Key: HADOOP-6374
> URL: https://issues.apache.org/jira/browse/HADOOP-6374
> Project: Hadoop Common
> Issue Type: Bug
> Components: test
> Reporter: Owen O'Malley
> Assignee: Anatoli Fomenko
> Priority: Blocker
> Attachments: HADOOP-6374.patch
>
>
> The recent change to mapred-queues.xml that causes many mapreduce tests to break unless you delete conf/mapred-queues.xml out of your build tree is bad. We need to make sure that nothing in conf is used in the unit tests. One potential solution is to copy the templates into build/test/conf and use that instead.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6374) JUnit tests should never depend on
anything in conf
Posted by "Anatoli Fomenko (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12802651#action_12802651 ]
Anatoli Fomenko commented on HADOOP-6374:
-----------------------------------------
Please review the submitted patch. Thanks.
> JUnit tests should never depend on anything in conf
> ---------------------------------------------------
>
> Key: HADOOP-6374
> URL: https://issues.apache.org/jira/browse/HADOOP-6374
> Project: Hadoop Common
> Issue Type: Bug
> Components: test
> Reporter: Owen O'Malley
> Assignee: Anatoli Fomenko
> Priority: Blocker
> Attachments: HADOOP-6374.patch
>
>
> The recent change to mapred-queues.xml that causes many mapreduce tests to break unless you delete conf/mapred-queues.xml out of your build tree is bad. We need to make sure that nothing in conf is used in the unit tests. One potential solution is to copy the templates into build/test/conf and use that instead.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.