[jira] [Work logged] (GOBBLIN-1843) Utility for detecting non optional unions should convert dataset urn to hive compatible format

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/GOBBLIN-1843?focusedWorklogId=865631&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-865631 ]

ASF GitHub Bot logged work on GOBBLIN-1843:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 14/Jun/23 21:39
            Start Date: 14/Jun/23 21:39
    Worklog Time Spent: 10m 
      Work Description: homatthew opened a new pull request, #3705:
URL: https://github.com/apache/gobblin/pull/3705

   Dear Gobblin maintainers,
   
   Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
   
   
   ### JIRA
   - [X] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references them in the PR title. For example, "[GOBBLIN-1843] My Gobblin PR"
       - https://issues.apache.org/jira/browse/GOBBLIN-1843
   
   
   ### Description
   - [X] Here are some details about my PR, including screenshots (if applicable):
   Datasets with URN that have a `-` will be represented in Hive with an `_`.  Failing to do so will mean the code will fail to pull up the correct hive table
   
   This code will replace all '-' with '_' before querying hive. We do not need to consider lower / uppercase because hive is case insensitive
   
   ### Tests
   - [X] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   <img width="464" alt="image" src="https://github.com/apache/gobblin/assets/35702680/a30b9ef5-4d9f-4b7d-a5d6-a5d7ce9ad18a">
   
   
   ### Commits
   - [X] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
       1. Subject is separated from body by a blank line
       2. Subject is limited to 50 characters
       3. Subject does not end with a period
       4. Subject uses the imperative mood ("add", not "adding")
       5. Body wraps at 72 characters
       6. Body explains "what" and "why", not "how"
   
   




Issue Time Tracking
-------------------

            Worklog Id:     (was: 865631)
    Remaining Estimate: 0h
            Time Spent: 10m

> Utility for detecting non optional unions should convert dataset urn to hive compatible format
> ----------------------------------------------------------------------------------------------
>
>                 Key: GOBBLIN-1843
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-1843
>             Project: Apache Gobblin
>          Issue Type: Improvement
>            Reporter: Matthew Ho
>            Priority: Major
>          Time Spent: 10m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)