You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/02/03 04:05:09 UTC

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #5399: tools/Config.mk: Define NDEBUG if CONFIG_DEBUG_ASSERTIONS isn't defined

xiaoxiang781216 commented on pull request #5399:
URL: https://github.com/apache/incubator-nuttx/pull/5399#issuecomment-1028581598


   > i feel this is too automatic.
   > 
   > CONFIG_DEBUG_ASSERTIONS is about NuttX specific DEBUGASSERT.
   > 
   
   Why do you think it isn't a good idea to make assert same as DEBUGASSERT by default if user can still modify the behavior by CFLAGS += -DNDEBUG or CLFAGS += -UNDEBUG?
   
   > NDEBUG is in the standards and about assert. it's usually a per-app thing. some apps might be even broken with NDEBUG.
   
   app could overwrite it by CFLAGS += -UNDEBUG.
   
   > i want to be able to control DEBUGASSERT and assert separately.
   
   so you want to add a new Kconfig?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org