You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Zhitao Li <zh...@gmail.com> on 2017/05/15 18:02:43 UTC
Review Request 59279: Uses temp dir for docker and appc stores in
test.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59279/
-----------------------------------------------------------
Review request for mesos, Anand Mazumdar, Gilbert Song, and Jie Yu.
Bugs: MESOS-7381
https://issues.apache.org/jira/browse/MESOS-7381
Repository: mesos
Description
-------
Certain tests which relies on docker/appc stores to store images could be flaky when certain changes to the store code is chaging.
This patch moves the usage of these flags to the temporary directory created for each test case, so they do not affect each other.
Diffs
-----
src/tests/mesos.cpp a79ec62d6b8354a97a50533dc66e04c1afc4bef6
Diff: https://reviews.apache.org/r/59279/diff/1/
Testing
-------
Ran through all tests.
Thanks,
Zhitao Li
Re: Review Request 59279: Uses temp dir for docker and appc stores in
test.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59279/#review175025
-----------------------------------------------------------
Fix it, then Ship it!
src/tests/mesos.cpp
Lines 180 (patched)
<https://reviews.apache.org/r/59279/#comment248344>
no need for `mesos` here in the middle.
- Jie Yu
On May 15, 2017, 6:02 p.m., Zhitao Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59279/
> -----------------------------------------------------------
>
> (Updated May 15, 2017, 6:02 p.m.)
>
>
> Review request for mesos, Anand Mazumdar, Gilbert Song, and Jie Yu.
>
>
> Bugs: MESOS-7381
> https://issues.apache.org/jira/browse/MESOS-7381
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Certain tests which relies on docker/appc stores to store images could be flaky when certain changes to the store code is chaging.
>
> This patch moves the usage of these flags to the temporary directory created for each test case, so they do not affect each other.
>
>
> Diffs
> -----
>
> src/tests/mesos.cpp a79ec62d6b8354a97a50533dc66e04c1afc4bef6
>
>
> Diff: https://reviews.apache.org/r/59279/diff/1/
>
>
> Testing
> -------
>
> Ran through all tests.
>
>
> Thanks,
>
> Zhitao Li
>
>
Re: Review Request 59279: Uses temp dir for docker and appc stores in
test.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59279/#review175079
-----------------------------------------------------------
Patch looks great!
Reviews applied: [59279]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On May 15, 2017, 6:02 p.m., Zhitao Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59279/
> -----------------------------------------------------------
>
> (Updated May 15, 2017, 6:02 p.m.)
>
>
> Review request for mesos, Anand Mazumdar, Gilbert Song, and Jie Yu.
>
>
> Bugs: MESOS-7381
> https://issues.apache.org/jira/browse/MESOS-7381
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Certain tests which relies on docker/appc stores to store images could be flaky when certain changes to the store code is chaging.
>
> This patch moves the usage of these flags to the temporary directory created for each test case, so they do not affect each other.
>
>
> Diffs
> -----
>
> src/tests/mesos.cpp a79ec62d6b8354a97a50533dc66e04c1afc4bef6
>
>
> Diff: https://reviews.apache.org/r/59279/diff/1/
>
>
> Testing
> -------
>
> Ran through all tests.
>
>
> Thanks,
>
> Zhitao Li
>
>
Re: Review Request 59279: Uses temp dir for docker and appc stores in
test.
Posted by Zhitao Li <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59279/
-----------------------------------------------------------
(Updated May 16, 2017, 4:39 p.m.)
Review request for mesos, Anand Mazumdar, Gilbert Song, and Jie Yu.
Bugs: MESOS-7381
https://issues.apache.org/jira/browse/MESOS-7381
Repository: mesos
Description (updated)
-------
Uses temp dir for docker and appc stores in test.
Diffs (updated)
-----
src/tests/mesos.cpp a79ec62d6b8354a97a50533dc66e04c1afc4bef6
Diff: https://reviews.apache.org/r/59279/diff/2/
Changes: https://reviews.apache.org/r/59279/diff/1-2/
Testing
-------
Ran through all tests.
Thanks,
Zhitao Li