You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Michael Park <mc...@gmail.com> on 2014/10/05 09:16:54 UTC
Re: Review Request 26069: Introduce ClangFormat to Mesos.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26069/
-----------------------------------------------------------
(Updated Oct. 5, 2014, 7:16 a.m.)
Review request for mesos, Benjamin Hindman, Cody Maloney, Dominic Hamon, and Timothy Chen.
Changes
-------
Remove trailing whitespace
Bugs: MESOS-1291
https://issues.apache.org/jira/browse/MESOS-1291
Repository: mesos-git
Description
-------
We spend way too much of our time formatting, not to mention the amount of time wasted during the review cycle to address style issues. Let’s get ClangFormat to help us!
If you don't know what ClangFormat is or how it works, take a look at the Chandler Carruth's [live demo](http://www.youtube.com/watch?v=uvddFPavYZQ#t=23m28s) from 23m 28s to 33m 27s.
Further details and analysis are available [here](https://docs.google.com/document/d/13mC3CuG89x0-4mGUD1NK-M0mYsqvEcZ-ttx9CRmAXq8/edit?usp=sharing).
Diffs (updated)
-----
.clang-format PRE-CREATION
support/clang-format PRE-CREATION
Diff: https://reviews.apache.org/r/26069/diff/
Testing
-------
Refer to the __Sample Diff__ section in the [Google Doc](https://docs.google.com/document/d/13mC3CuG89x0-4mGUD1NK-M0mYsqvEcZ-ttx9CRmAXq8/edit?usp=sharing)
Thanks,
Michael Park
Re: Review Request 26069: Introduce ClangFormat to Mesos.
Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26069/#review59461
-----------------------------------------------------------
Ship it!
Ship It!
- Timothy Chen
On Oct. 5, 2014, 7:16 a.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26069/
> -----------------------------------------------------------
>
> (Updated Oct. 5, 2014, 7:16 a.m.)
>
>
> Review request for mesos, Benjamin Hindman, Cody Maloney, Dominic Hamon, and Timothy Chen.
>
>
> Bugs: MESOS-1291
> https://issues.apache.org/jira/browse/MESOS-1291
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> We spend way too much of our time formatting, not to mention the amount of time wasted during the review cycle to address style issues. Let’s get ClangFormat to help us!
>
> If you don't know what ClangFormat is or how it works, take a look at the Chandler Carruth's [live demo](http://www.youtube.com/watch?v=uvddFPavYZQ#t=23m28s) from 23m 28s to 33m 27s.
>
> Further details and analysis are available [here](https://docs.google.com/document/d/13mC3CuG89x0-4mGUD1NK-M0mYsqvEcZ-ttx9CRmAXq8/edit?usp=sharing).
>
>
> Diffs
> -----
>
> .clang-format PRE-CREATION
> support/clang-format PRE-CREATION
>
> Diff: https://reviews.apache.org/r/26069/diff/
>
>
> Testing
> -------
>
> Refer to the __Sample Diff__ section in the [Google Doc](https://docs.google.com/document/d/13mC3CuG89x0-4mGUD1NK-M0mYsqvEcZ-ttx9CRmAXq8/edit?usp=sharing)
>
>
> Thanks,
>
> Michael Park
>
>
Re: Review Request 26069: Introduce ClangFormat to Mesos.
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26069/#review57414
-----------------------------------------------------------
Ship it!
I think we should get this in and then iterate on it. At least this gives people the option to use clang-format and get a mostly correct style, and maybe we can determine that the automation is so useful that we change the style guide to match what we can automate.
- Dominic Hamon
On Oct. 5, 2014, 12:16 a.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26069/
> -----------------------------------------------------------
>
> (Updated Oct. 5, 2014, 12:16 a.m.)
>
>
> Review request for mesos, Benjamin Hindman, Cody Maloney, Dominic Hamon, and Timothy Chen.
>
>
> Bugs: MESOS-1291
> https://issues.apache.org/jira/browse/MESOS-1291
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> We spend way too much of our time formatting, not to mention the amount of time wasted during the review cycle to address style issues. Let’s get ClangFormat to help us!
>
> If you don't know what ClangFormat is or how it works, take a look at the Chandler Carruth's [live demo](http://www.youtube.com/watch?v=uvddFPavYZQ#t=23m28s) from 23m 28s to 33m 27s.
>
> Further details and analysis are available [here](https://docs.google.com/document/d/13mC3CuG89x0-4mGUD1NK-M0mYsqvEcZ-ttx9CRmAXq8/edit?usp=sharing).
>
>
> Diffs
> -----
>
> .clang-format PRE-CREATION
> support/clang-format PRE-CREATION
>
> Diff: https://reviews.apache.org/r/26069/diff/
>
>
> Testing
> -------
>
> Refer to the __Sample Diff__ section in the [Google Doc](https://docs.google.com/document/d/13mC3CuG89x0-4mGUD1NK-M0mYsqvEcZ-ttx9CRmAXq8/edit?usp=sharing)
>
>
> Thanks,
>
> Michael Park
>
>
Re: Review Request 26069: Introduce ClangFormat to Mesos.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26069/#review55472
-----------------------------------------------------------
Patch looks great!
Reviews applied: [26069]
All tests passed.
- Mesos ReviewBot
On Oct. 5, 2014, 7:16 a.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26069/
> -----------------------------------------------------------
>
> (Updated Oct. 5, 2014, 7:16 a.m.)
>
>
> Review request for mesos, Benjamin Hindman, Cody Maloney, Dominic Hamon, and Timothy Chen.
>
>
> Bugs: MESOS-1291
> https://issues.apache.org/jira/browse/MESOS-1291
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> We spend way too much of our time formatting, not to mention the amount of time wasted during the review cycle to address style issues. Let’s get ClangFormat to help us!
>
> If you don't know what ClangFormat is or how it works, take a look at the Chandler Carruth's [live demo](http://www.youtube.com/watch?v=uvddFPavYZQ#t=23m28s) from 23m 28s to 33m 27s.
>
> Further details and analysis are available [here](https://docs.google.com/document/d/13mC3CuG89x0-4mGUD1NK-M0mYsqvEcZ-ttx9CRmAXq8/edit?usp=sharing).
>
>
> Diffs
> -----
>
> .clang-format PRE-CREATION
> support/clang-format PRE-CREATION
>
> Diff: https://reviews.apache.org/r/26069/diff/
>
>
> Testing
> -------
>
> Refer to the __Sample Diff__ section in the [Google Doc](https://docs.google.com/document/d/13mC3CuG89x0-4mGUD1NK-M0mYsqvEcZ-ttx9CRmAXq8/edit?usp=sharing)
>
>
> Thanks,
>
> Michael Park
>
>