You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "yliou (via GitHub)" <gi...@apache.org> on 2023/09/06 02:43:48 UTC

[GitHub] [spark] yliou commented on a diff in pull request #40502: [SPARK-42829] [UI] add repeat identifier to cached RDD on stage page

yliou commented on code in PR #40502:
URL: https://github.com/apache/spark/pull/40502#discussion_r1316647094


##########
core/src/main/scala/org/apache/spark/ui/scope/RDDOperationGraph.scala:
##########
@@ -221,6 +226,24 @@ private[spark] object RDDOperationGraph extends Logging {
     RDDOperationGraph(internalEdges.toSeq, outgoingEdges.toSeq, incomingEdges.toSeq, rootCluster)
   }
 
+  def getRepeatIdentifier(node: RDDOperationNode): String = {

Review Comment:
   I don't see how we can add that easily in the code given that RDDOperationGraph doesn't have a SqlConf instance to read a config.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org