[GitHub] rabbah commented on a change in pull request #3215: adding namePrefix config to ContainerArgsConfig

[GitBox <gi...@apache.org>]

rabbah commented on a change in pull request #3215: adding namePrefix config to ContainerArgsConfig
URL: https://github.com/apache/incubator-openwhisk/pull/3215#discussion_r165653638
 
 

 ##########
 File path: core/invoker/src/main/scala/whisk/core/invoker/Invoker.scala
 ##########
 @@ -130,8 +130,7 @@ object Invoker {
         if (config.zookeeperHosts.startsWith(":") || config.zookeeperHosts.endsWith(":")) {
           abort(s"Must provide valid zookeeper host and port to use dynamicId assignment (${config.zookeeperHosts})")
         }
-        val invokerName = cmdLineArgs.name.getOrElse(config.invokerName)
-        if (invokerName.trim.isEmpty) {
+        if (invokerName.isEmpty || invokerName.get.trim.isEmpty) {
 
 Review comment:
   this check is only done when the id is missing - so it is possible to have a name that is an empty (`""` or `" "`) string accepted as the invoker name (only `Option(null) == None`).
   
   i don't think that's intended.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services