[jira] [Commented] (SLIDER-664) Add support for custom commands through the agent

["Billie Rinaldi (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SLIDER-664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15134621#comment-15134621 ] 

Billie Rinaldi commented on SLIDER-664:
---------------------------------------

Hi [~fengyongshe], thanks for the patch!  I am beginning a technical review of the patch, but here are a few logistical comments.  There appear to be some problems with applying the patch to develop, which is that the patch shows changes for files that don't exist yet: ActionOperateArgs.java and ActionOperateContainers.java.  It looks like you haven't included all of the changes you made, i.e. the initial creation of these files.

In at least 3 places you have author information for new classes and methods you are creating.  At Apache we do not use author tags, so these should be removed.  Also, any new Java files you create should have the following license header:
{noformat}
/*
 * Licensed to the Apache Software Foundation (ASF) under one
 * or more contributor license agreements.  See the NOTICE file
 * distributed with this work for additional information
 * regarding copyright ownership.  The ASF licenses this file
 * to you under the Apache License, Version 2.0 (the
 * "License"); you may not use this file except in compliance
 * with the License.  You may obtain a copy of the License at
 *
 *     http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS,
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */
{noformat}

> Add support for custom commands through the agent
> -------------------------------------------------
>
>                 Key: SLIDER-664
>                 URL: https://issues.apache.org/jira/browse/SLIDER-664
>             Project: Slider
>          Issue Type: Improvement
>          Components: agent, agent-provider, app-package
>    Affects Versions: Slider 0.60
>            Reporter: Sumit Mohanty
>            Assignee: fengyongshe
>            Priority: Critical
>         Attachments: fengyogshe-add-support-for-custom-commands-1.patch
>
>
> Slider application package allows defining of arbitrary commands. However, there is no way to execute these arbitrary commands using the Slider command line. A basic approach can be as follows:
> * App developer defines a custom command say "COMMAND" and a python function is mapped to this command in the same way as "START" or "INSTALL".
> * Using Slider-Agent the command can be issued against specific containers identified by the container id
> * While issuing commands, optional properties (name-value pairs) may be provided
> * Once command is issued a command id is returned that can be used to retrieve the command result
> * Command execution or the result is not persisted by Slider - so it is a best effort execution



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)