You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Yong Tang <yo...@outlook.com> on 2016/04/21 04:27:25 UTC
Review Request 46470: Change to explicit case statements (`UNKNOWN`)
for authorization.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46470/
-----------------------------------------------------------
Review request for mesos, Adam B, Ben Mahler, and Vinod Kone.
Bugs: MESOS-5031
https://issues.apache.org/jira/browse/MESOS-5031
Repository: mesos
Description
-------
This patch changes from `default` statement to explicit case
statement (`UNKNOWN`) so that complier could help catching all
switches when new enums are introduced in the future.
This patch is related to:
https://reviews.apache.org/r/45342/ (MESOS-5031)
Diffs
-----
src/authorizer/local/authorizer.cpp c744a16041c2466d3839a37fbee2bf86887bf4e1
Diff: https://reviews.apache.org/r/46470/diff/
Testing
-------
make check (Ubuntu 14.04)
Thanks,
Yong Tang
Re: Review Request 46470: Change to explicit case statements
(`UNKNOWN`) for authorization.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46470/#review130050
-----------------------------------------------------------
Patch looks great!
Reviews applied: [46364, 46470]
Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh
- Mesos ReviewBot
On April 22, 2016, 5:29 a.m., Yong Tang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46470/
> -----------------------------------------------------------
>
> (Updated April 22, 2016, 5:29 a.m.)
>
>
> Review request for mesos, Adam B, Ben Mahler, and Vinod Kone.
>
>
> Bugs: MESOS-5031
> https://issues.apache.org/jira/browse/MESOS-5031
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch changes from `default` statement to explicit case
> statement (`UNKNOWN`) so that complier could help catching all
> switches when new enums are introduced in the future.
>
> This patch is related to:
> https://reviews.apache.org/r/45342/ (MESOS-5031)
>
>
> Diffs
> -----
>
> src/authorizer/local/authorizer.cpp c744a16041c2466d3839a37fbee2bf86887bf4e1
>
> Diff: https://reviews.apache.org/r/46470/diff/
>
>
> Testing
> -------
>
> make check (Ubuntu 14.04)
>
>
> Thanks,
>
> Yong Tang
>
>
Re: Review Request 46470: Change to explicit case statements
(`UNKNOWN`) for authorization.
Posted by Yong Tang <yo...@outlook.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46470/
-----------------------------------------------------------
(Updated April 22, 2016, 5:29 a.m.)
Review request for mesos, Adam B, Ben Mahler, and Vinod Kone.
Changes
-------
Update review request from https://reviews.apache.org/r/46364/
Bugs: MESOS-5031
https://issues.apache.org/jira/browse/MESOS-5031
Repository: mesos
Description
-------
This patch changes from `default` statement to explicit case
statement (`UNKNOWN`) so that complier could help catching all
switches when new enums are introduced in the future.
This patch is related to:
https://reviews.apache.org/r/45342/ (MESOS-5031)
Diffs (updated)
-----
src/authorizer/local/authorizer.cpp c744a16041c2466d3839a37fbee2bf86887bf4e1
Diff: https://reviews.apache.org/r/46470/diff/
Testing
-------
make check (Ubuntu 14.04)
Thanks,
Yong Tang
Re: Review Request 46470: Change to explicit case statements
(`UNKNOWN`) for authorization.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46470/#review129853
-----------------------------------------------------------
Patch looks great!
Reviews applied: [46364, 46470]
Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh
- Mesos ReviewBot
On April 21, 2016, 2:27 a.m., Yong Tang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46470/
> -----------------------------------------------------------
>
> (Updated April 21, 2016, 2:27 a.m.)
>
>
> Review request for mesos, Adam B, Ben Mahler, and Vinod Kone.
>
>
> Bugs: MESOS-5031
> https://issues.apache.org/jira/browse/MESOS-5031
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch changes from `default` statement to explicit case
> statement (`UNKNOWN`) so that complier could help catching all
> switches when new enums are introduced in the future.
>
> This patch is related to:
> https://reviews.apache.org/r/45342/ (MESOS-5031)
>
>
> Diffs
> -----
>
> src/authorizer/local/authorizer.cpp c744a16041c2466d3839a37fbee2bf86887bf4e1
>
> Diff: https://reviews.apache.org/r/46470/diff/
>
>
> Testing
> -------
>
> make check (Ubuntu 14.04)
>
>
> Thanks,
>
> Yong Tang
>
>
Re: Review Request 46470: Change to explicit case statements
(`UNKNOWN`) for authorization.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46470/#review129954
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On April 21, 2016, 2:27 a.m., Yong Tang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46470/
> -----------------------------------------------------------
>
> (Updated April 21, 2016, 2:27 a.m.)
>
>
> Review request for mesos, Adam B, Ben Mahler, and Vinod Kone.
>
>
> Bugs: MESOS-5031
> https://issues.apache.org/jira/browse/MESOS-5031
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch changes from `default` statement to explicit case
> statement (`UNKNOWN`) so that complier could help catching all
> switches when new enums are introduced in the future.
>
> This patch is related to:
> https://reviews.apache.org/r/45342/ (MESOS-5031)
>
>
> Diffs
> -----
>
> src/authorizer/local/authorizer.cpp c744a16041c2466d3839a37fbee2bf86887bf4e1
>
> Diff: https://reviews.apache.org/r/46470/diff/
>
>
> Testing
> -------
>
> make check (Ubuntu 14.04)
>
>
> Thanks,
>
> Yong Tang
>
>