You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by "AngersZhuuuu (via GitHub)" <gi...@apache.org> on 2024/02/28 04:05:33 UTC
[PR] [CELEBORN-1292] Remove app level metrics from worker and master [incubator-celeborn]
AngersZhuuuu opened a new pull request, #2342:
URL: https://github.com/apache/incubator-celeborn/pull/2342
<!--
Thanks for sending a pull request! Here are some tips for you:
- Make sure the PR title start w/ a JIRA ticket, e.g. '[CELEBORN-XXXX] Your PR title ...'.
- Be sure to keep the PR description updated to reflect all changes.
- Please write your PR title to summarize what this PR proposes.
- If possible, provide a concise example to reproduce the issue for a faster review.
-->
### What changes were proposed in this pull request?
Master side calculate sub resource consumption occupy cpu cause rpc time out and miss prometheus metrics
<img width="1781" alt="截屏2024-02-28 12 04 19" src="https://github.com/apache/incubator-celeborn/assets/46485123/ba49a4ac-ec49-4234-8758-c0db9242abf6">
Worker side generate too much metrics data
### Why are the changes needed?
Fix performance issue
### Does this PR introduce _any_ user-facing change?
Remove app level metrics
### How was this patch tested?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1292] Remove app level metrics from worker and master [incubator-celeborn]
Posted by "AngersZhuuuu (via GitHub)" <gi...@apache.org>.
AngersZhuuuu commented on code in PR #2342:
URL: https://github.com/apache/incubator-celeborn/pull/2342#discussion_r1505327228
##########
master/src/main/scala/org/apache/celeborn/service/deploy/master/Master.scala:
##########
@@ -970,10 +944,6 @@ private[celeborn] class Master(
private def handleResourceConsumption(userIdentifier: UserIdentifier): ResourceConsumption = {
val userResourceConsumption = computeUserResourceConsumption(userIdentifier)
gaugeResourceConsumption(userIdentifier)
- val subResourceConsumptions = userResourceConsumption.subResourceConsumptions
- if (CollectionUtils.isNotEmpty(subResourceConsumptions)) {
- subResourceConsumptions.asScala.keys.foreach { gaugeResourceConsumption(userIdentifier, _) }
- }
Review Comment:
remove app level metrics
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1292] Remove app level metrics from worker and master [incubator-celeborn]
Posted by "AngersZhuuuu (via GitHub)" <gi...@apache.org>.
AngersZhuuuu commented on PR #2342:
URL: https://github.com/apache/incubator-celeborn/pull/2342#issuecomment-1968535833
Merge to main(v0.5.0) and branch-0.4(v0.4.1)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1292] Remove app level metrics from worker and master [incubator-celeborn]
Posted by "AngersZhuuuu (via GitHub)" <gi...@apache.org>.
AngersZhuuuu closed pull request #2342: [CELEBORN-1292] Remove app level metrics from worker and master
URL: https://github.com/apache/incubator-celeborn/pull/2342
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1292] Remove app level metrics from worker and master [incubator-celeborn]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #2342:
URL: https://github.com/apache/incubator-celeborn/pull/2342#issuecomment-1968188585
## [Codecov](https://app.codecov.io/gh/apache/incubator-celeborn/pull/2342?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
All modified and coverable lines are covered by tests :white_check_mark:
> Project coverage is 48.77%. Comparing base [(`f4bc87e`)](https://app.codecov.io/gh/apache/incubator-celeborn/commit/f4bc87e6dbe6bb280d0e5771abad0e9353597c1e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`6d05ec7`)](https://app.codecov.io/gh/apache/incubator-celeborn/pull/2342?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
> Report is 7 commits behind head on main.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #2342 +/- ##
==========================================
- Coverage 48.87% 48.77% -0.09%
==========================================
Files 207 207
Lines 12946 12939 -7
Branches 1113 1113
==========================================
- Hits 6326 6310 -16
- Misses 6215 6221 +6
- Partials 405 408 +3
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/incubator-celeborn/pull/2342?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1292] Remove app level metrics from worker and master [incubator-celeborn]
Posted by "AngersZhuuuu (via GitHub)" <gi...@apache.org>.
AngersZhuuuu commented on code in PR #2342:
URL: https://github.com/apache/incubator-celeborn/pull/2342#discussion_r1505327080
##########
master/src/main/scala/org/apache/celeborn/service/deploy/master/Master.scala:
##########
@@ -1024,13 +994,12 @@ private[celeborn] class Master(
}
}
+ // TODO: Support calculate topN app resource consumption.
private def computeUserResourceConsumption(
userIdentifier: UserIdentifier): ResourceConsumption = {
- val (resourceConsumption, subResourceConsumptions) = statusSystem.workers.asScala.flatMap {
+ val resourceConsumption = statusSystem.workers.asScala.flatMap {
workerInfo => workerInfo.userResourceConsumption.asScala.get(userIdentifier)
- }.foldRight((ResourceConsumption(0, 0, 0, 0), Map.empty[String, ResourceConsumption]))(
- _ addWithSubResourceConsumptions _)
- resourceConsumption.subResourceConsumptions = subResourceConsumptions.asJava
+ }.foldRight(ResourceConsumption(0, 0, 0, 0))(_ add _)
Review Comment:
Remove calculate sub resource consumption since 90%+ cpu in this
##########
worker/src/main/scala/org/apache/celeborn/service/deploy/worker/Worker.scala:
##########
@@ -538,10 +538,6 @@ private[celeborn] class Worker(
workerInfo.updateThenGetUserResourceConsumption(resourceConsumptionSnapshot.asJava)
resourceConsumptionSnapshot.foreach { case (userIdentifier, userResourceConsumption) =>
gaugeResourceConsumption(userIdentifier)
- val subResourceConsumptions = userResourceConsumption.subResourceConsumptions
- if (CollectionUtils.isNotEmpty(subResourceConsumptions)) {
- subResourceConsumptions.asScala.keys.foreach { gaugeResourceConsumption(userIdentifier, _) }
- }
Review Comment:
Remove app level metrics
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org