You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "ppalaga (via GitHub)" <gi...@apache.org> on 2023/09/06 14:06:01 UTC
[GitHub] [camel-quarkus] ppalaga opened a new pull request, #5271: Test REST to SOAP bridge scenario
ppalaga opened a new pull request, #5271:
URL: https://github.com/apache/camel-quarkus/pull/5271
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] aldettinger commented on a diff in pull request #5271: Test REST to SOAP bridge scenario
Posted by "aldettinger (via GitHub)" <gi...@apache.org>.
aldettinger commented on code in PR #5271:
URL: https://github.com/apache/camel-quarkus/pull/5271#discussion_r1317374758
##########
integration-test-groups/cxf-soap/cxf-soap-rest/src/main/java/org/apache/camel/quarkus/component/cxf/soap/rest/it/CxfSoapRestRoutes.java:
##########
@@ -0,0 +1,88 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.camel.quarkus.component.cxf.soap.rest.it;
+
+import jakarta.enterprise.context.ApplicationScoped;
+import jakarta.enterprise.context.SessionScoped;
+import jakarta.enterprise.inject.Produces;
+import jakarta.inject.Inject;
+import jakarta.inject.Named;
+import org.apache.camel.builder.RouteBuilder;
+import org.apache.camel.component.cxf.jaxws.CxfEndpoint;
+import org.apache.camel.model.rest.RestBindingMode;
+import org.apache.cxf.ext.logging.LoggingFeature;
+import org.eclipse.microprofile.config.inject.ConfigProperty;
+import org.jboss.eap.quickstarts.wscalculator.calculator.AddOperands;
+import org.jboss.eap.quickstarts.wscalculator.calculator.CalculatorService;
+import org.jboss.eap.quickstarts.wscalculator.calculator.Result;
+
+@ApplicationScoped
+public class CxfSoapRestRoutes extends RouteBuilder {
+
+ @Inject
+ @Named("loggingFeatureRest")
+ LoggingFeature loggingFeatureRest;
+
+ @ConfigProperty(name = "camel-quarkus.it.calculator.baseUri")
+ String serviceBaseUri;
+
+ @Override
+ public void configure() {
+
+ rest("cxf-soap-rest").bindingMode(RestBindingMode.json)
+ .post("post")
+ .type(AddOperands.class)
+ .outType(Result.class)
+ .to("direct:headersPropagation");
+ from("direct:headersPropagation")
+ .process(exchange -> exchange.getIn().setBody(exchange.getIn().getBody(AddOperands.class).getArg0()))
+ .to("cxf:bean:soapClientRestEndpoint?defaultOperationName=addOperands")
+ .setHeader("Content-Type", constant("application/json"))
+ .setBody(e -> e.getMessage().getBody(Object[].class)[0]);
+
+ }
+
+ @Produces
+ @ApplicationScoped
+ @Named("loggingFeatureRest")
+ public LoggingFeature loggingFeatureRest() {
+ final LoggingFeature result = new LoggingFeature();
+ result.setPrettyLogging(true);
+ return result;
+ }
+
+ @Produces
+ @SessionScoped
Review Comment:
Not used to `@SessionScoped`, there is doc mentioning it's only available for quarkus-undertow:
https://quarkus.io/guides/cdi#bean-scope-available
Maybe the doc is wrong.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] aldettinger commented on pull request #5271: Test REST to SOAP bridge scenario
Posted by "aldettinger (via GitHub)" <gi...@apache.org>.
aldettinger commented on PR #5271:
URL: https://github.com/apache/camel-quarkus/pull/5271#issuecomment-1708465975
Shouldn't be that bad anyway: knative is more an internal thing if I remember well ?
Also not sure about the why... maybe using provided scope could workaround and be less intrusive, not sure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] aldettinger commented on a diff in pull request #5271: Test REST to SOAP bridge scenario
Posted by "aldettinger (via GitHub)" <gi...@apache.org>.
aldettinger commented on code in PR #5271:
URL: https://github.com/apache/camel-quarkus/pull/5271#discussion_r1317706956
##########
integration-test-groups/cxf-soap/cxf-soap-rest/src/main/java/org/apache/camel/quarkus/component/cxf/soap/rest/it/CxfSoapRestRoutes.java:
##########
@@ -0,0 +1,88 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.camel.quarkus.component.cxf.soap.rest.it;
+
+import jakarta.enterprise.context.ApplicationScoped;
+import jakarta.enterprise.context.SessionScoped;
+import jakarta.enterprise.inject.Produces;
+import jakarta.inject.Inject;
+import jakarta.inject.Named;
+import org.apache.camel.builder.RouteBuilder;
+import org.apache.camel.component.cxf.jaxws.CxfEndpoint;
+import org.apache.camel.model.rest.RestBindingMode;
+import org.apache.cxf.ext.logging.LoggingFeature;
+import org.eclipse.microprofile.config.inject.ConfigProperty;
+import org.jboss.eap.quickstarts.wscalculator.calculator.AddOperands;
+import org.jboss.eap.quickstarts.wscalculator.calculator.CalculatorService;
+import org.jboss.eap.quickstarts.wscalculator.calculator.Result;
+
+@ApplicationScoped
+public class CxfSoapRestRoutes extends RouteBuilder {
+
+ @Inject
+ @Named("loggingFeatureRest")
+ LoggingFeature loggingFeatureRest;
+
+ @ConfigProperty(name = "camel-quarkus.it.calculator.baseUri")
+ String serviceBaseUri;
+
+ @Override
+ public void configure() {
+
+ rest("cxf-soap-rest").bindingMode(RestBindingMode.json)
+ .post("post")
+ .type(AddOperands.class)
+ .outType(Result.class)
+ .to("direct:headersPropagation");
+ from("direct:headersPropagation")
+ .process(exchange -> exchange.getIn().setBody(exchange.getIn().getBody(AddOperands.class).getArg0()))
+ .to("cxf:bean:soapClientRestEndpoint?defaultOperationName=addOperands")
+ .setHeader("Content-Type", constant("application/json"))
+ .setBody(e -> e.getMessage().getBody(Object[].class)[0]);
+
+ }
+
+ @Produces
+ @ApplicationScoped
+ @Named("loggingFeatureRest")
+ public LoggingFeature loggingFeatureRest() {
+ final LoggingFeature result = new LoggingFeature();
+ result.setPrettyLogging(true);
+ return result;
+ }
+
+ @Produces
+ @SessionScoped
Review Comment:
Many thanks for explanation @ppalaga. No strong advice there, if it's working then let it be.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ppalaga commented on a diff in pull request #5271: Test REST to SOAP bridge scenario
Posted by "ppalaga (via GitHub)" <gi...@apache.org>.
ppalaga commented on code in PR #5271:
URL: https://github.com/apache/camel-quarkus/pull/5271#discussion_r1317578156
##########
integration-test-groups/cxf-soap/cxf-soap-rest/src/main/java/org/apache/camel/quarkus/component/cxf/soap/rest/it/CxfSoapRestRoutes.java:
##########
@@ -0,0 +1,88 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.camel.quarkus.component.cxf.soap.rest.it;
+
+import jakarta.enterprise.context.ApplicationScoped;
+import jakarta.enterprise.context.SessionScoped;
+import jakarta.enterprise.inject.Produces;
+import jakarta.inject.Inject;
+import jakarta.inject.Named;
+import org.apache.camel.builder.RouteBuilder;
+import org.apache.camel.component.cxf.jaxws.CxfEndpoint;
+import org.apache.camel.model.rest.RestBindingMode;
+import org.apache.cxf.ext.logging.LoggingFeature;
+import org.eclipse.microprofile.config.inject.ConfigProperty;
+import org.jboss.eap.quickstarts.wscalculator.calculator.AddOperands;
+import org.jboss.eap.quickstarts.wscalculator.calculator.CalculatorService;
+import org.jboss.eap.quickstarts.wscalculator.calculator.Result;
+
+@ApplicationScoped
+public class CxfSoapRestRoutes extends RouteBuilder {
+
+ @Inject
+ @Named("loggingFeatureRest")
+ LoggingFeature loggingFeatureRest;
+
+ @ConfigProperty(name = "camel-quarkus.it.calculator.baseUri")
+ String serviceBaseUri;
+
+ @Override
+ public void configure() {
+
+ rest("cxf-soap-rest").bindingMode(RestBindingMode.json)
+ .post("post")
+ .type(AddOperands.class)
+ .outType(Result.class)
+ .to("direct:headersPropagation");
+ from("direct:headersPropagation")
+ .process(exchange -> exchange.getIn().setBody(exchange.getIn().getBody(AddOperands.class).getArg0()))
+ .to("cxf:bean:soapClientRestEndpoint?defaultOperationName=addOperands")
+ .setHeader("Content-Type", constant("application/json"))
+ .setBody(e -> e.getMessage().getBody(Object[].class)[0]);
+
+ }
+
+ @Produces
+ @ApplicationScoped
+ @Named("loggingFeatureRest")
+ public LoggingFeature loggingFeatureRest() {
+ final LoggingFeature result = new LoggingFeature();
+ result.setPrettyLogging(true);
+ return result;
+ }
+
+ @Produces
+ @SessionScoped
Review Comment:
It could be `@ApplicationScoped` here. I copied it from the client test where there are other reasons to have it `@SessionScoped` (and it works there for sure). Should I change it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ppalaga merged pull request #5271: Test REST to SOAP bridge scenario
Posted by "ppalaga (via GitHub)" <gi...@apache.org>.
ppalaga merged PR #5271:
URL: https://github.com/apache/camel-quarkus/pull/5271
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org