You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@tez.apache.org by "Jonathan Turner Eagles (Jira)" <ji...@apache.org> on 2020/07/17 17:31:00 UTC
[jira] [Commented] (TEZ-4133) key class implements
writableComparable and configurable use default configuration
[ https://issues.apache.org/jira/browse/TEZ-4133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17160104#comment-17160104 ]
Jonathan Turner Eagles commented on TEZ-4133:
---------------------------------------------
[~backkom], thank you for the patch. I have assigned this jira to you and added you to the contributors list for this project. The patch does fix this issue. However, can you address the asf license problem
{noformat}
Lines that start with ????? in the ASF License report indicate files that do not have an Apache license header:
!????? src/test/java/org/apache/tez/runtime/library/common/TestConfigUtils.java
{noformat}
> key class implements writableComparable and configurable use default configuration
> ----------------------------------------------------------------------------------
>
> Key: TEZ-4133
> URL: https://issues.apache.org/jira/browse/TEZ-4133
> Project: Apache Tez
> Issue Type: Bug
> Reporter: wang qiang
> Assignee: wang qiang
> Priority: Major
> Attachments: TEZ-4133-1.patch
>
>
> key class implments writableComparable and configurable ,setConf be invoked with a default configuration,it should like mapreduce(org.apache.hadoop.mapred.JobConf#getOutputKeyComparator)
> {code:java}
> //org.apache.tez.runtime.library.common.ConfigUtils#getIntermediateOutputKeyComparator
> public static <K> RawComparator<K> getIntermediateOutputKeyComparator(Configuration conf) {
> Class<? extends RawComparator> theClass = conf.getClass(
> TezRuntimeConfiguration.TEZ_RUNTIME_KEY_COMPARATOR_CLASS, null,
> RawComparator.class);
> if (theClass != null)
> return ReflectionUtils.newInstance(theClass, conf);
> // aybe change to
> // return WritableComparator.get(getIntermediateOutputKeyClass(conf).asSubclass( //WritableComparable.class),conf);
> return WritableComparator.get(getIntermediateOutputKeyClass(conf).asSubclass(
> WritableComparable.class));
> }
> public static <K> RawComparator<K> getIntermediateInputKeyComparator(Configuration conf) {
> Class<? extends RawComparator> theClass = conf.getClass(
> TezRuntimeConfiguration.TEZ_RUNTIME_KEY_COMPARATOR_CLASS, null,
> RawComparator.class);
> if (theClass != null)
> return ReflectionUtils.newInstance(theClass, conf);
> // maybe change to
> // return WritableComparator.get(getIntermediateInputKeyClass(conf).asSubclass( //WritableComparable.class),conf);
> return WritableComparator.get(getIntermediateInputKeyClass(conf).asSubclass(
> WritableComparable.class));
> }
> {code}
>
>
>
>
>
>
>
>
>
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)