[GitHub] [flink] klion26 commented on a change in pull request #12304: [FLINK-15620] Remove deprecated enable default background cleanup

[GitBox <gi...@apache.org>]

klion26 commented on a change in pull request #12304:
URL: https://github.com/apache/flink/pull/12304#discussion_r429711669



##########
File path: flink-core/src/main/java/org/apache/flink/api/common/state/StateTtlConfig.java
##########
@@ -282,7 +282,7 @@ public Builder cleanupIncrementally(
 		 * https://github.com/facebook/rocksdb/blob/master/include/rocksdb/compaction_filter.h#L69
 		 * It means that the TTL filter should be tested for List state taking into account this caveat.
 		 *
-		 * @deprecated Use more general configuration method {@link #cleanupInBackground()} instead
+		 * @deprecated

Review comment:
       As we introduced `cleanupInBackground` to deprecate the function `cleanupInRocksdbCompactFilter`, now, we removed `cleanupInBackground`, do we need to remove the function `cleanupInRocksdbCompactFilter` also?

##########
File path: flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBOptions.java
##########
@@ -78,6 +78,7 @@
 		.withDescription("This determines if compaction filter to cleanup state with TTL is enabled for backend. " +
 			"Note: User can still decide in state TTL configuration in state descriptor " +
 			"whether the filter is active for particular state or not.");
+

Review comment:
       maybe we should revert such change.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org