You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@samza.apache.org by GitBox <gi...@apache.org> on 2020/03/17 20:52:48 UTC

[GitHub] [samza] cameronlee314 opened a new pull request #1316: Update versions on website for 1.4 release branch

cameronlee314 opened a new pull request #1316: Update versions on website for 1.4 release branch
URL: https://github.com/apache/samza/pull/1316
 
 
   Updating branch according to `docs/README.md`.
   Testing: Deployed website locally and verified some of the documentation links.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [samza] cameronlee314 merged pull request #1316: Update versions on website for 1.4 release branch

Posted by GitBox <gi...@apache.org>.
cameronlee314 merged pull request #1316: Update versions on website for 1.4 release branch
URL: https://github.com/apache/samza/pull/1316
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [samza] prateekm commented on a change in pull request #1316: Update versions on website for 1.4 release branch

Posted by GitBox <gi...@apache.org>.
prateekm commented on a change in pull request #1316: Update versions on website for 1.4 release branch
URL: https://github.com/apache/samza/pull/1316#discussion_r394038261
 
 

 ##########
 File path: docs/_menu/index.html
 ##########
 @@ -12,6 +12,10 @@
     items_attributes: 'data-documentation="/learn/documentation/version/"'
   - menu_title: Releases
     items:
+      - menu_title: 1.3.1
 
 Review comment:
   Thanks for adding these. Do you need one for 1.4.0 as well?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [samza] cameronlee314 commented on a change in pull request #1316: Update versions on website for 1.4 release branch

Posted by GitBox <gi...@apache.org>.
cameronlee314 commented on a change in pull request #1316: Update versions on website for 1.4 release branch
URL: https://github.com/apache/samza/pull/1316#discussion_r394065845
 
 

 ##########
 File path: docs/_menu/index.html
 ##########
 @@ -12,6 +12,10 @@
     items_attributes: 'data-documentation="/learn/documentation/version/"'
   - menu_title: Releases
     items:
+      - menu_title: 1.3.1
 
 Review comment:
   The `releases/1.4.0` page will get added onto the `master` branch.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [samza] cameronlee314 commented on a change in pull request #1316: Update versions on website for 1.4 release branch

Posted by GitBox <gi...@apache.org>.
cameronlee314 commented on a change in pull request #1316: Update versions on website for 1.4 release branch
URL: https://github.com/apache/samza/pull/1316#discussion_r394051948
 
 

 ##########
 File path: docs/_config.yml
 ##########
 @@ -23,9 +23,9 @@ redcarpet:
   extensions: ['with_toc_data', 'smart', 'strikethrough', 'tables']
 exclude: [_docs]
 baseurl: http://samza.apache.org
-version: latest
+version: '1.4.0'
 
 Review comment:
   This is for the `1.4.0` branch. It will stay `latest` on the `master` branch.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [samza] prateekm commented on a change in pull request #1316: Update versions on website for 1.4 release branch

Posted by GitBox <gi...@apache.org>.
prateekm commented on a change in pull request #1316: Update versions on website for 1.4 release branch
URL: https://github.com/apache/samza/pull/1316#discussion_r394037261
 
 

 ##########
 File path: docs/_config.yml
 ##########
 @@ -23,9 +23,9 @@ redcarpet:
   extensions: ['with_toc_data', 'smart', 'strikethrough', 'tables']
 exclude: [_docs]
 baseurl: http://samza.apache.org
-version: latest
+version: '1.4.0'
 
 Review comment:
   Should this stay as latest?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services