You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "fhueske (via GitHub)" <gi...@apache.org> on 2026/08/28 10:14:23 UTC
[PR] [FLINK-40498][tests] Adjust LateralSnapshotJoin tests for optional TABLE keyword [flink]
fhueske opened a new pull request, #29035:
URL: https://github.com/apache/flink/pull/29035
## What is the purpose of the change
Drop the now-optional TABLE keyword from the LATERAL table-function calls in the LATERAL SNAPSHOT test suite, using the "LATERAL SNAPSHOT(...)" form. One plan test (testInnerJoin) and one semantic test program (INNER_JOIN) keep the explicit "LATERAL TABLE(SNAPSHOT(...))" form to retain coverage of that syntax.
## Brief change log
* update most LATERAL SNAPSHOT join tests to use the syntax without the optional TABLE keyword
* two tests keep using the TABLE keyword for test coverage
## Verifying this change
* existing tests
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? n/a
---
##### Was generative AI tooling used to co-author this PR?
- [X] Yes (please specify the tool below)
Generated-by: Claude Code (Opus 4.8 1M)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-40498][tests] Adjust LateralSnapshotJoin tests for optional TABLE keyword [flink]
Posted by "fhueske (via GitHub)" <gi...@apache.org>.
fhueske commented on code in PR #29035:
URL: https://github.com/apache/flink/pull/29035#discussion_r3880061017
##########
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/batch/sql/join/LateralSnapshotJoinTest.java:
##########
@@ -71,55 +71,55 @@ void setup() {
@Test
void testInnerJoin() {
util.verifyRelPlan(
- "SELECT * FROM probe JOIN LATERAL TABLE(SNAPSHOT("
+ "SELECT * FROM probe JOIN LATERAL SNAPSHOT("
Review Comment:
Yes, good point. I left two with the TABLE keyword.
The first ones in `LateralSnapshotJoinTest` and `LateralSnapshotJoinSemanticTestPrograms`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-40498][tests] Adjust LateralSnapshotJoin tests for optional TABLE keyword [flink]
Posted by "snuyanzin (via GitHub)" <gi...@apache.org>.
snuyanzin commented on code in PR #29035:
URL: https://github.com/apache/flink/pull/29035#discussion_r3879954978
##########
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/batch/sql/join/LateralSnapshotJoinTest.java:
##########
@@ -71,55 +71,55 @@ void setup() {
@Test
void testInnerJoin() {
util.verifyRelPlan(
- "SELECT * FROM probe JOIN LATERAL TABLE(SNAPSHOT("
+ "SELECT * FROM probe JOIN LATERAL SNAPSHOT("
Review Comment:
I wonder if we need to keep 1-2 tests with `TABLE` just to be sure it is still not broken...
WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-40498][tests] Adjust LateralSnapshotJoin tests for optional TABLE keyword [flink]
Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #29035:
URL: https://github.com/apache/flink/pull/29035#issuecomment-5451389282
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ce119a4600552094500e12685fea8db21f6476f3",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "ce119a4600552094500e12685fea8db21f6476f3",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ce119a4600552094500e12685fea8db21f6476f3 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-40498][tests] Adjust LateralSnapshotJoin tests for optional TABLE keyword [flink]
Posted by "fhueske (via GitHub)" <gi...@apache.org>.
fhueske merged PR #29035:
URL: https://github.com/apache/flink/pull/29035
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org