[GitHub] [trafficserver] SolidWallOfCode opened a new pull request #7806: TSHttpTxnCacheDiskPathGet - tighten up the code a bit.

[GitBox <gi...@apache.org>]

SolidWallOfCode opened a new pull request #7806:
URL: https://github.com/apache/trafficserver/pull/7806


   This may be a re-used pattern going forward, as we move to a view oriented API, so it pays to have tight code as the basis. Plus, I simply couldn't resist. A key, non-obvious requirement from Zwoop was to avoid calling `strlen` if there was no place to store the length.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficserver] zwoop commented on pull request #7806: TSHttpTxnCacheDiskPathGet - tighten up the code a bit.

[GitBox <gi...@apache.org>]

zwoop commented on pull request #7806:
URL: https://github.com/apache/trafficserver/pull/7806#issuecomment-837475439


   This feels nitpick at best, possibly overly aggressive on compacting code at the expense of making debugging more difficult.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficserver] SolidWallOfCode merged pull request #7806: TSHttpTxnCacheDiskPathGet - tighten up the code a bit.

[GitBox <gi...@apache.org>]

SolidWallOfCode merged pull request #7806:
URL: https://github.com/apache/trafficserver/pull/7806


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org